Re: [PR] Upgrade http5 Client to 5.4 and using Http 2 Protocol [pinot]

2024-11-01 Thread via GitHub
abhioncbr commented on PR #14191: URL: https://github.com/apache/pinot/pull/14191#issuecomment-2452698588 We will wait for http5-client 5.4.2 version, to check if the fix is there for Http1.1 -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] Upgrade http5 Client to 5.4 and using Http 2 Protocol [pinot]

2024-10-25 Thread via GitHub
Jackie-Jiang commented on PR #14191: URL: https://github.com/apache/pinot/pull/14191#issuecomment-2436122218 For reference: [5.4 release note](https://downloads.apache.org/httpcomponents/httpclient/RELEASE_NOTES-5.4.x.txt) -- This is an automated message from the Apache Git Service. To re

Re: [PR] Upgrade http5 Client to 5.4 and using Http 2 Protocol [pinot]

2024-10-25 Thread via GitHub
Jackie-Jiang commented on code in PR #14191: URL: https://github.com/apache/pinot/pull/14191#discussion_r1815521655 ## pinot-common/src/main/java/org/apache/pinot/common/http/MultiHttpRequest.java: ## @@ -116,7 +117,8 @@ public CompletionService completionService = new Execut

Re: [PR] Upgrade http5 Client to 5.4 and using Http 2 Protocol [pinot]

2024-10-24 Thread via GitHub
abhioncbr commented on PR #14191: URL: https://github.com/apache/pinot/pull/14191#issuecomment-2436418018 > This is the highlighted release note, not sure if related to the issue we encountered: > > ``` > IMPORTANT! The new cache entry serialization format is incompatible with ear

Re: [PR] Upgrade http5 Client to 5.4 and using Http 2 Protocol [pinot]

2024-10-24 Thread via GitHub
Jackie-Jiang commented on PR #14191: URL: https://github.com/apache/pinot/pull/14191#issuecomment-2436124636 This is the highlighted release note, not sure if related to the issue we encountered: ``` IMPORTANT! The new cache entry serialization format is incompatible with earlier v

Re: [PR] Upgrade http5 Client to 5.4 and using Http 2 Protocol [pinot]

2024-10-24 Thread via GitHub
abhioncbr commented on PR #14191: URL: https://github.com/apache/pinot/pull/14191#issuecomment-2435352441 > Thanks for debugging this! > > Can you elaborate more on the root cause? Since the bug was fixed in the new version, why would our test fail? Is there extra overhead if we do no