Re: [PR] Updated for commons-configuration2 in PinotConfiguartion [pinot]

2023-11-07 Thread via GitHub
Jackie-Jiang merged PR #11916: URL: https://github.com/apache/pinot/pull/11916 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Updated for commons-configuration2 in PinotConfiguartion [pinot]

2023-11-07 Thread via GitHub
abhioncbr commented on PR #11916: URL: https://github.com/apache/pinot/pull/11916#issuecomment-1799538701 @Jackie-Jiang, Can you please review it once more? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Updated for commons-configuration2 in PinotConfiguartion [pinot]

2023-11-03 Thread via GitHub
Jackie-Jiang commented on code in PR #11916: URL: https://github.com/apache/pinot/pull/11916#discussion_r1382293393 ## pinot-spi/src/main/java/org/apache/pinot/spi/env/CommonsConfigurationUtils.java: ## @@ -32,27 +32,54 @@ import java.util.stream.Collectors; import java.util.s

Re: [PR] Updated for commons-configuration2 in PinotConfiguartion [pinot]

2023-11-01 Thread via GitHub
codecov-commenter commented on PR #11916: URL: https://github.com/apache/pinot/pull/11916#issuecomment-1788796124 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11916?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[PR] Updated for commons-configuration2 in PinotConfiguartion [pinot]

2023-11-01 Thread via GitHub
abhioncbr opened a new pull request, #11916: URL: https://github.com/apache/pinot/pull/11916 In continuation of the previous work https://github.com/apache/pinot/pull/11792 & https://github.com/apache/pinot/pull/11868, This PR upgrade the `PinotConfiguartion` to `commons-configuartion2`