Re: [PR] Specify start index of file name in GenerateDataCommand [pinot]

2024-12-02 Thread via GitHub
yashmayya merged PR #14573: URL: https://github.com/apache/pinot/pull/14573 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

Re: [PR] Specify start index of file name in GenerateDataCommand [pinot]

2024-12-02 Thread via GitHub
codecov-commenter commented on PR #14573: URL: https://github.com/apache/pinot/pull/14573#issuecomment-2511199782 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14573?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Specify start index of file name in GenerateDataCommand [pinot]

2024-12-02 Thread via GitHub
vrajat commented on PR #14573: URL: https://github.com/apache/pinot/pull/14573#issuecomment-2511134031 > The changes look fine to me but what's the use case for this exactly? I've updated the description. Tell me if it is more informative. -- This is an automated message from the A

Re: [PR] Specify start index of file name in GenerateDataCommand [pinot]

2024-12-02 Thread via GitHub
vrajat commented on code in PR #14573: URL: https://github.com/apache/pinot/pull/14573#discussion_r1865580434 ## pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/GenerateDataCommand.java: ## @@ -120,9 +123,9 @@ public boolean execute() gen.init(spec); i

Re: [PR] Specify start index of file name in GenerateDataCommand [pinot]

2024-12-02 Thread via GitHub
yashmayya commented on code in PR #14573: URL: https://github.com/apache/pinot/pull/14573#discussion_r1865573770 ## pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/GenerateDataCommand.java: ## @@ -120,9 +123,9 @@ public boolean execute() gen.init(spec);

[PR] Specify start index of file name in GenerateDataCommand [pinot]

2024-12-02 Thread via GitHub
vrajat opened a new pull request, #14573: URL: https://github.com/apache/pinot/pull/14573 `GenerateDataCommand` can generate data in multiple files. The number of files is specified using `-numFiles`. File name are generated with an int as the suffix starting from 0. This PR adds the ab