NihalJain commented on PR #15861:
URL: https://github.com/apache/pinot/pull/15861#issuecomment-2930978998
> The refactor definitely reduces duplicate code by
>
> * Moving part of the common code to `BasicAuthUtils.java`.
>
> * Moving other parts to respective base classes.
NihalJain commented on PR #15861:
URL: https://github.com/apache/pinot/pull/15861#issuecomment-2912139771
> Making sure I understand the goal correctly:
>
> * Common code for each of controller, broker & server have been moved to
abstract classes in each of the packages.
> * Common
NihalJain commented on PR #15861:
URL: https://github.com/apache/pinot/pull/15861#issuecomment-2912140454
Also rebased to re-trigger tests!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
vrajat commented on PR #15861:
URL: https://github.com/apache/pinot/pull/15861#issuecomment-2911095481
Making sure I understand the goal correctly:
* Common code for each of controller, broker & server have been moved to
abstract classes in each of the packages.
* Common code across
vrajat commented on PR #15861:
URL: https://github.com/apache/pinot/pull/15861#issuecomment-2911097881
I know there are tests for Basic auth for broker & controller. Are there
tests for server auth AND for zk auth ? Can you also mention any manual tests
that you have done ?
--
This is an
NihalJain commented on PR #15861:
URL: https://github.com/apache/pinot/pull/15861#issuecomment-2905035208
Rebased to fix conflicts!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
