Re: [PR] Refactor PinotSchemaRestletResource for repetitive code pattern [pinot]

2024-07-24 Thread via GitHub
jackjlli merged PR #13680: URL: https://github.com/apache/pinot/pull/13680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

Re: [PR] Refactor PinotSchemaRestletResource for repetitive code pattern [pinot]

2024-07-23 Thread via GitHub
abhioncbr commented on code in PR #13680: URL: https://github.com/apache/pinot/pull/13680#discussion_r1688275679 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSchemaRestletResource.java: ## @@ -539,4 +528,27 @@ private void deleteSchemaInternal

Re: [PR] Refactor PinotSchemaRestletResource for repetitive code pattern [pinot]

2024-07-23 Thread via GitHub
shounakmk219 commented on code in PR #13680: URL: https://github.com/apache/pinot/pull/13680#discussion_r1688232094 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSchemaRestletResource.java: ## @@ -539,4 +528,27 @@ private void deleteSchemaInter

Re: [PR] Refactor PinotSchemaRestletResource for repetitive code pattern [pinot]

2024-07-23 Thread via GitHub
shounakmk219 commented on code in PR #13680: URL: https://github.com/apache/pinot/pull/13680#discussion_r1688229164 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSchemaRestletResource.java: ## @@ -539,4 +528,27 @@ private void deleteSchemaInter

Re: [PR] Refactor PinotSchemaRestletResource for repetitive code pattern [pinot]

2024-07-22 Thread via GitHub
codecov-commenter commented on PR #13680: URL: https://github.com/apache/pinot/pull/13680#issuecomment-2244148045 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13680?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Refactor PinotSchemaRestletResource for repetitive code pattern [pinot]

2024-07-22 Thread via GitHub
abhioncbr opened a new pull request, #13680: URL: https://github.com/apache/pinot/pull/13680 TODO -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail