Re: [PR] Potential bug fix for partial-upsert with sorted-indexes [pinot]

2024-03-03 Thread via GitHub
tibrewalpratik17 commented on code in PR #12544: URL: https://github.com/apache/pinot/pull/12544#discussion_r1510236537 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java: ## @@ -640,7 +640,10 @@ protected static It

Re: [PR] Potential bug fix for partial-upsert with sorted-indexes [pinot]

2024-03-02 Thread via GitHub
ankitsultana commented on code in PR #12544: URL: https://github.com/apache/pinot/pull/12544#discussion_r1510117525 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java: ## @@ -640,7 +640,10 @@ protected static Iterat

Re: [PR] Potential bug fix for partial-upsert with sorted-indexes [pinot]

2024-03-02 Thread via GitHub
codecov-commenter commented on PR #12544: URL: https://github.com/apache/pinot/pull/12544#issuecomment-1974945339 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12544?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[PR] Potential bug fix for partial-upsert with sorted-indexes [pinot]

2024-03-02 Thread via GitHub
tibrewalpratik17 opened a new pull request, #12544: URL: https://github.com/apache/pinot/pull/12544 label: `bugfix` Potential fix for #12397 As called out in the issue: ``` With Partial Upserts, say we had 4 events for a given primary-key in the Mutable Segment: R0,