Re: [PR] Normalize excessive whitespaces in sql to avoid regex performance issues [pinot]

Jackie-Jiang merged PR #15498: URL: https://github.com/apache/pinot/pull/15498 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Normalize excessive whitespaces in sql to avoid regex performance issues [pinot]

jitendrakr88 commented on code in PR #15498: URL: https://github.com/apache/pinot/pull/15498#discussion_r2049668083 ## pinot-common/src/main/java/org/apache/pinot/sql/parsers/ParserUtils.java: ## @@ -39,6 +39,49 @@ public static void validateFunction(String canonicalName, List

Re: [PR] Normalize excessive whitespaces in sql to avoid regex performance issues [pinot]

ankitsultana commented on code in PR #15498: URL: https://github.com/apache/pinot/pull/15498#discussion_r2049189342 ## pinot-common/src/main/java/org/apache/pinot/sql/parsers/ParserUtils.java: ## @@ -39,6 +39,49 @@ public static void validateFunction(String canonicalName, List

Re: [PR] Normalize excessive whitespaces in sql to avoid regex performance issues [pinot]

ankitsultana commented on code in PR #15498: URL: https://github.com/apache/pinot/pull/15498#discussion_r2049189342 ## pinot-common/src/main/java/org/apache/pinot/sql/parsers/ParserUtils.java: ## @@ -39,6 +39,49 @@ public static void validateFunction(String canonicalName, List

Re: [PR] Normalize excessive whitespaces in sql to avoid regex performance issues [pinot]

Jackie-Jiang commented on code in PR #15498: URL: https://github.com/apache/pinot/pull/15498#discussion_r2047770813 ## pinot-common/src/main/java/org/apache/pinot/sql/parsers/ParserUtils.java: ## @@ -39,6 +39,49 @@ public static void validateFunction(String canonicalName, List

Re: [PR] Normalize excessive whitespaces in sql to avoid regex performance issues [pinot]

jitendrakr88 commented on code in PR #15498: URL: https://github.com/apache/pinot/pull/15498#discussion_r2047578237 ## pinot-common/src/main/java/org/apache/pinot/sql/parsers/ParserUtils.java: ## @@ -39,6 +39,49 @@ public static void validateFunction(String canonicalName, List

Re: [PR] Normalize excessive whitespaces in sql to avoid regex performance issues [pinot]

jitendrakr88 commented on code in PR #15498: URL: https://github.com/apache/pinot/pull/15498#discussion_r2047578237 ## pinot-common/src/main/java/org/apache/pinot/sql/parsers/ParserUtils.java: ## @@ -39,6 +39,49 @@ public static void validateFunction(String canonicalName, List

Re: [PR] Normalize excessive whitespaces in sql to avoid regex performance issues [pinot]

Jackie-Jiang commented on code in PR #15498: URL: https://github.com/apache/pinot/pull/15498#discussion_r2043250235 ## pinot-common/src/main/java/org/apache/pinot/sql/parsers/ParserUtils.java: ## @@ -39,6 +39,49 @@ public static void validateFunction(String canonicalName, List

Re: [PR] Normalize excessive whitespaces in sql to avoid regex performance issues [pinot]

ankitsultana commented on code in PR #15498: URL: https://github.com/apache/pinot/pull/15498#discussion_r2038121565 ## pinot-common/src/main/java/org/apache/pinot/sql/parsers/ParserUtils.java: ## @@ -39,6 +39,49 @@ public static void validateFunction(String canonicalName, List

Re: [PR] Normalize excessive whitespaces in sql to avoid regex performance issues [pinot]

jitendrakr88 commented on code in PR #15498: URL: https://github.com/apache/pinot/pull/15498#discussion_r2038114680 ## pinot-common/src/main/java/org/apache/pinot/sql/parsers/QueryOptionParser.java: ## @@ -0,0 +1,241 @@ +/** + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] Normalize excessive whitespaces in sql to avoid regex performance issues [pinot]

jitendrakr88 commented on code in PR #15498: URL: https://github.com/apache/pinot/pull/15498#discussion_r2038080692 ## pinot-common/src/main/java/org/apache/pinot/sql/parsers/ParserUtils.java: ## @@ -39,6 +39,49 @@ public static void validateFunction(String canonicalName, List

Re: [PR] Normalize excessive whitespaces in sql to avoid regex performance issues [pinot]

Jackie-Jiang commented on code in PR #15498: URL: https://github.com/apache/pinot/pull/15498#discussion_r2037964294 ## pinot-common/src/main/java/org/apache/pinot/sql/parsers/ParserUtils.java: ## @@ -39,6 +39,49 @@ public static void validateFunction(String canonicalName, List

Re: [PR] Normalize excessive whitespaces in sql to avoid regex performance issues [pinot]

jitendrakr88 commented on PR #15498: URL: https://github.com/apache/pinot/pull/15498#issuecomment-2794678752 Updated the implementation to collapse excessive whitespace blocks to a single whitespace. @ankitsultana @Jackie-Jiang please help take a look. -- This is an automated mess