albertobastos commented on code in PR #14346:
URL: https://github.com/apache/pinot/pull/14346#discussion_r2003421281
##
docs/dev/query/msq/tree-lifecycle.md:
##
@@ -0,0 +1,99 @@
+# Query tree lifecycle
+
+As usual in parsers and compilers, the query is transformed from a string
bziobrowski commented on code in PR #14346:
URL: https://github.com/apache/pinot/pull/14346#discussion_r1853759039
##
docs/dev/query/msq/tree-lifecycle.md:
##
@@ -0,0 +1,99 @@
+# Query tree lifecycle
+
+As usual in parsers and compilers, the query is transformed from a string to
gortiz commented on code in PR #14346:
URL: https://github.com/apache/pinot/pull/14346#discussion_r1853860601
##
docs/dev/query/msq/execution.md:
##
@@ -0,0 +1,48 @@
+# Multi stage query execution
Review Comment:
You are totally right. We need to more discipline to use alway
bziobrowski commented on code in PR #14346:
URL: https://github.com/apache/pinot/pull/14346#discussion_r1853802987
##
docs/dev/query/msq/execution.md:
##
@@ -0,0 +1,48 @@
+# Multi stage query execution
Review Comment:
I think it would be good to:
- decide on a single term
bziobrowski commented on code in PR #14346:
URL: https://github.com/apache/pinot/pull/14346#discussion_r1853796560
##
docs/dev/query/msq/tree-lifecycle.md:
##
@@ -0,0 +1,99 @@
+# Query tree lifecycle
+
+As usual in parsers and compilers, the query is transformed from a string to
bziobrowski commented on code in PR #14346:
URL: https://github.com/apache/pinot/pull/14346#discussion_r1853802987
##
docs/dev/query/msq/execution.md:
##
@@ -0,0 +1,48 @@
+# Multi stage query execution
Review Comment:
I think it would be good to:
- decide on a single term
bziobrowski commented on code in PR #14346:
URL: https://github.com/apache/pinot/pull/14346#discussion_r1853798339
##
docs/dev/query/msq/execution.md:
##
@@ -0,0 +1,48 @@
+# Multi stage query execution
+
Review Comment:
Shouldn't it point to `tree-lifecycle.md` ?
--
This
bziobrowski commented on code in PR #14346:
URL: https://github.com/apache/pinot/pull/14346#discussion_r1853792225
##
docs/dev/query/msq/tree-lifecycle.md:
##
@@ -0,0 +1,99 @@
+# Query tree lifecycle
+
+As usual in parsers and compilers, the query is transformed from a string to
bziobrowski commented on code in PR #14346:
URL: https://github.com/apache/pinot/pull/14346#discussion_r1853781530
##
docs/dev/query/msq/tree-lifecycle.md:
##
@@ -0,0 +1,99 @@
+# Query tree lifecycle
+
+As usual in parsers and compilers, the query is transformed from a string to
bziobrowski commented on code in PR #14346:
URL: https://github.com/apache/pinot/pull/14346#discussion_r1853762300
##
docs/dev/query/msq/tree-lifecycle.md:
##
@@ -0,0 +1,99 @@
+# Query tree lifecycle
+
+As usual in parsers and compilers, the query is transformed from a string to
bziobrowski commented on code in PR #14346:
URL: https://github.com/apache/pinot/pull/14346#discussion_r1853762300
##
docs/dev/query/msq/tree-lifecycle.md:
##
@@ -0,0 +1,99 @@
+# Query tree lifecycle
+
+As usual in parsers and compilers, the query is transformed from a string to
codecov-commenter commented on PR #14346:
URL: https://github.com/apache/pinot/pull/14346#issuecomment-2450308721
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/14346?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
gortiz commented on PR #14346:
URL: https://github.com/apache/pinot/pull/14346#issuecomment-2450218863
cc @bziobrowski
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
gortiz opened a new pull request, #14346:
URL: https://github.com/apache/pinot/pull/14346
This PR adds a template for dev documentation.
I've recently read the [Velox Developer
Guide](https://facebookincubator.github.io/velox/develop.html) and I really
think that it would be super us
14 matches
Mail list logo
