Re: [PR] Improve database handling in multi-stage engine [pinot]

2024-09-23 Thread via GitHub
Jackie-Jiang merged PR #14040: URL: https://github.com/apache/pinot/pull/14040 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Improve database handling in multi-stage engine [pinot]

2024-09-20 Thread via GitHub
Jackie-Jiang commented on PR #14040: URL: https://github.com/apache/pinot/pull/14040#issuecomment-2364628497 Seems the test is added in #12591, and I believe the correct syntax should be `SELECT * FROM default."tbl-escape-naming"`. Modified the test accordingly -- This is an automated mes

Re: [PR] Improve database handling in multi-stage engine [pinot]

2024-09-20 Thread via GitHub
gortiz commented on PR #14040: URL: https://github.com/apache/pinot/pull/14040#issuecomment-2363838694 I think @shounakmk219 is more informed to answer that question. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Improve database handling in multi-stage engine [pinot]

2024-09-19 Thread via GitHub
Jackie-Jiang commented on PR #14040: URL: https://github.com/apache/pinot/pull/14040#issuecomment-2362515923 The failing test has query: `SELECT * FROM "default.tbl-escape-naming"`. IIUC this should explicitly look for table with name `default.tbl-escape-naming` which doesn't exist. @gortiz

Re: [PR] Improve database handling in multi-stage engine [pinot]

2024-09-19 Thread via GitHub
codecov-commenter commented on PR #14040: URL: https://github.com/apache/pinot/pull/14040#issuecomment-2362456222 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14040?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u