Re: [PR] Improve async temp segment delete in validation manager [pinot]

2024-10-30 Thread via GitHub
xiangfu0 merged PR #14339: URL: https://github.com/apache/pinot/pull/14339 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

Re: [PR] Improve async temp segment delete in validation manager [pinot]

2024-10-30 Thread via GitHub
Jackie-Jiang commented on PR #14339: URL: https://github.com/apache/pinot/pull/14339#issuecomment-2448334434 #9466 Introduced a way to read last modified time without fetching metadata one by one. Currently it only supports S3 and GCS. Since we only need to read last modified time for files

Re: [PR] Improve async temp segment delete in validation manager [pinot]

2024-10-30 Thread via GitHub
codecov-commenter commented on PR #14339: URL: https://github.com/apache/pinot/pull/14339#issuecomment-2448276369 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14339?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Improve async temp segment delete in validation manager [pinot]

2024-10-30 Thread via GitHub
Jackie-Jiang opened a new pull request, #14339: URL: https://github.com/apache/pinot/pull/14339 - Only check modified time for files that match the temp file name - Remove some unnecessary check such as table name, table config existence -- This is an automated message from the Apache G