Re: [PR] Implement ordering in segment state transitions [pinot]

2025-03-18 Thread via GitHub
noob-se7en commented on PR #15261: URL: https://github.com/apache/pinot/pull/15261#issuecomment-2734838977 @Jackie-Jiang this PR is not in ready state as of now. We want to rely on sequence number instead of segmentZkMetadata for previous segment. -- This is an automated message from the

Re: [PR] Implement ordering in segment state transitions [pinot]

2025-03-18 Thread via GitHub
noob-se7en commented on PR #15261: URL: https://github.com/apache/pinot/pull/15261#issuecomment-2734850456 The problem you mentioned is fixed in this PR: https://github.com/apache/pinot/pull/15246 This PR needs to merge above. -- This is an automated message from the Apache Git Service

Re: [PR] Implement ordering in segment state transitions [pinot]

2025-03-18 Thread via GitHub
Jackie-Jiang commented on code in PR #15261: URL: https://github.com/apache/pinot/pull/15261#discussion_r2002038117 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -927,6 +927,8 @@ private void createNe