Re: [PR] Fix bug to return validDocIDsMetadata from all servers [pinot]

2024-02-20 Thread via GitHub
snleee merged PR #12431: URL: https://github.com/apache/pinot/pull/12431 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apach

Re: [PR] Fix bug to return validDocIDsMetadata from all servers [pinot]

2024-02-20 Thread via GitHub
snleee commented on PR #12431: URL: https://github.com/apache/pinot/pull/12431#issuecomment-1955031125 @tibrewalpratik17 can we combine this pr with https://github.com/apache/pinot/pull/12445? -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] Fix bug to return validDocIDsMetadata from all servers [pinot]

2024-02-20 Thread via GitHub
tibrewalpratik17 commented on PR #12431: URL: https://github.com/apache/pinot/pull/12431#issuecomment-1954741991 @snleee can you take a look at this fix for the tagged issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] Fix bug to return validDocIDsMetadata from all servers [pinot]

2024-02-15 Thread via GitHub
codecov-commenter commented on PR #12431: URL: https://github.com/apache/pinot/pull/12431#issuecomment-1947173608 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12431?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[PR] Fix bug to return validDocIDsMetadata from all servers [pinot]

2024-02-15 Thread via GitHub
tibrewalpratik17 opened a new pull request, #12431: URL: https://github.com/apache/pinot/pull/12431 label: `bugfix` Fixes #12423 We were sending `serverToEndpoints` mapping instead of `endpointsToServer` which is expected by CompletionService. That's why CompletionService