Re: [PR] Expose Get Segments/Table Config Change capture [pinot]

Jackie-Jiang merged PR #13915: URL: https://github.com/apache/pinot/pull/13915 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Expose Get Segments/Table Config Change capture [pinot]

deepthi912 commented on PR #13915: URL: https://github.com/apache/pinot/pull/13915#issuecomment-2327571584 getReloadCheckResponses, made this method public. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] Expose Get Segments/Table Config Change capture [pinot]

Jackie-Jiang commented on PR #13915: URL: https://github.com/apache/pinot/pull/13915#issuecomment-2327564895 I don't fully follow. Currently this PR becomes a pure refactor without adding public method -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Expose Get Segments/Table Config Change capture [pinot]

deepthi912 commented on code in PR #13915: URL: https://github.com/apache/pinot/pull/13915#discussion_r1742773173 ## pinot-controller/src/main/java/org/apache/pinot/controller/util/TableMetadataReader.java: ## @@ -60,21 +60,28 @@ public TableMetadataReader(Executor executor, Ht

Re: [PR] Expose Get Segments/Table Config Change capture [pinot]

deepthi912 commented on PR #13915: URL: https://github.com/apache/pinot/pull/13915#issuecomment-2327549775 Do you want to add a new method boolean isReloadNeeded()? Re: I am thinking to extract boolean in the integration with the server responses. -- This is an automated message from t

Re: [PR] Expose Get Segments/Table Config Change capture [pinot]

deepthi912 commented on code in PR #13915: URL: https://github.com/apache/pinot/pull/13915#discussion_r1742773173 ## pinot-controller/src/main/java/org/apache/pinot/controller/util/TableMetadataReader.java: ## @@ -60,21 +60,28 @@ public TableMetadataReader(Executor executor, Ht

Re: [PR] Expose Get Segments/Table Config Change capture [pinot]

Jackie-Jiang commented on code in PR #13915: URL: https://github.com/apache/pinot/pull/13915#discussion_r1742764772 ## pinot-controller/src/main/java/org/apache/pinot/controller/util/TableMetadataReader.java: ## @@ -60,21 +60,28 @@ public TableMetadataReader(Executor executor,

Re: [PR] Expose Get Segments/Table Config Change capture [pinot]

deepthi912 commented on code in PR #13915: URL: https://github.com/apache/pinot/pull/13915#discussion_r1742705976 ## pinot-controller/src/main/java/org/apache/pinot/controller/util/TableMetadataReader.java: ## @@ -86,6 +86,16 @@ public JsonNode getSegmentsMetadata(String tableN

Re: [PR] Expose Get Segments/Table Config Change capture [pinot]

deepthi912 commented on code in PR #13915: URL: https://github.com/apache/pinot/pull/13915#discussion_r1739563818 ## pinot-controller/src/main/java/org/apache/pinot/controller/util/TableMetadataReader.java: ## @@ -86,6 +86,16 @@ public JsonNode getSegmentsMetadata(String tableN