Re: [PR] Deterministic Hash Function for UUID Primary Keys [pinot]

ankitsultana commented on PR #12538: URL: https://github.com/apache/pinot/pull/12538#issuecomment-2031252530 @satishd : yeah just to be clear, I had meant collision between keys that don't conform to UUID format. > @ankitsultana If any of the values is not of type UUID and hash functi

Re: [PR] Deterministic Hash Function for UUID Primary Keys [pinot]

satishd commented on code in PR #12538: URL: https://github.com/apache/pinot/pull/12538#discussion_r1547180230 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/HashUtils.java: ## @@ -44,8 +73,31 @@ public static Object hashPrimaryKey(PrimaryKey primaryKe

Re: [PR] Deterministic Hash Function for UUID Primary Keys [pinot]

ankitsultana commented on PR #12538: URL: https://github.com/apache/pinot/pull/12538#issuecomment-2029083877 @chenboat @satishd : I was thinking about this today and I think appending a null-byte is not the right approach, since it can lead to collisions (albeit on sub-optimally defined pri

Re: [PR] Deterministic Hash Function for UUID Primary Keys [pinot]

ankitsultana commented on code in PR #12538: URL: https://github.com/apache/pinot/pull/12538#discussion_r1544687804 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/HashUtils.java: ## @@ -44,8 +73,30 @@ public static Object hashPrimaryKey(PrimaryKey prim

Re: [PR] Deterministic Hash Function for UUID Primary Keys [pinot]

eaugene commented on code in PR #12538: URL: https://github.com/apache/pinot/pull/12538#discussion_r151130 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/HashUtils.java: ## @@ -44,8 +73,30 @@ public static Object hashPrimaryKey(PrimaryKey primaryKe

Re: [PR] Deterministic Hash Function for UUID Primary Keys [pinot]

chenboat commented on code in PR #12538: URL: https://github.com/apache/pinot/pull/12538#discussion_r1543765265 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/HashUtils.java: ## @@ -44,8 +75,26 @@ public static Object hashPrimaryKey(PrimaryKey primaryK

Re: [PR] Deterministic Hash Function for UUID Primary Keys [pinot]

chenboat commented on code in PR #12538: URL: https://github.com/apache/pinot/pull/12538#discussion_r1543747564 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/HashUtils.java: ## @@ -36,6 +40,33 @@ public static byte[] hashMD5(byte[] bytes) { retur

Re: [PR] Deterministic Hash Function for UUID Primary Keys [pinot]

ankitsultana commented on code in PR #12538: URL: https://github.com/apache/pinot/pull/12538#discussion_r1537981018 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/HashUtils.java: ## @@ -44,8 +75,26 @@ public static Object hashPrimaryKey(PrimaryKey prim

Re: [PR] Deterministic Hash Function for UUID Primary Keys [pinot]

ankitsultana commented on code in PR #12538: URL: https://github.com/apache/pinot/pull/12538#discussion_r1534288165 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/HashUtils.java: ## @@ -36,6 +40,35 @@ public static byte[] hashMD5(byte[] bytes) { r