Re: [PR] DRAFT: Adding SHOW TABLES/DESCRIBE table support [pinot]

2024-04-29 Thread via GitHub
aadilkhalifa commented on code in PR #12537: URL: https://github.com/apache/pinot/pull/12537#discussion_r1582877639 ## pinot-common/src/main/codegen/includes/parserImpls.ftl: ## @@ -109,3 +109,14 @@ SqlNode SqlPhysicalExplain() : nDynamicParams); } } +SqlNode

Re: [PR] DRAFT: Adding SHOW TABLES/DESCRIBE table support [pinot]

2024-04-29 Thread via GitHub
aadilkhalifa commented on code in PR #12537: URL: https://github.com/apache/pinot/pull/12537#discussion_r1582876981 ## pinot-common/src/thrift/query.thrift: ## @@ -32,6 +32,8 @@ struct PinotQuery { 11: optional map queryOptions; 12: optional bool explain; 13: optional m

Re: [PR] DRAFT: Adding SHOW TABLES/DESCRIBE table support [pinot]

2024-04-17 Thread via GitHub
Jackie-Jiang commented on code in PR #12537: URL: https://github.com/apache/pinot/pull/12537#discussion_r1569749650 ## pinot-common/src/main/codegen/includes/parserImpls.ftl: ## @@ -109,3 +109,14 @@ SqlNode SqlPhysicalExplain() : nDynamicParams); } } +SqlNode

Re: [PR] DRAFT: Adding SHOW TABLES/DESCRIBE table support [pinot]

2024-03-10 Thread via GitHub
aadilkhalifa commented on code in PR #12537: URL: https://github.com/apache/pinot/pull/12537#discussion_r1519153810 ## pinot-common/src/main/java/org/apache/pinot/common/request/PinotQuery.java: ## @@ -41,6 +41,8 @@ public class PinotQuery implements org.apache.thrift.TBase

Re: [PR] DRAFT: Adding SHOW TABLES/DESCRIBE table support [pinot]

2024-03-10 Thread via GitHub
aadilkhalifa commented on code in PR #12537: URL: https://github.com/apache/pinot/pull/12537#discussion_r1519153285 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java: ## @@ -150,10 +153,12 @@ public abstract class BaseBrokerReques

Re: [PR] DRAFT: Adding SHOW TABLES/DESCRIBE table support [pinot]

2024-03-04 Thread via GitHub
xiangfu0 commented on code in PR #12537: URL: https://github.com/apache/pinot/pull/12537#discussion_r1511836215 ## pinot-common/src/main/java/org/apache/pinot/common/request/PinotQuery.java: ## @@ -41,6 +41,8 @@ public class PinotQuery implements org.apache.thrift.TBase

Re: [PR] DRAFT: Adding SHOW TABLES/DESCRIBE table support [pinot]

2024-03-04 Thread via GitHub
xiangfu0 commented on code in PR #12537: URL: https://github.com/apache/pinot/pull/12537#discussion_r1511663907 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java: ## @@ -150,10 +153,12 @@ public abstract class BaseBrokerRequestHan

Re: [PR] DRAFT: Adding SHOW TABLES/DESCRIBE table support [pinot]

2024-03-04 Thread via GitHub
xiangfu0 commented on code in PR #12537: URL: https://github.com/apache/pinot/pull/12537#discussion_r1511663907 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java: ## @@ -150,10 +153,12 @@ public abstract class BaseBrokerRequestHan

Re: [PR] DRAFT: Adding SHOW TABLES/DESCRIBE table support [pinot]

2024-03-04 Thread via GitHub
aadilkhalifa commented on code in PR #12537: URL: https://github.com/apache/pinot/pull/12537#discussion_r1510984829 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java: ## @@ -243,10 +246,17 @@ private String getQueryResponse(Strin

Re: [PR] DRAFT: Adding SHOW TABLES/DESCRIBE table support [pinot]

2024-03-02 Thread via GitHub
xiangfu0 commented on code in PR #12537: URL: https://github.com/apache/pinot/pull/12537#discussion_r1509943974 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java: ## @@ -243,10 +246,17 @@ private String getQueryResponse(String qu

Re: [PR] DRAFT: Adding SHOW TABLES/DESCRIBE table support [pinot]

2024-03-02 Thread via GitHub
codecov-commenter commented on PR #12537: URL: https://github.com/apache/pinot/pull/12537#issuecomment-1974751774 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12537?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[PR] DRAFT: Adding SHOW TABLES/DESCRIBE table support [pinot]

2024-03-01 Thread via GitHub
aadilkhalifa opened a new pull request, #12537: URL: https://github.com/apache/pinot/pull/12537 PR to add support for "SHOW TABLES" and "DESCRIBE table" queries. Current status: - [x] SHOW TABLES - [ ] DESCRIBE table -- This is an automated message from the Apache Git Service.