Re: [PR] Controller AccessControl interface accepts Request parameter [pinot]

2024-12-17 Thread via GitHub
soumitra-st commented on PR #14414: URL: https://github.com/apache/pinot/pull/14414#issuecomment-2549465789 @ilamhs , have you looked at [FineGrainedAccessControl.hasAccess](https://github.com/apache/pinot/blob/2719c5c9bc695d5257a1b5309c951e4a8b7dac9a/pinot-core/src/main/java/org/apache/pino

Re: [PR] Controller AccessControl interface accepts Request parameter [pinot]

2024-11-22 Thread via GitHub
shounakmk219 commented on code in PR #14414: URL: https://github.com/apache/pinot/pull/14414#discussion_r1853639186 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/access/AccessControlUtils.java: ## @@ -43,24 +44,25 @@ private AccessControlUtils() { /**

Re: [PR] Controller AccessControl interface accepts Request parameter [pinot]

2024-11-21 Thread via GitHub
ilamhs commented on code in PR #14414: URL: https://github.com/apache/pinot/pull/14414#discussion_r1852725021 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/access/AccessControlUtils.java: ## @@ -43,24 +44,25 @@ private AccessControlUtils() { /** * Vali

Re: [PR] Controller AccessControl interface accepts Request parameter [pinot]

2024-11-21 Thread via GitHub
shounakmk219 commented on code in PR #14414: URL: https://github.com/apache/pinot/pull/14414#discussion_r1852140764 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java: ## @@ -101,10 +102,16 @@ public class PinotQueryResource {

Re: [PR] Controller AccessControl interface accepts Request parameter [pinot]

2024-11-21 Thread via GitHub
shounakmk219 commented on code in PR #14414: URL: https://github.com/apache/pinot/pull/14414#discussion_r1852061362 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/access/AccessControlUtils.java: ## @@ -43,24 +44,25 @@ private AccessControlUtils() { /**

Re: [PR] Controller AccessControl interface accepts Request parameter [pinot]

2024-11-12 Thread via GitHub
ilamhs commented on PR #14414: URL: https://github.com/apache/pinot/pull/14414#issuecomment-2471227616 The failing Integration Tests seem to be unrelated to the code in the PR above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Controller AccessControl interface accepts Request parameter [pinot]

2024-11-07 Thread via GitHub
codecov-commenter commented on PR #14414: URL: https://github.com/apache/pinot/pull/14414#issuecomment-2463358607 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14414?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Controller AccessControl interface accepts Request parameter [pinot]

2024-11-07 Thread via GitHub
ilamhs commented on PR #14414: URL: https://github.com/apache/pinot/pull/14414#issuecomment-2463292682 @Jackie-Jiang , @mcvsubbu Adding in previous reviewers of the similar draft PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[PR] Controller AccessControl interface accepts Request parameter [pinot]

2024-11-07 Thread via GitHub
ilamhs opened a new pull request, #14414: URL: https://github.com/apache/pinot/pull/14414 ### Labels: * `feature` * `release-notes` (backward compatible, note the deprecation, later on major semver remove the deprecation) ### Context * https://github.com/apache/pinot/issues/1