Re: [PR] Avro version upgrade with primitive array handling. [pinot]

2024-08-27 Thread via GitHub
abhioncbr commented on PR #13823: URL: https://github.com/apache/pinot/pull/13823#issuecomment-2313905201 Sure, closing this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] Avro version upgrade with primitive array handling. [pinot]

2024-08-27 Thread via GitHub
abhioncbr closed pull request #13823: Avro version upgrade with primitive array handling. URL: https://github.com/apache/pinot/pull/13823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Avro version upgrade with primitive array handling. [pinot]

2024-08-27 Thread via GitHub
Jackie-Jiang commented on PR #13823: URL: https://github.com/apache/pinot/pull/13823#issuecomment-2313891980 @abhioncbr Since there are 2 newly introduced major issues, let's hold a little bit on the upgrade. Thanks again for taking the time and find all these details! -- This is an auto

Re: [PR] Avro version upgrade with primitive array handling. [pinot]

2024-08-24 Thread via GitHub
abhioncbr commented on PR #13823: URL: https://github.com/apache/pinot/pull/13823#issuecomment-2308604701 > Thanks for digging into the problem and finding the root cause! I think `PrimitiveArrays` are introduced to reduce memory usage, so I'd prefer to keep that and handle the new types wi

Re: [PR] Avro version upgrade with primitive array handling. [pinot]

2024-08-15 Thread via GitHub
Jackie-Jiang commented on PR #13823: URL: https://github.com/apache/pinot/pull/13823#issuecomment-2292813500 Thanks for digging into the problem and finding the root cause! I think `PrimitiveArrays` are introduced to reduce memory usage, so I'd prefer keeping that and handle the new types