Re: [PR] Avoid re-stringifying strings in JSON_FORMAT function [pinot]

2024-05-16 Thread via GitHub
yashmayya closed pull request #13097: Avoid re-stringifying strings in JSON_FORMAT function URL: https://github.com/apache/pinot/pull/13097 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Avoid re-stringifying strings in JSON_FORMAT function [pinot]

2024-05-10 Thread via GitHub
Jackie-Jiang commented on PR #13097: URL: https://github.com/apache/pinot/pull/13097#issuecomment-2105371520 In the given example, the problem is actually from the recursive call of `data = JSON_FORMAT(data)`. I don't think Pinot allows this (maybe I was wrong). If we configure the ingest

Re: [PR] Avoid re-stringifying strings in JSON_FORMAT function [pinot]

2024-05-07 Thread via GitHub
yashmayya commented on PR #13097: URL: https://github.com/apache/pinot/pull/13097#issuecomment-2099750401 > I'm not sure if this is the correct behavior. JSON_FORMAT should be able to convert any object into JSON. If the value itself is abc, then the proper JSON version should be "abc".

Re: [PR] Avoid re-stringifying strings in JSON_FORMAT function [pinot]

2024-05-07 Thread via GitHub
Jackie-Jiang commented on PR #13097: URL: https://github.com/apache/pinot/pull/13097#issuecomment-2099317059 I don't fully follow the example in the description. If the value is already JSON string, user shouldn't call `JSON_FORMAT` again -- This is an automated message from the Apache Gi

Re: [PR] Avoid re-stringifying strings in JSON_FORMAT function [pinot]

2024-05-07 Thread via GitHub
codecov-commenter commented on PR #13097: URL: https://github.com/apache/pinot/pull/13097#issuecomment-2098192936 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13097?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u