Re: [PR] Adds check if controller tmp dir exists [pinot]

xiangfu0 merged PR #14503: URL: https://github.com/apache/pinot/pull/14503 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

Re: [PR] Adds check if controller tmp dir exists [pinot]

Harnoor7 commented on code in PR #14503: URL: https://github.com/apache/pinot/pull/14503#discussion_r1863124458 ## pinot-common/src/main/java/org/apache/pinot/common/utils/FileUtils.java: ## @@ -134,4 +136,15 @@ public static File concatAndValidateFile(File folderDir, String fi

Re: [PR] Adds check if controller tmp dir exists [pinot]

xiangfu0 commented on code in PR #14503: URL: https://github.com/apache/pinot/pull/14503#discussion_r1862754411 ## pinot-common/src/main/java/org/apache/pinot/common/utils/FileUtils.java: ## @@ -134,4 +136,15 @@ public static File concatAndValidateFile(File folderDir, String fi

Re: [PR] Adds check if controller tmp dir exists [pinot]

Harnoor7 commented on code in PR #14503: URL: https://github.com/apache/pinot/pull/14503#discussion_r1858330562 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/ControllerFilePathProvider.java: ## @@ -126,14 +126,17 @@ public URI getDataDirURI() { }

Re: [PR] Adds check if controller tmp dir exists [pinot]

shounakmk219 commented on code in PR #14503: URL: https://github.com/apache/pinot/pull/14503#discussion_r1858333654 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/ControllerFilePathProvider.java: ## @@ -126,14 +126,17 @@ public URI getDataDirURI() {

Re: [PR] Adds check if controller tmp dir exists [pinot]

shounakmk219 commented on code in PR #14503: URL: https://github.com/apache/pinot/pull/14503#discussion_r1858276325 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/ControllerFilePathProvider.java: ## @@ -126,14 +126,17 @@ public URI getDataDirURI() {

Re: [PR] Adds check if controller tmp dir exists [pinot]

Harnoor7 commented on code in PR #14503: URL: https://github.com/apache/pinot/pull/14503#discussion_r1858233136 ## pinot-controller/src/test/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResourceTest.java: ## @@ -158,7 +175,8 @@ public void test

Re: [PR] Adds check if controller tmp dir exists [pinot]

Harnoor7 commented on PR #14503: URL: https://github.com/apache/pinot/pull/14503#issuecomment-2500263492 > I suppose this error only occurs in tests not production right? We faced this issue on production -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Adds check if controller tmp dir exists [pinot]

Harnoor7 commented on code in PR #14503: URL: https://github.com/apache/pinot/pull/14503#discussion_r1858234529 ## pinot-controller/src/test/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResourceTest.java: ## @@ -249,4 +267,58 @@ public void tes

Re: [PR] Adds check if controller tmp dir exists [pinot]

Harnoor7 commented on code in PR #14503: URL: https://github.com/apache/pinot/pull/14503#discussion_r1858232713 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/ControllerFilePathProvider.java: ## @@ -126,14 +128,38 @@ public URI getDataDirURI() { }

Re: [PR] Adds check if controller tmp dir exists [pinot]

Harnoor7 commented on code in PR #14503: URL: https://github.com/apache/pinot/pull/14503#discussion_r1858232043 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/ControllerFilePathProvider.java: ## @@ -126,14 +128,38 @@ public URI getDataDirURI() { }

Re: [PR] Adds check if controller tmp dir exists [pinot]

Harnoor7 commented on code in PR #14503: URL: https://github.com/apache/pinot/pull/14503#discussion_r1858224111 ## pinot-controller/src/test/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResourceTest.java: ## @@ -56,20 +66,27 @@ public class Pin

Re: [PR] Adds check if controller tmp dir exists [pinot]

codecov-commenter commented on PR #14503: URL: https://github.com/apache/pinot/pull/14503#issuecomment-2499394620 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14503?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Adds check if controller tmp dir exists [pinot]

xiangfu0 commented on PR #14503: URL: https://github.com/apache/pinot/pull/14503#issuecomment-2499346248 I suppose this error only occurs in tests not production right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] Adds check if controller tmp dir exists [pinot]

xiangfu0 commented on code in PR #14503: URL: https://github.com/apache/pinot/pull/14503#discussion_r1857531614 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/ControllerFilePathProvider.java: ## @@ -126,14 +128,38 @@ public URI getDataDirURI() { }

Re: [PR] Adds check if controller tmp dir exists [pinot]

shounakmk219 commented on code in PR #14503: URL: https://github.com/apache/pinot/pull/14503#discussion_r1855876987 ## pinot-controller/src/test/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResourceTest.java: ## @@ -56,20 +66,27 @@ public class