Re: [PR] Add threadLocal reusable byte array for VarByteChunkReaderV4 [pinot]

2024-04-25 Thread via GitHub
wirybeaver commented on PR #12977: URL: https://github.com/apache/pinot/pull/12977#issuecomment-2078591994 > Have you found any issues from these allocations? In our experience w/ V4 we have not seen GC issues even when using lower throughput GC algorithms (ZGC/generational ZGC). > >

Re: [PR] Add threadLocal reusable byte array for VarByteChunkReaderV4 [pinot]

2024-04-22 Thread via GitHub
itschrispeck commented on PR #12977: URL: https://github.com/apache/pinot/pull/12977#issuecomment-2071036509 Have you found any issues from these allocations? In our experience w/ V4 we have not seen GC issues even when using lower throughput GC algorithms (ZGC/generational ZGC). I

Re: [PR] Add threadLocal reusable byte array for VarByteChunkReaderV4 [pinot]

2024-04-20 Thread via GitHub
codecov-commenter commented on PR #12977: URL: https://github.com/apache/pinot/pull/12977#issuecomment-2067812064 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12977?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Add threadLocal reusable byte array for VarByteChunkReaderV4 [pinot]

2024-04-20 Thread via GitHub
wirybeaver opened a new pull request, #12977: URL: https://github.com/apache/pinot/pull/12977 Intuition: Reduce repeated byte array allocation on jvm heap when QPS is high. Is it thread safe? Yes, since the ReaderContext is created per SegmentPlanNode per query. A SegmentPlanNode wou