Re: [PR] Add support for creating raw derived columns during segment reload [pinot]

2024-05-09 Thread via GitHub
yashmayya commented on code in PR #13037: URL: https://github.com/apache/pinot/pull/13037#discussion_r1595772369 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/defaultcolumn/BaseDefaultColumnHandler.java: ## @@ -757,57 +753,157 @@ privat

Re: [PR] Add support for creating raw derived columns during segment reload [pinot]

2024-05-09 Thread via GitHub
Jackie-Jiang commented on code in PR #13037: URL: https://github.com/apache/pinot/pull/13037#discussion_r1595755834 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/defaultcolumn/BaseDefaultColumnHandler.java: ## @@ -757,57 +753,157 @@ pri

Re: [PR] Add support for creating raw derived columns during segment reload [pinot]

2024-05-09 Thread via GitHub
xiangfu0 merged PR #13037: URL: https://github.com/apache/pinot/pull/13037 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

Re: [PR] Add support for creating raw derived columns during segment reload [pinot]

2024-05-07 Thread via GitHub
yashmayya commented on code in PR #13037: URL: https://github.com/apache/pinot/pull/13037#discussion_r1593366648 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/defaultcolumn/BaseDefaultColumnHandler.java: ## @@ -757,57 +753,157 @@ privat

Re: [PR] Add support for creating raw derived columns during segment reload [pinot]

2024-05-07 Thread via GitHub
Jackie-Jiang commented on code in PR #13037: URL: https://github.com/apache/pinot/pull/13037#discussion_r1593104346 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/defaultcolumn/BaseDefaultColumnHandler.java: ## @@ -757,57 +753,157 @@ pri

Re: [PR] Add support for creating raw derived columns during segment reload [pinot]

2024-05-06 Thread via GitHub
yashmayya commented on code in PR #13037: URL: https://github.com/apache/pinot/pull/13037#discussion_r1590974745 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/defaultcolumn/BaseDefaultColumnHandler.java: ## @@ -757,57 +759,181 @@ privat

Re: [PR] Add support for creating raw derived columns during segment reload [pinot]

2024-05-06 Thread via GitHub
yashmayya commented on code in PR #13037: URL: https://github.com/apache/pinot/pull/13037#discussion_r1590974745 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/defaultcolumn/BaseDefaultColumnHandler.java: ## @@ -757,57 +759,181 @@ privat

Re: [PR] Add support for creating raw derived columns during segment reload [pinot]

2024-04-30 Thread via GitHub
codecov-commenter commented on PR #13037: URL: https://github.com/apache/pinot/pull/13037#issuecomment-2086305874 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13037?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Add support for creating raw derived columns during segment reload [pinot]

2024-04-30 Thread via GitHub
yashmayya opened a new pull request, #13037: URL: https://github.com/apache/pinot/pull/13037 - Support for generating derived columns during segment reload was added in https://github.com/apache/pinot/pull/6494. - However, support for generating raw derived columns during segment reload