Re: [PR] Add splitPartWithLimit and splitPartFromEnd UDFs [pinot]

2024-04-18 Thread via GitHub
Jackie-Jiang merged PR #12437: URL: https://github.com/apache/pinot/pull/12437 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Add splitPartWithLimit and splitPartFromEnd UDFs [pinot]

2024-04-15 Thread via GitHub
deemoliu commented on code in PR #12437: URL: https://github.com/apache/pinot/pull/12437#discussion_r1566583241 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java: ## @@ -597,6 +596,39 @@ public static String splitPart(String input, String

Re: [PR] Add splitPartWithLimit and splitPartFromEnd UDFs [pinot]

2024-04-15 Thread via GitHub
deemoliu commented on code in PR #12437: URL: https://github.com/apache/pinot/pull/12437#discussion_r1566582209 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java: ## @@ -597,6 +596,39 @@ public static String splitPart(String input, String

Re: [PR] Add splitPartWithLimit and splitPartFromEnd UDFs [pinot]

2024-04-15 Thread via GitHub
deemoliu commented on code in PR #12437: URL: https://github.com/apache/pinot/pull/12437#discussion_r1566580709 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java: ## @@ -597,6 +596,39 @@ public static String splitPart(String input, String

Re: [PR] Add splitPartWithLimit and splitPartFromEnd UDFs [pinot]

2024-04-15 Thread via GitHub
deemoliu commented on code in PR #12437: URL: https://github.com/apache/pinot/pull/12437#discussion_r1566580853 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java: ## @@ -597,6 +596,39 @@ public static String splitPart(String input, String

Re: [PR] Add splitPartWithLimit and splitPartFromEnd UDFs [pinot]

2024-03-07 Thread via GitHub
Jackie-Jiang commented on code in PR #12437: URL: https://github.com/apache/pinot/pull/12437#discussion_r1516930343 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java: ## @@ -597,6 +596,39 @@ public static String splitPart(String input, St

Re: [PR] Add splitPartWithLimit and splitPartFromEnd UDFs [pinot]

2024-03-06 Thread via GitHub
satishd commented on code in PR #12437: URL: https://github.com/apache/pinot/pull/12437#discussion_r1515463808 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java: ## @@ -597,6 +596,39 @@ public static String splitPart(String input, String

Re: [PR] Add splitPartWithLimit and splitPartFromEnd UDFs [pinot]

2024-03-06 Thread via GitHub
satishd commented on code in PR #12437: URL: https://github.com/apache/pinot/pull/12437#discussion_r1515463808 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java: ## @@ -597,6 +596,39 @@ public static String splitPart(String input, String

Re: [PR] Add splitPartWithLimit and splitPartFromEnd UDFs [pinot]

2024-03-06 Thread via GitHub
deemoliu commented on code in PR #12437: URL: https://github.com/apache/pinot/pull/12437#discussion_r1515187581 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java: ## @@ -597,6 +596,39 @@ public static String splitPart(String input, String

Re: [PR] Add splitPartWithLimit and splitPartFromEnd UDFs [pinot]

2024-03-06 Thread via GitHub
deemoliu commented on code in PR #12437: URL: https://github.com/apache/pinot/pull/12437#discussion_r1515186487 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java: ## @@ -597,6 +596,39 @@ public static String splitPart(String input, String

Re: [PR] Add splitPartWithLimit and splitPartFromEnd UDFs [pinot]

2024-03-06 Thread via GitHub
Jackie-Jiang commented on code in PR #12437: URL: https://github.com/apache/pinot/pull/12437#discussion_r1515059370 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java: ## @@ -597,6 +596,39 @@ public static String splitPart(String input, St

Re: [PR] Add splitPartWithLimit and splitPartFromEnd UDFs [pinot]

2024-03-06 Thread via GitHub
deemoliu commented on PR #12437: URL: https://github.com/apache/pinot/pull/12437#issuecomment-1981544903 > Are there equivalent/similar functions in other commonly used DBs (e.g. PostgreSQL)? We should try to match the behavior Hi @Jackie-Jiang thanks for looking into it. the followin

Re: [PR] Add splitPartWithLimit and splitPartFromEnd UDFs [pinot]

2024-03-06 Thread via GitHub
deemoliu commented on code in PR #12437: URL: https://github.com/apache/pinot/pull/12437#discussion_r1514972783 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java: ## @@ -597,6 +596,39 @@ public static String splitPart(String input, String

Re: [PR] Add splitPartWithLimit and splitPartFromEnd UDFs [pinot]

2024-02-25 Thread via GitHub
satishd commented on code in PR #12437: URL: https://github.com/apache/pinot/pull/12437#discussion_r1501851494 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java: ## @@ -597,6 +596,39 @@ public static String splitPart(String input, String

Re: [PR] Add splitPartWithLimit and splitPartFromEnd UDFs [pinot]

2024-02-24 Thread via GitHub
Jackie-Jiang commented on PR #12437: URL: https://github.com/apache/pinot/pull/12437#issuecomment-1962514847 Are there equivalent/similar functions in other commonly used DBs (e.g. PostgreSQL)? We should try to match the behavior -- This is an automated message from the Apache Git Service

Re: [PR] Add splitPartWithLimit and splitPartFromEnd UDFs [pinot]

2024-02-23 Thread via GitHub
ankitsultana commented on code in PR #12437: URL: https://github.com/apache/pinot/pull/12437#discussion_r1501197064 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java: ## @@ -597,6 +596,41 @@ public static String splitPart(String input, St