snleee merged PR #12350:
URL: https://github.com/apache/pinot/pull/12350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apach
swaminathanmanish commented on code in PR #12350:
URL: https://github.com/apache/pinot/pull/12350#discussion_r1475083432
##
pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/util/SegmentDeletionManagerTest.java:
##
@@ -357,6 +358,9 @@ public void createTableA
snleee commented on code in PR #12350:
URL: https://github.com/apache/pinot/pull/12350#discussion_r1475077573
##
pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/util/SegmentDeletionManagerTest.java:
##
@@ -357,6 +358,9 @@ public void createTableAndSegmentFi
codecov-commenter commented on PR #12350:
URL: https://github.com/apache/pinot/pull/12350#issuecomment-1922068621
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12350?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
swaminathanmanish commented on PR #12350:
URL: https://github.com/apache/pinot/pull/12350#issuecomment-1921999009
@snleee - Could you take a look? Thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
swaminathanmanish opened a new pull request, #12350:
URL: https://github.com/apache/pinot/pull/12350
**Whats in the PR:**
Added segment metadata deletion from remote store, in the segment deletion
path.
**Why its needed:**
Through [PR](https://github.com/apache/pinot/pull/10034)