Re: [PR] Add sample and check to FunnelBaseAggregationFunction [pinot]

2025-03-15 Thread via GitHub
vrajat commented on PR #15251: URL: https://github.com/apache/pinot/pull/15251#issuecomment-2725345721 The test failure ` MultiNodesOfflineClusterIntegrationTest>O` seems like a flaky test -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Add sample and check to FunnelBaseAggregationFunction [pinot]

2025-03-14 Thread via GitHub
xiangfu0 merged PR #15251: URL: https://github.com/apache/pinot/pull/15251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

Re: [PR] Add sample and check to FunnelBaseAggregationFunction [pinot]

2025-03-13 Thread via GitHub
vrajat commented on PR #15251: URL: https://github.com/apache/pinot/pull/15251#issuecomment-2723492069 For some reason, this function is not being triggered by my changes in `TimestampIndexMseTest` ``` protected void overrideBrokerConf(PinotConfiguration brokerConf) { Stri

Re: [PR] Add sample and check to FunnelBaseAggregationFunction [pinot]

2025-03-13 Thread via GitHub
vrajat commented on PR #15251: URL: https://github.com/apache/pinot/pull/15251#issuecomment-2723348775 Once again the individual test passes on my laptop. Investigating -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] Add sample and check to FunnelBaseAggregationFunction [pinot]

2025-03-13 Thread via GitHub
vrajat commented on PR #15251: URL: https://github.com/apache/pinot/pull/15251#issuecomment-2722971180 Now it's passed the window test. It's in TimestampMSE related test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Add sample and check to FunnelBaseAggregationFunction [pinot]

2025-03-13 Thread via GitHub
vrajat commented on PR #15251: URL: https://github.com/apache/pinot/pull/15251#issuecomment-2721957329 Oh - I think I know why. Since it is part of suite, the cluster was setup before the config was setup. -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] Add sample and check to FunnelBaseAggregationFunction [pinot]

2025-03-13 Thread via GitHub
vrajat commented on PR #15251: URL: https://github.com/apache/pinot/pull/15251#issuecomment-2721672985 I changed the test to not use casts. However it is still failing with different error. Something about the test env in the github runners and my laptop is different. It is not creating the

Re: [PR] Add sample and check to FunnelBaseAggregationFunction [pinot]

2025-03-13 Thread via GitHub
vrajat commented on PR #15251: URL: https://github.com/apache/pinot/pull/15251#issuecomment-2720673707 Confused. Passed with mvn on my laptop as well. ``` mvn test -Dsurefire.failIfNoSpecifiedTests=false -Dtest="WindowResourceAccountingTest" 15:32:02.386 WARN [CustomDat

Re: [PR] Add sample and check to FunnelBaseAggregationFunction [pinot]

2025-03-13 Thread via GitHub
vrajat commented on PR #15251: URL: https://github.com/apache/pinot/pull/15251#issuecomment-2720629715 > can you fix the integration test? > > ``` > WindowResourceAccountingTest.testFunnel:72 ClassCast class org.apache.pinot.spi.trace.Tracing$DefaultThreadResourceUsageAccountant c

Re: [PR] Add sample and check to FunnelBaseAggregationFunction [pinot]

2025-03-13 Thread via GitHub
xiangfu0 commented on PR #15251: URL: https://github.com/apache/pinot/pull/15251#issuecomment-2720564010 can you fix the integration test? ``` WindowResourceAccountingTest.testFunnel:72 ClassCast class org.apache.pinot.spi.trace.Tracing$DefaultThreadResourceUsageAccountant cannot be

[PR] Add sample and check to FunnelBaseAggregationFunction [pinot]

2025-03-12 Thread via GitHub
vrajat opened a new pull request, #15251: URL: https://github.com/apache/pinot/pull/15251 Instructions: 1. The PR has to be tagged with at least one of the following labels (*): 1. `feature` 2. `bugfix` 3. `performance` 4. `ui` 5. `backward-incompat` 6.

Re: [PR] Add sample and check to FunnelBaseAggregationFunction [pinot]

2025-03-12 Thread via GitHub
codecov-commenter commented on PR #15251: URL: https://github.com/apache/pinot/pull/15251#issuecomment-2717382940 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15251?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u