Re: [PR] Add null checks when sampling thread resource usage. [pinot]

2025-02-17 Thread via GitHub
yashmayya merged PR #15069: URL: https://github.com/apache/pinot/pull/15069 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

Re: [PR] Add null checks when sampling thread resource usage. [pinot]

2025-02-17 Thread via GitHub
vrajat commented on PR #15069: URL: https://github.com/apache/pinot/pull/15069#issuecomment-2664581670 Failure is not related to the diff. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Add null checks when sampling thread resource usage. [pinot]

2025-02-15 Thread via GitHub
codecov-commenter commented on PR #15069: URL: https://github.com/apache/pinot/pull/15069#issuecomment-2660870732 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15069?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Add null checks when sampling thread resource usage. [pinot]

2025-02-15 Thread via GitHub
vrajat commented on code in PR #15069: URL: https://github.com/apache/pinot/pull/15069#discussion_r1957085491 ## pinot-core/src/main/java/org/apache/pinot/core/accounting/PerQueryCPUMemAccountantFactory.java: ## @@ -278,8 +278,9 @@ public void updateQueryUsageConcurrently(String

Re: [PR] Add null checks when sampling thread resource usage. [pinot]

2025-02-15 Thread via GitHub
vrajat commented on code in PR #15069: URL: https://github.com/apache/pinot/pull/15069#discussion_r1957085311 ## pinot-core/src/main/java/org/apache/pinot/core/accounting/PerQueryCPUMemAccountantFactory.java: ## @@ -278,8 +278,9 @@ public void updateQueryUsageConcurrently(String

Re: [PR] Add null checks when sampling thread resource usage. [pinot]

2025-02-15 Thread via GitHub
yashmayya commented on code in PR #15069: URL: https://github.com/apache/pinot/pull/15069#discussion_r1957084417 ## pinot-core/src/main/java/org/apache/pinot/core/accounting/PerQueryCPUMemAccountantFactory.java: ## @@ -278,8 +278,9 @@ public void updateQueryUsageConcurrently(Str

[PR] Add null checks when sampling thread resource usage. [pinot]

2025-02-15 Thread via GitHub
vrajat opened a new pull request, #15069: URL: https://github.com/apache/pinot/pull/15069 Issues like https://github.com/apache/pinot/issues/15045 are caused because some query execution paths are not instrumented to capture thread usage. When instrumentation is turned on NPE is caused. Sin