Re: [PR] Add nonLeaderCleanUp with tables parameters in PinotTaskGenerator [pinot]

2024-07-09 Thread via GitHub
jackjlli merged PR #13509: URL: https://github.com/apache/pinot/pull/13509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

Re: [PR] Add nonLeaderCleanUp with tables parameters in PinotTaskGenerator [pinot]

2024-07-08 Thread via GitHub
jackjlli commented on code in PR #13509: URL: https://github.com/apache/pinot/pull/13509#discussion_r1668992756 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java: ## @@ -702,6 +702,14 @@ public void cleanUpTask() { } }

Re: [PR] Add nonLeaderCleanUp with tables parameters in PinotTaskGenerator [pinot]

2024-07-02 Thread via GitHub
Jackie-Jiang commented on code in PR #13509: URL: https://github.com/apache/pinot/pull/13509#discussion_r166198 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java: ## @@ -702,6 +702,14 @@ public void cleanUpTask() { }

[PR] Add nonLeaderCleanUp with tables parameters in PinotTaskGenerator [pinot]

2024-07-02 Thread via GitHub
jackjlli opened a new pull request, #13509: URL: https://github.com/apache/pinot/pull/13509 This PR adds the nonLeaderCleanUp method with the list of table names as the parameter in the PinotTaskGenerator interface. When the tasks are scheduled, the current controller may not always b