siddharthteotia merged PR #11942:
URL: https://github.com/apache/pinot/pull/11942
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pi
SabrinaZhaozyf commented on PR #11942:
URL: https://github.com/apache/pinot/pull/11942#issuecomment-1804276003
> Could you take a look at the tests? They are failing and the log size
looks pretty large, Maybe set the log level to info in the new tests?
The failed tests were due to a flaky
SabrinaZhaozyf commented on code in PR #11942:
URL: https://github.com/apache/pinot/pull/11942#discussion_r1385693119
##
pinot-core/src/test/java/org/apache/pinot/core/accounting/ResourceManagerAccountingTest.java:
##
@@ -223,6 +238,145 @@ public void testWorkerThreadInterruptio
SabrinaZhaozyf commented on code in PR #11942:
URL: https://github.com/apache/pinot/pull/11942#discussion_r1385691506
##
pinot-core/src/main/java/org/apache/pinot/core/query/scheduler/QueryScheduler.java:
##
@@ -215,6 +219,14 @@ private byte[] serializeResponse(ServerQueryReques
jasperjiaguo commented on code in PR #11942:
URL: https://github.com/apache/pinot/pull/11942#discussion_r1382289868
##
pinot-core/src/test/java/org/apache/pinot/core/accounting/ResourceManagerAccountingTest.java:
##
@@ -223,6 +238,145 @@ public void testWorkerThreadInterruption(
jasperjiaguo commented on code in PR #11942:
URL: https://github.com/apache/pinot/pull/11942#discussion_r1382267013
##
pinot-core/src/main/java/org/apache/pinot/core/query/scheduler/QueryScheduler.java:
##
@@ -215,6 +219,14 @@ private byte[] serializeResponse(ServerQueryRequest
jasperjiaguo commented on code in PR #11942:
URL: https://github.com/apache/pinot/pull/11942#discussion_r1382267013
##
pinot-core/src/main/java/org/apache/pinot/core/query/scheduler/QueryScheduler.java:
##
@@ -215,6 +219,14 @@ private byte[] serializeResponse(ServerQueryRequest
codecov-commenter commented on PR #11942:
URL: https://github.com/apache/pinot/pull/11942#issuecomment-1791758562
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11942?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
SabrinaZhaozyf opened a new pull request, #11942:
URL: https://github.com/apache/pinot/pull/11942
When the InstanceResponseBlock is creating the DataTable based on the final
results in the combine operator, that data table creation is hitting OOM (see
examples below). This PR adds instrumen
