walterddr merged PR #12151:
URL: https://github.com/apache/pinot/pull/12151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.ap
vrajat commented on code in PR #12151:
URL: https://github.com/apache/pinot/pull/12151#discussion_r1432299319
##
pinot-core/src/test/java/org/apache/pinot/queries/JsonMalformedIndexTest.java:
##
@@ -0,0 +1,139 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under on
Jackie-Jiang commented on code in PR #12151:
URL: https://github.com/apache/pinot/pull/12151#discussion_r1432040654
##
pinot-core/src/test/java/org/apache/pinot/queries/JsonMalformedIndexTest.java:
##
@@ -0,0 +1,139 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) un
vrajat commented on PR #12151:
URL: https://github.com/apache/pinot/pull/12151#issuecomment-1862440379
Ran a manual test and was able to repro the error as well get the modified
error message.
I used this diff and ran `JsonIndexQuickStart`:
```
diff --git
a/pinot-tools/src/
vrajat commented on PR #12151:
URL: https://github.com/apache/pinot/pull/12151#issuecomment-1861065440
I'll do the manual test.
re: integration test, the current test builds a segment for real. I copied
the idea from another test that tests segment build. So hopefully this test is
en
ege-st commented on PR #12151:
URL: https://github.com/apache/pinot/pull/12151#issuecomment-1860961248
> > By the way, besides unit tests, were you able to do a manual test and
see what happens when Pinot is running and this error happens?
>
> No I did not. Do I have to implement an i
vrajat commented on PR #12151:
URL: https://github.com/apache/pinot/pull/12151#issuecomment-1860951021
> By the way, besides unit tests, were you able to do a manual test and see
what happens when Pinot is running and this error happens?
No I did not. Do I have to implement an integra
ege-st commented on PR #12151:
URL: https://github.com/apache/pinot/pull/12151#issuecomment-1860774295
By the way, besides unit tests, were you able to do a manual test and see
what happens when Pinot is running and this error happens?
--
This is an automated message from the Apache Git S
vrajat commented on code in PR #12151:
URL: https://github.com/apache/pinot/pull/12151#discussion_r1429450578
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/ColumnJsonParserException.java:
##
@@ -0,0 +1,55 @@
+/**
+ * Licensed to the Apa
ege-st commented on code in PR #12151:
URL: https://github.com/apache/pinot/pull/12151#discussion_r1428227636
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java:
##
@@ -315,11 +316,14 @@ public void indexRow(
codecov-commenter commented on PR #12151:
URL: https://github.com/apache/pinot/pull/12151#issuecomment-1857756476
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12151?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
vrajat commented on code in PR #12151:
URL: https://github.com/apache/pinot/pull/12151#discussion_r1427520654
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/ColumnJsonParserException.java:
##
@@ -0,0 +1,59 @@
+/**
+ * Licensed to the Apa
vrajat commented on code in PR #12151:
URL: https://github.com/apache/pinot/pull/12151#discussion_r1427519144
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java:
##
@@ -315,11 +316,14 @@ public void indexRow(
swaminathanmanish commented on code in PR #12151:
URL: https://github.com/apache/pinot/pull/12151#discussion_r1427440402
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java:
##
@@ -315,11 +316,14 @@ public voi
swaminathanmanish commented on code in PR #12151:
URL: https://github.com/apache/pinot/pull/12151#discussion_r1427440402
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java:
##
@@ -315,11 +316,14 @@ public voi
swaminathanmanish commented on code in PR #12151:
URL: https://github.com/apache/pinot/pull/12151#discussion_r1427436376
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java:
##
@@ -315,11 +316,14 @@ public voi
vrajat opened a new pull request, #12151:
URL: https://github.com/apache/pinot/pull/12151
JSON Index build may fail due to errors in JSON content. When there are
multiple JSON indices or when the schema is not immediately available, the
column for which index build broke is not clear.
17 matches
Mail list logo
