[GitHub] [pinot] richardstartin commented on pull request #8818: regexp_like fusing

2022-06-13 Thread GitBox
richardstartin commented on PR #8818: URL: https://github.com/apache/pinot/pull/8818#issuecomment-1154392815 Just circling back here having taken a quick look at `BenchmarkFuseRegexp.decreasing9Fusing` - I got similar results to Gonzalo: ``` Benchmark (

[GitHub] [pinot] richardstartin commented on pull request #8818: regexp_like fusing

2022-06-13 Thread GitBox
richardstartin commented on PR #8818: URL: https://github.com/apache/pinot/pull/8818#issuecomment-1154343989 > > > > > Thanks @atris for taking a look. I also have a question around how Lucene and native FST handle the query, specifically for these results: > > > > > ``` > > > > > SELE

[GitHub] [pinot] richardstartin commented on pull request #8818: regexp_like fusing

2022-06-13 Thread GitBox
richardstartin commented on PR #8818: URL: https://github.com/apache/pinot/pull/8818#issuecomment-1154336975 > > > Thanks @atris for taking a look. I also have a question around how Lucene and native FST handle the query, specifically for these results: > > > ``` > > > SELECT INT_COL F

[GitHub] [pinot] richardstartin commented on pull request #8818: regexp_like fusing

2022-06-13 Thread GitBox
richardstartin commented on PR #8818: URL: https://github.com/apache/pinot/pull/8818#issuecomment-1154277210 > Thanks @atris for taking a look. I also have a question around how Lucene and native FST handle the query, specifically for these results: > > ``` > SELECT INT_COL FROM My

[GitHub] [pinot] richardstartin commented on pull request #8818: regexp_like fusing

2022-06-03 Thread GitBox
richardstartin commented on PR #8818: URL: https://github.com/apache/pinot/pull/8818#issuecomment-1145814759 I don’t believe the native FST supports backreferences, and I don’t think it would be easy to add support either. Not sure about the lucene FST index. As mentioned above, LIKE statem