Re: [PR] Cache configs for logical table context in server [pinot]

2025-06-01 Thread via GitHub
codecov-commenter commented on PR #15881: URL: https://github.com/apache/pinot/pull/15881#issuecomment-2929108732 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15881?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Cache configs for logical table context in server [pinot]

2025-06-01 Thread via GitHub
abhishekbafna commented on PR #15881: URL: https://github.com/apache/pinot/pull/15881#issuecomment-2929002409 > Testing: > Started a local pinot setup in debug mode and inspected the logical table cache objects in `HelixInstanceDataManager` being updated with add logical table, update sc

Re: [PR] Modify OFFLINE and REALTIME completed segments to calculate default partitionId based on same logic as consuming segments rather than 0 [pinot]

2025-06-01 Thread via GitHub
yashmayya commented on code in PR #15817: URL: https://github.com/apache/pinot/pull/15817#discussion_r2120150368 ## pinot-common/src/main/java/org/apache/pinot/common/utils/SegmentUtils.java: ## @@ -33,38 +34,42 @@ public class SegmentUtils { private SegmentUtils() { } -

Re: [PR] Cache configs for logical table context in server [pinot]

2025-06-01 Thread via GitHub
abhishekbafna commented on code in PR #15881: URL: https://github.com/apache/pinot/pull/15881#discussion_r2120154611 ## pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java: ## @@ -84,6 +91,22 @@ public class HelixInstanceDataManager imp

Re: [PR] Introducing integration tests for time series engine [pinot]

2025-06-01 Thread via GitHub
codecov-commenter commented on PR #15960: URL: https://github.com/apache/pinot/pull/15960#issuecomment-2928929686 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15960?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] MSE error management improvements [pinot]

2025-06-01 Thread via GitHub
yashmayya commented on code in PR #15919: URL: https://github.com/apache/pinot/pull/15919#discussion_r2120111385 ## pinot-common/src/main/java/org/apache/pinot/common/datablock/ZeroCopyDataBlockSerde.java: ## @@ -114,11 +118,36 @@ private void serializeExceptions(DataBlock dataB

Re: [PR] MSE error management improvements [pinot]

2025-06-01 Thread via GitHub
Jackie-Jiang commented on code in PR #15919: URL: https://github.com/apache/pinot/pull/15919#discussion_r2116509753 ## pinot-common/src/main/java/org/apache/pinot/common/datablock/ZeroCopyDataBlockSerde.java: ## @@ -114,11 +118,36 @@ private void serializeExceptions(DataBlock da

[PR] Introducing integration tests for time series engine [pinot]

2025-06-01 Thread via GitHub
shauryachats opened a new pull request, #15960: URL: https://github.com/apache/pinot/pull/15960 This change introduces the initial integration tests for the Pinot Timeseries Query Engine. Key Changes - **New Tests**: Added `TimeSeriesIntegrationTest` to validate timeseries ag

Re: [PR] Bump org.mockito:mockito-bom from 5.17.0 to 5.18.0 [pinot]

2025-06-01 Thread via GitHub
yashmayya commented on PR #15949: URL: https://github.com/apache/pinot/pull/15949#issuecomment-2928722841 Looks like the Maven shade plugin goal is failing due to the ByteBuddy version upgrade introducing support for Java 25 (https://github.com/mockito/mockito/issues/3647) - ```

(pinot) branch dependabot/maven/org.glassfish.jersey-jersey-bom-3.1.10 deleted (was 1490c87119)

2025-06-01 Thread yashmayya
This is an automated email from the ASF dual-hosted git repository. yashmayya pushed a change to branch dependabot/maven/org.glassfish.jersey-jersey-bom-3.1.10 in repository https://gitbox.apache.org/repos/asf/pinot.git was 1490c87119 Change version to 2.46 The revisions that were on this

(pinot) branch master updated (1abc8f25a2 -> ff68c1f9a7)

2025-06-01 Thread yashmayya
This is an automated email from the ASF dual-hosted git repository. yashmayya pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 1abc8f25a2 Add Pre-check for downtime and minAvailableReplica for Pauseless Tables (#15953) add ff68c1f9a7 Bum

Re: [PR] Bump org.glassfish.jersey:jersey-bom from 2.45 to 2.46 [pinot]

2025-06-01 Thread via GitHub
yashmayya merged PR #15947: URL: https://github.com/apache/pinot/pull/15947 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap