Re: [I] roundDecimal() fails for null FLOAT values [pinot]

2025-03-22 Thread via GitHub
mghildiy commented on issue #15255: URL: https://github.com/apache/pinot/issues/15255#issuecomment-2746047320 So I was able to insert values, with this csv content: ``` floatfield 1.43 , ``` Query 'SELECT roundDecimal(floatfield, 1) FROM testnullfloat' errors out:

Re: [PR] [DRAFT] Add `gridDisk` H3 Function [pinot]

2025-03-22 Thread via GitHub
codecov-commenter commented on PR #15349: URL: https://github.com/apache/pinot/pull/15349#issuecomment-2745937801 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15349?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] [DRAFT] Add `gridDisk` H3 Function [pinot]

2025-03-22 Thread via GitHub
ashishjayamohan opened a new pull request, #15349: URL: https://github.com/apache/pinot/pull/15349 - Addresses: https://github.com/apache/pinot/issues/14703 - Adds `gridDisk` function from H3 (https://h3geo.org/docs/api/traversal/#griddisk) - Adds relevant tests for `gridDisk` -- Th

(pinot) branch master updated (6bbd5ddf86 -> 23e06e3f4f)

2025-03-22 Thread mayanks
This is an automated email from the ASF dual-hosted git repository. mayanks pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 6bbd5ddf86 Bump com.mycila:license-maven-plugin from 4.6 to 5.0.0 (#15329) add 23e06e3f4f feat(KafkaConfluentSch

Re: [PR] feat(KafkaConfluentSchemaRegistryJsonMessageDecoder): added the JSON confluent schema decoder [pinot]

2025-03-22 Thread via GitHub
mayankshriv merged PR #15273: URL: https://github.com/apache/pinot/pull/15273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.

Re: [I] roundDecimal() fails for null FLOAT values [pinot]

2025-03-22 Thread via GitHub
mghildiy commented on issue #15255: URL: https://github.com/apache/pinot/issues/15255#issuecomment-2745325800 My schema is: ``` { "schemaName": "my-test-schema", "enableColumnBasedNullHandling": true, "dimensionFieldSpecs": [ { "name": "field",

[PR] Support size based threshold for pauseless consumption [pinot]

2025-03-22 Thread via GitHub
Jackie-Jiang opened a new pull request, #15347: URL: https://github.com/apache/pinot/pull/15347 Break `FlushThresholdUpdater` into 2 steps: 1. Update the stats with committing segment when segment is fully committed 2. Get threshold for the new consuming segment This way pauseles

Re: [PR] Enforce schema for all tables [pinot]

2025-03-22 Thread via GitHub
jadami10 commented on PR #15333: URL: https://github.com/apache/pinot/pull/15333#issuecomment-2745314904 Found it in our logs. Looks like folks should be looking for: ``` Found 0 tables misconfigured, 0 tables without schema. Successfully fixed schema for 0 tables, failed to fix 0 tabl

Re: [I] roundDecimal() fails for null FLOAT values [pinot]

2025-03-22 Thread via GitHub
mghildiy commented on issue #15255: URL: https://github.com/apache/pinot/issues/15255#issuecomment-2745278947 What would be steps to reproduce it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] switch log.debug to log.info on query request [pinot]

2025-03-22 Thread via GitHub
albertobastos commented on PR #15264: URL: https://github.com/apache/pinot/pull/15264#issuecomment-2745198616 > We need to apply the same throttling as the `QueryLogger` does. This change can flood the log for super high QPS use cases (imagine over 10k query lines per second) I get t

Re: [PR] Support size based threshold for pauseless consumption [pinot]

2025-03-22 Thread via GitHub
9aman commented on code in PR #15347: URL: https://github.com/apache/pinot/pull/15347#discussion_r2008747041 ## pinot-common/src/main/java/org/apache/pinot/common/metadata/segment/SegmentZKMetadata.java: ## @@ -309,6 +309,7 @@ public void setSizeThresholdToFlushSegment(int flus

Re: [PR] Support size based threshold for pauseless consumption [pinot]

2025-03-22 Thread via GitHub
9aman commented on code in PR #15347: URL: https://github.com/apache/pinot/pull/15347#discussion_r2008746634 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/IngestionConfigUtils.java: ## @@ -101,11 +101,38 @@ public static List> getStreamConfigMaps(TableConfig tableCon

Re: [PR] Support size based threshold for pauseless consumption [pinot]

2025-03-22 Thread via GitHub
9aman commented on code in PR #15347: URL: https://github.com/apache/pinot/pull/15347#discussion_r2008746390 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/IngestionConfigUtils.java: ## @@ -101,11 +101,38 @@ public static List> getStreamConfigMaps(TableConfig tableCon

Re: [PR] Support size based threshold for pauseless consumption [pinot]

2025-03-22 Thread via GitHub
9aman commented on code in PR #15347: URL: https://github.com/apache/pinot/pull/15347#discussion_r2008746551 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/IngestionConfigUtils.java: ## @@ -101,11 +101,38 @@ public static List> getStreamConfigMaps(TableConfig tableCon

Re: [PR] Support size based threshold for pauseless consumption [pinot]

2025-03-22 Thread via GitHub
9aman commented on code in PR #15347: URL: https://github.com/apache/pinot/pull/15347#discussion_r2008746052 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/IngestionConfigUtils.java: ## @@ -101,11 +101,38 @@ public static List> getStreamConfigMaps(TableConfig tableCon

Re: [PR] Fix up parsing of controller timers tableRebalanceExecutionTimeMs and cronSchedulerJobExecutionTimeMs [pinot]

2025-03-22 Thread via GitHub
suddendust commented on code in PR #15330: URL: https://github.com/apache/pinot/pull/15330#discussion_r2006064689 ## docker/images/pinot/etc/jmx_prometheus_javaagent/configs/controller.yml: ## @@ -48,6 +48,21 @@ rules: table: "$2$4" tableType: "$5" taskType: "$6"

(pinot) branch dependabot/maven/kotlin.stdlib.version-2.1.20 created (now dd1aaccc05)

2025-03-22 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/kotlin.stdlib.version-2.1.20 in repository https://gitbox.apache.org/repos/asf/pinot.git at dd1aaccc05 Bump kotlin.stdlib.version from 2.0.21 to 2.1.20 No new revisio

Re: [PR] Support size based threshold for pauseless consumption [pinot]

2025-03-22 Thread via GitHub
9aman commented on code in PR #15347: URL: https://github.com/apache/pinot/pull/15347#discussion_r2008744124 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -456,10 +453,9 @@ private boolean addSegmentT

Re: [PR] Support size based threshold for pauseless consumption [pinot]

2025-03-22 Thread via GitHub
9aman commented on code in PR #15347: URL: https://github.com/apache/pinot/pull/15347#discussion_r2008744211 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -493,10 +489,9 @@ private boolean removeSegm

Re: [PR] Support size based threshold for pauseless consumption [pinot]

2025-03-22 Thread via GitHub
9aman commented on code in PR #15347: URL: https://github.com/apache/pinot/pull/15347#discussion_r2008743899 ## pinot-common/src/main/java/org/apache/pinot/common/metadata/segment/SegmentZKMetadata.java: ## @@ -309,6 +309,7 @@ public void setSizeThresholdToFlushSegment(int flus

Re: [PR] Add `GridDistance` H3 Function [pinot]

2025-03-22 Thread via GitHub
ashishjayamohan commented on PR #15259: URL: https://github.com/apache/pinot/pull/15259#issuecomment-2745146922 Yep, just opened a PR here: https://github.com/pinot-contrib/pinot-docs/pull/419 -- This is an automated message from the Apache Git Service. To respond to the message, please l