Re: [I] Consuming Segments going into BAD State after forceCommit when dedup is enabled since version 1.3.0 [pinot]

2025-03-02 Thread via GitHub
ShivamS136 commented on issue #15162: URL: https://github.com/apache/pinot/issues/15162#issuecomment-2693297310 **Observation:** If I remove the property `metadataTTL` from table's dedup config then the segments don't go into BAD state. PS: By default the property becomes `0`.

Re: [PR] Refactor query error handling to use QueryErrorCode and QueryErrorMessage for improved clarity and consistency [pinot]

2025-03-02 Thread via GitHub
yashmayya commented on PR #15037: URL: https://github.com/apache/pinot/pull/15037#issuecomment-2693283060 @gortiz I didn't follow why we reintroduced the truncated stack traces in the error data blocks here? Are you planning to remove it in a follow-up PR instead? Any reason we couldn't hav

Re: [PR] Refactor query error handling to use QueryErrorCode and QueryErrorMessage for improved clarity and consistency [pinot]

2025-03-02 Thread via GitHub
vrajat commented on PR #15037: URL: https://github.com/apache/pinot/pull/15037#issuecomment-2693282495 I'll take a look at this PR today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Logical poc [pinot]

2025-03-02 Thread via GitHub
vrajat commented on PR #15151: URL: https://github.com/apache/pinot/pull/15151#issuecomment-2693277307 This is a draft PR to discuss the general direction of implementing the feature. It implements a working hack. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Logical poc [pinot]

2025-03-02 Thread via GitHub
vrajat commented on PR #15151: URL: https://github.com/apache/pinot/pull/15151#issuecomment-2693276514 This is the issue: https://github.com/apache/pinot/issues/10712 We have a slack channel as well. https://apache-pinot.slack.com/archives/C07TESEPS4A -- This is an automated me

Re: [I] Add support for Logical Tables [pinot]

2025-03-02 Thread via GitHub
vrajat commented on issue #10712: URL: https://github.com/apache/pinot/issues/10712#issuecomment-2693275060 An update. This is the design doc I am implementing. The doc is based on a discussion b/w @Jackie-Jiang @xiangfu0 @egalpin https://docs.google.com/document/d/1iS0wtG_V2-W9sQsK

Re: [PR] Refactor query error handling to use QueryErrorCode and QueryErrorMessage for improved clarity and consistency [pinot]

2025-03-02 Thread via GitHub
yashmayya commented on code in PR #15037: URL: https://github.com/apache/pinot/pull/15037#discussion_r1976865755 ## pinot-common/src/main/java/org/apache/pinot/common/response/broker/BrokerResponseNative.java: ## @@ -59,16 +59,16 @@ public class BrokerResponseNative implements

Re: [PR] Refactor query error handling to use QueryErrorCode and QueryErrorMessage for improved clarity and consistency [pinot]

2025-03-02 Thread via GitHub
yashmayya commented on code in PR #15037: URL: https://github.com/apache/pinot/pull/15037#discussion_r1976865096 ## pinot-common/src/main/java/org/apache/pinot/common/datablock/DataBlock.java: ## @@ -41,10 +42,15 @@ public interface DataBlock { int getNumberOfColumns(); +

Re: [PR] Add assertions to QueryRoutingTest [pinot]

2025-03-02 Thread via GitHub
codecov-commenter commented on PR #15165: URL: https://github.com/apache/pinot/pull/15165#issuecomment-2692934433 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15165?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Add assertions to QueryRoutingTest [pinot]

2025-03-02 Thread via GitHub
sullis opened a new pull request, #15165: URL: https://github.com/apache/pinot/pull/15165 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [PR] netty 4.2.0 rc3 [pinot]

2025-03-02 Thread via GitHub
codecov-commenter commented on PR #15164: URL: https://github.com/apache/pinot/pull/15164#issuecomment-2692808525 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15164?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] netty 4.2.0 Alpha2 [pinot]

2025-03-02 Thread via GitHub
sullis commented on PR #13552: URL: https://github.com/apache/pinot/pull/13552#issuecomment-2692790966 Obsolete. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[PR] netty 4.2.0 rc3 [pinot]

2025-03-02 Thread via GitHub
sullis opened a new pull request, #15164: URL: https://github.com/apache/pinot/pull/15164 Draft https://netty.io/news/2025/02/11/4-2-0-RC3.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] netty 4.2.0 Alpha2 [pinot]

2025-03-02 Thread via GitHub
sullis closed pull request #13552: netty 4.2.0 Alpha2 URL: https://github.com/apache/pinot/pull/13552 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: co

Re: [PR] fix(ui): query settings are not passing correctly when running via cmd+enter [pinot]

2025-03-02 Thread via GitHub
codecov-commenter commented on PR #15161: URL: https://github.com/apache/pinot/pull/15161#issuecomment-2692761743 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15161?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[I] Inconsistent Deduplication Behavior Between v1.2.0 and v1.3.0 [pinot]

2025-03-02 Thread via GitHub
ShivamS136 opened a new issue, #15163: URL: https://github.com/apache/pinot/issues/15163 ## Issue Description There appears to be a significant difference in deduplication behavior between Pinot v1.2.0 and v1.3.0. The behavior change affects how records are deduplicated based on the

[I] Consuming Segments going into BAD State after forceCommit when dedup is enabled since version 1.3.0 [pinot]

2025-03-02 Thread via GitHub
ShivamS136 opened a new issue, #15162: URL: https://github.com/apache/pinot/issues/15162 ## Bug Description There appears to be a critical bug in Pinot v1.3.0 related to deduplication functionality when using `forceCommit` with dedup enabled. The consuming segments enter ERROR state

[PR] fix(ui): query settings are not passing correctly when running via cmd+enter [pinot]

2025-03-02 Thread via GitHub
jayeshchoudhary opened a new pull request, #15161: URL: https://github.com/apache/pinot/pull/15161 … Instructions: 1. The PR has to be tagged with at least one of the following labels (*): 1. `feature` 2. `bugfix` 3. `performance` 4. `ui` 5. `backward-i

Re: [PR] Refactor murmur functions and support them in scalar functions for query [pinot]

2025-03-02 Thread via GitHub
codecov-commenter commented on PR #15160: URL: https://github.com/apache/pinot/pull/15160#issuecomment-2692693326 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15160?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Upgrade pulsar to 3.3.5 [pinot]

2025-03-02 Thread via GitHub
Jackie-Jiang closed pull request #15156: Upgrade pulsar to 3.3.5 URL: https://github.com/apache/pinot/pull/15156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [I] [Parent Issue] Improve observability for multi-stage query engine [pinot]

2025-03-02 Thread via GitHub
hpvd commented on issue #15137: URL: https://github.com/apache/pinot/issues/15137#issuecomment-2692646631 just as a hint to further optimize usability of parent issues: now there is an automatic for checking tasks in a task list if linked issue/pull is closed: so we can - have an o