Re: [PR] Use multiple threads to merge distinct_count result on server [pinot]

2025-02-23 Thread via GitHub
codecov-commenter commented on PR #15111: URL: https://github.com/apache/pinot/pull/15111#issuecomment-2677428599 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15111?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Decouple tracking and storage in MinionEventObserver using MinionTaskObserverStorageManager [pinot]

2025-02-23 Thread via GitHub
swaminathanmanish merged PR #15044: URL: https://github.com/apache/pinot/pull/15044 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@

Re: [PR] [bugfix] Enable force overwrite for partial upserts [pinot]

2025-02-23 Thread via GitHub
himanish-star commented on PR #15107: URL: https://github.com/apache/pinot/pull/15107#issuecomment-2677403945 > Pls update the documentation also with this. Yes, I'll add documentation mentioning the new config value to be set -- This is an automated message from the Apache Git Serv

Re: [PR] [bugfix] Enable force overwrite for partial upserts [pinot]

2025-02-23 Thread via GitHub
himanish-star commented on PR #15107: URL: https://github.com/apache/pinot/pull/15107#issuecomment-2677403662 > Hey @himanish-star the solution looks good to me! Can you please add unit-test / integration-test for your change too? Sure, I'll add today -- This is an automated messag

(pinot) branch master updated (9ca8a870da -> 49f0ebae53)

2025-02-23 Thread manishswaminathan
This is an automated email from the ASF dual-hosted git repository. manishswaminathan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 9ca8a870da Bump com.diffplug.spotless:spotless-maven-plugin from 2.44.2 to 2.44.3 (#15106) add 49f0eba

[PR] Use multiple threads to merge distinct_count result on server [pinot]

2025-02-23 Thread via GitHub
Jackie-Jiang opened a new pull request, #15111: URL: https://github.com/apache/pinot/pull/15111 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [bugfix] Enable force overwrite for partial upserts [pinot]

2025-02-23 Thread via GitHub
tibrewalpratik17 commented on PR #15107: URL: https://github.com/apache/pinot/pull/15107#issuecomment-2676991639 Hey @himanish-star the solution looks good to me! Can you please add unit-test / integration-test for your change too? -- This is an automated message from the Apache Git Servi

Re: [I] Null handing issue with Partial upserts and partialUpsertStrategies [pinot]

2025-02-23 Thread via GitHub
raghukn commented on issue #14924: URL: https://github.com/apache/pinot/issues/14924#issuecomment-2676983132 @himanish-star -- I would still think the behavior of not doing anything about a NULL value being sent to partial update flow as bug. NULL is sent for that column and one would expec

Re: [PR] [bugfix] Enable force overwrite for partial upserts [pinot]

2025-02-23 Thread via GitHub
raghukn commented on PR #15107: URL: https://github.com/apache/pinot/pull/15107#issuecomment-2676983861 Pls update the documentation also with this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t