Re: [PR] Add a dry-run summary mode for TableRebalance which only returns a summary of the dry-run results [pinot]

2025-02-15 Thread via GitHub
npawar commented on PR #15050: URL: https://github.com/apache/pinot/pull/15050#issuecomment-2661233155 > This PR adds a `summary` option to the TableRebalance API which is meant to be used with `dryRun`. If `summary` is set to `true` a summary of the dry-run is returned rather than the full

Re: [PR] Emits metric before Consumer gets stuck in postStopConsumedMsg Method [pinot]

2025-02-15 Thread via GitHub
codecov-commenter commented on PR #15070: URL: https://github.com/apache/pinot/pull/15070#issuecomment-2661125201 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15070?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Emits metric before Consumer gets stuck in postStopConsumedMsg Method [pinot]

2025-02-15 Thread via GitHub
noob-se7en opened a new pull request, #15070: URL: https://github.com/apache/pinot/pull/15070 **Problem** Encountered an issue where if PartitionConsumer runs into an Exception, The Consumer thread gets stuck in an endless loop of [postStopConsumedMsg](https://github.com/apache/pinot/blo

Re: [PR] Add null checks when sampling thread resource usage. [pinot]

2025-02-15 Thread via GitHub
codecov-commenter commented on PR #15069: URL: https://github.com/apache/pinot/pull/15069#issuecomment-2660870732 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15069?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Add null checks when sampling thread resource usage. [pinot]

2025-02-15 Thread via GitHub
vrajat commented on code in PR #15069: URL: https://github.com/apache/pinot/pull/15069#discussion_r1957085491 ## pinot-core/src/main/java/org/apache/pinot/core/accounting/PerQueryCPUMemAccountantFactory.java: ## @@ -278,8 +278,9 @@ public void updateQueryUsageConcurrently(String

Re: [PR] Add null checks when sampling thread resource usage. [pinot]

2025-02-15 Thread via GitHub
vrajat commented on code in PR #15069: URL: https://github.com/apache/pinot/pull/15069#discussion_r1957085311 ## pinot-core/src/main/java/org/apache/pinot/core/accounting/PerQueryCPUMemAccountantFactory.java: ## @@ -278,8 +278,9 @@ public void updateQueryUsageConcurrently(String

Re: [PR] Add null checks when sampling thread resource usage. [pinot]

2025-02-15 Thread via GitHub
yashmayya commented on code in PR #15069: URL: https://github.com/apache/pinot/pull/15069#discussion_r1957084417 ## pinot-core/src/main/java/org/apache/pinot/core/accounting/PerQueryCPUMemAccountantFactory.java: ## @@ -278,8 +278,9 @@ public void updateQueryUsageConcurrently(Str

[PR] Add null checks when sampling thread resource usage. [pinot]

2025-02-15 Thread via GitHub
vrajat opened a new pull request, #15069: URL: https://github.com/apache/pinot/pull/15069 Issues like https://github.com/apache/pinot/issues/15045 are caused because some query execution paths are not instrumented to capture thread usage. When instrumentation is turned on NPE is caused. Sin

Re: [I] Add useful H3 functions [pinot]

2025-02-15 Thread via GitHub
meshari343 commented on issue #14703: URL: https://github.com/apache/pinot/issues/14703#issuecomment-2660847118 @ashishjayamohan , I still haven’t fully understood the design of the system, but since you’re interested on this issue then sure you’re more than welcome. -- This is an automa