Re: [PR] [Spool] Actual implementation [pinot]

2024-12-22 Thread via GitHub
gortiz commented on code in PR #14507: URL: https://github.com/apache/pinot/pull/14507#discussion_r1895374402 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/physical/DispatchablePlanVisitor.java: ## @@ -37,10 +40,7 @@ public class DispatchablePlanVisito

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-12-22 Thread via GitHub
yashmayya commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1895341255 ## pinot-controller/src/main/java/org/apache/pinot/controller/cursors/ResponseStoreCleaner.java: ## @@ -0,0 +1,222 @@ +/** + * Licensed to the Apache Software Foundat

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-12-22 Thread via GitHub
yashmayya commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1895335787 ## pinot-broker/src/main/java/org/apache/pinot/broker/cursors/FsResponseStore.java: ## @@ -0,0 +1,280 @@ +/** + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-12-22 Thread via GitHub
yashmayya commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1895333851 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ## @@ -1301,4 +1308,25 @@ public static class NullValuePlaceHolder { public static fi

Re: [PR] Re-implement distinct operators [pinot]

2024-12-22 Thread via GitHub
codecov-commenter commented on PR #14701: URL: https://github.com/apache/pinot/pull/14701#issuecomment-2559036293 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14701?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Adding SHOW TABLES/DESCRIBE table support [pinot]

2024-12-22 Thread via GitHub
aadilkhalifa commented on code in PR #12537: URL: https://github.com/apache/pinot/pull/12537#discussion_r1895325413 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java: ## @@ -1857,4 +1868,65 @@ private static class Query

Re: [PR] Adding SHOW TABLES/DESCRIBE table support [pinot]

2024-12-22 Thread via GitHub
aadilkhalifa commented on code in PR #12537: URL: https://github.com/apache/pinot/pull/12537#discussion_r1895325216 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java: ## @@ -269,10 +271,22 @@ private String getQueryResponse(Strin

Re: [PR] [Spool] Actual implementation [pinot]

2024-12-22 Thread via GitHub
yashmayya commented on code in PR #14507: URL: https://github.com/apache/pinot/pull/14507#discussion_r1895308029 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/exchange/BlockExchange.java: ## @@ -84,8 +92,19 @@ public boolean send(TransferableBlock

Re: [PR] [feature-request] To add support for lambda expressions [pinot]

2024-12-22 Thread via GitHub
codecov-commenter commented on PR #14699: URL: https://github.com/apache/pinot/pull/14699#issuecomment-2558635189 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14699?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] [WIP] [PoC] Bail Early in And Filter Operator When Possible [pinot]

2024-12-22 Thread via GitHub
codecov-commenter commented on PR #14700: URL: https://github.com/apache/pinot/pull/14700#issuecomment-2558618519 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14700?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] [WIP] [PoC] Bail Early in And Filter Operator When Possible [pinot]

2024-12-22 Thread via GitHub
ankitsultana opened a new pull request, #14700: URL: https://github.com/apache/pinot/pull/14700 Testing unit tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [I] Range Predicates Unable to Avoid Filter Computation Due to Null Column Values [pinot]

2024-12-22 Thread via GitHub
richardstartin commented on issue #14694: URL: https://github.com/apache/pinot/issues/14694#issuecomment-2558596995 FWIW the data structure underlying the range index allows passing in a RoaringBitmap representing an existing filter, so the range predicate is implicitly intersected with the

Re: [I] Range Predicates Unable to Avoid Filter Computation Due to Null Column Values [pinot]

2024-12-22 Thread via GitHub
ankitsultana commented on issue #14694: URL: https://github.com/apache/pinot/issues/14694#issuecomment-2558581081 Yeah I realized this needs more context. ### Problem Consider that we have a Realtime table with a single Kafka partition, that has `event_timestamp` values in incr

Re: [PR] [feature-request] To add support for lambda expressions [pinot]

2024-12-22 Thread via GitHub
cutiepie-10 commented on PR #14699: URL: https://github.com/apache/pinot/pull/14699#issuecomment-2558572970 Hello @maintainers, This is not the final PR I need to add more commits. Please help me for further progress. -- This is an automated message from the Apache Git Service. To re

[PR] [feature-request] To add support for lambda expressions [pinot]

2024-12-22 Thread via GitHub
cutiepie-10 opened a new pull request, #14699: URL: https://github.com/apache/pinot/pull/14699 This is a PR for the issue #14650. I have added the parsing of lambda expression in the CalciteSqlParser class and further continuing to tweak the code. -- This is an automated message from t

Re: [PR] Add a non-blocking groupBy implementation [pinot]

2024-12-22 Thread via GitHub
ankitsultana commented on PR #14698: URL: https://github.com/apache/pinot/pull/14698#issuecomment-2558544092 @xiangfu0 : are you folks also planning to run some benchmarks? And any other ideas you are already trying out? -- This is an automated message from the Apache Git Service. To resp

Re: [PR] Add a non-blocking groupBy implementation [pinot]

2024-12-22 Thread via GitHub
codecov-commenter commented on PR #14698: URL: https://github.com/apache/pinot/pull/14698#issuecomment-2558407951 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14698?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Add a non-blocking groupBy implementation [pinot]

2024-12-22 Thread via GitHub
xiangfu0 opened a new pull request, #14698: URL: https://github.com/apache/pinot/pull/14698 instead of all threads upsert to single IndexedTable, this approach will try to leverage each thread to generate local groupby result then merge and set. -- This is an automated message from th