Re: [PR] Expose QueryScheduler from ServerInstance & Custom interface [pinot]

2024-12-11 Thread via GitHub
praveenc7 commented on code in PR #14630: URL: https://github.com/apache/pinot/pull/14630#discussion_r1881457330 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java: ## @@ -3837,6 +3838,24 @@ public void endReplaceSegments(Stri

Re: [PR] Adding reentrant locks, for raceconditon caused by connectivity issues [pinot]

2024-12-11 Thread via GitHub
codecov-commenter commented on PR #14643: URL: https://github.com/apache/pinot/pull/14643#issuecomment-2537808952 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14643?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] CorrelationId in Broker Logs [pinot]

2024-12-11 Thread via GitHub
codecov-commenter commented on PR #14639: URL: https://github.com/apache/pinot/pull/14639#issuecomment-2537816655 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Upsert small segment merger task in minions [pinot]

2024-12-11 Thread via GitHub
tibrewalpratik17 commented on code in PR #14477: URL: https://github.com/apache/pinot/pull/14477#discussion_r1881381828 ## pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompactmerge/UpsertCompactMergeTaskGenerator.ja

Re: [PR] Small memory leak fix [pinot]

2024-12-11 Thread via GitHub
codecov-commenter commented on PR #14641: URL: https://github.com/apache/pinot/pull/14641#issuecomment-2537808985 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14641?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] [Multi-stage] Support is_leaf_return_final_result agg option [pinot]

2024-12-11 Thread via GitHub
codecov-commenter commented on PR #14645: URL: https://github.com/apache/pinot/pull/14645#issuecomment-2537685268 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

(pinot) branch master updated: Remove info log in DataBlockUtils as it can flood the log (#14644)

2024-12-11 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 167fb679db Remove info log in DataBlockUtils as i

Re: [PR] Remove info log in DataBlockUtils as it can flood the log [pinot]

2024-12-11 Thread via GitHub
Jackie-Jiang merged PR #14644: URL: https://github.com/apache/pinot/pull/14644 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[PR] [Multi-stage] Support is_leaf_return_final_result agg option [pinot]

2024-12-11 Thread via GitHub
Jackie-Jiang opened a new pull request, #14645: URL: https://github.com/apache/pinot/pull/14645 Introduce `is_leaf_return_final_result` as an agg option, which leverages the query option `serverReturnFinalResultKeyUnpartitioned` introduced in #13208 to reduce the data transferred for aggreg

Re: [PR] Remove info log in DataBlockUtils as it can flood the log [pinot]

2024-12-11 Thread via GitHub
codecov-commenter commented on PR #14644: URL: https://github.com/apache/pinot/pull/14644#issuecomment-2537515905 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14644?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Enhance SegmentStatusChecker to honor no-queryable servers and instance assignment config [pinot]

2024-12-11 Thread via GitHub
sajjad-moradi commented on PR #14536: URL: https://github.com/apache/pinot/pull/14536#issuecomment-2537514551 @Jackie-Jiang could you please review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[PR] Remove info log in DataBlockUtils as it can flood the log [pinot]

2024-12-11 Thread via GitHub
Jackie-Jiang opened a new pull request, #14644: URL: https://github.com/apache/pinot/pull/14644 Logging exception when creating `DataBlock` is not very useful, and can potentially flood the log. We already log exception at query level, so this log can be removed -- This is an automated m

Re: [PR] Fixes RealtimeQuickStartWithMinion [pinot]

2024-12-11 Thread via GitHub
codecov-commenter commented on PR #14642: URL: https://github.com/apache/pinot/pull/14642#issuecomment-2537424771 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14642?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Adding reentrant locks, for raceconditon caused by connectivity issues [pinot]

2024-12-11 Thread via GitHub
zeronerdzerogeekzerocool opened a new pull request, #14643: URL: https://github.com/apache/pinot/pull/14643 Fixing an edge case , race condition. When zookeeper connection is broke or takes too long, the synchronzed methods will block all threads . (bugfix, cleanup) -- Th

[PR] Fixes RealtimeQuickStartWithMinion [pinot]

2024-12-11 Thread via GitHub
Harnoor7 opened a new pull request, #14642: URL: https://github.com/apache/pinot/pull/14642 Before this PR RealtimeQuickStartWithMinion does nothing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[PR] Small memory leak fix [pinot]

2024-12-11 Thread via GitHub
zeronerdzerogeekzerocool opened a new pull request, #14641: URL: https://github.com/apache/pinot/pull/14641 Instructions: 1. The PR has to be tagged with at least one of the following labels (*): 1. `feature` 2. `bugfix` 3. `performance` 4. `ui` 5. `backward-i

Re: [I] Count(*) returns empty response when there are no segments [pinot]

2024-12-11 Thread via GitHub
ankitsultana commented on issue #14629: URL: https://github.com/apache/pinot/issues/14629#issuecomment-2537349839 I agree we should fix this and it's been a long standing annoyance. FYI: we had found a somewhat related issue early on in the MSE: #10124, though in that case we were ret

[I] [Tracker] Pinot Multistage Engine Express Mode [pinot]

2024-12-11 Thread via GitHub
ankitsultana opened a new issue, #14640: URL: https://github.com/apache/pinot/issues/14640 **Note:** We will be sharing a design doc soon. We are working on testing this out in one of our clusters via a prototype to get a sense of the scalability characteristics of this approach. ###

Re: [PR] Upsert small segment merger task in minions [pinot]

2024-12-11 Thread via GitHub
klsince commented on code in PR #14477: URL: https://github.com/apache/pinot/pull/14477#discussion_r1881014964 ## pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompactmerge/UpsertCompactMergeTaskGenerator.java: #

Re: [PR] Adding gauges for upstream and consuming offsets [pinot]

2024-12-11 Thread via GitHub
soumitra-st commented on PR #14600: URL: https://github.com/apache/pinot/pull/14600#issuecomment-2537207386 > Offset lag metric computes the diff between latest and current offset, which should tell us how far off our consumer is from latest ? Curious how plotting these 2 independently will

[PR] Feature broker correlation [pinot]

2024-12-11 Thread via GitHub
zeronerdzerogeekzerocool opened a new pull request, #14639: URL: https://github.com/apache/pinot/pull/14639 Instructions: 1. The PR has to be tagged with at least one of the following labels (*): 1. `feature` 2. `bugfix` 3. `performance` 4. `ui` 5. `backward-i

Re: [PR] Adding funnel expression evaluation and funnel duration stats support [pinot]

2024-12-11 Thread via GitHub
xiangfu0 closed pull request #14608: Adding funnel expression evaluation and funnel duration stats support URL: https://github.com/apache/pinot/pull/14608 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] use dictionary for BinaryOperatorTransformFunction when possible [pinot]

2024-12-11 Thread via GitHub
Jackie-Jiang commented on code in PR #14619: URL: https://github.com/apache/pinot/pull/14619#discussion_r1880821432 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/BinaryOperatorTransformFunction.java: ## @@ -48,6 +59,9 @@ public abstract class Bina

Re: [PR] Expose QueryScheduler from ServerInstance & Custom interface [pinot]

2024-12-11 Thread via GitHub
Jackie-Jiang commented on code in PR #14630: URL: https://github.com/apache/pinot/pull/14630#discussion_r1880800731 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java: ## @@ -3837,6 +3838,24 @@ public void endReplaceSegments(S

Re: [PR] Increase timeout for kafka client connection for metadata fetch [pinot]

2024-12-11 Thread via GitHub
codecov-commenter commented on PR #14638: URL: https://github.com/apache/pinot/pull/14638#issuecomment-2536948429 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14638?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

(pinot) branch master updated (dfcc489311 -> 740c110bd3)

2024-12-11 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from dfcc489311 Bump io.grpc:grpc-bom from 1.68.2 to 1.69.0 (#14636) add 740c110bd3 include reason why TableSegmentVali

Re: [PR] include reason why TableSegmentValidationInfo is invalid [pinot]

2024-12-11 Thread via GitHub
Jackie-Jiang merged PR #14612: URL: https://github.com/apache/pinot/pull/14612 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] include reason why TableSegmentValidationInfo is invalid [pinot]

2024-12-11 Thread via GitHub
Jackie-Jiang commented on code in PR #14612: URL: https://github.com/apache/pinot/pull/14612#discussion_r1880779926 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java: ## @@ -1256,8 +1256,9 @@ private long validateSegmentSt

Re: [PR] Expose QueryScheduler from ServerInstance & Custom interface [pinot]

2024-12-11 Thread via GitHub
praveenc7 commented on code in PR #14630: URL: https://github.com/apache/pinot/pull/14630#discussion_r1880763986 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java: ## @@ -3837,6 +3838,11 @@ public void endReplaceSegments(Stri

Re: [PR] Expose QueryScheduler from ServerInstance & Custom interface [pinot]

2024-12-11 Thread via GitHub
praveenc7 commented on code in PR #14630: URL: https://github.com/apache/pinot/pull/14630#discussion_r1880763986 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java: ## @@ -3837,6 +3838,11 @@ public void endReplaceSegments(Stri

[PR] Increase timeout for kafka client connection for metadata fetch [pinot]

2024-12-11 Thread via GitHub
tibrewalpratik17 opened a new pull request, #14638: URL: https://github.com/apache/pinot/pull/14638 ### Issue During the `segmentCommitEndWithMetadata` call from the server to the controller at commit time, the controller persists information about the committing segment in Zookeeper

Re: [PR] Bump software.amazon.awssdk:bom from 2.29.30 to 2.29.31 [pinot]

2024-12-11 Thread via GitHub
tibrewalpratik17 merged PR #14637: URL: https://github.com/apache/pinot/pull/14637 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@p

(pinot) branch dependabot/maven/com.google.cloud-libraries-bom-26.51.0 deleted (was 62154e6729)

2024-12-11 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.google.cloud-libraries-bom-26.51.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was 62154e6729 Bump com.google.cloud:libraries-bom from 26.50.0 to 26

Re: [PR] Expose QueryScheduler from ServerInstance & Custom interface [pinot]

2024-12-11 Thread via GitHub
Jackie-Jiang commented on code in PR #14630: URL: https://github.com/apache/pinot/pull/14630#discussion_r1880739219 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java: ## @@ -3837,6 +3838,11 @@ public void endReplaceSegments(S

Re: [PR] Bump com.google.cloud:libraries-bom from 26.50.0 to 26.51.0 [pinot]

2024-12-11 Thread via GitHub
dependabot[bot] commented on PR #14606: URL: https://github.com/apache/pinot/pull/14606#issuecomment-2536857291 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

Re: [PR] Bump com.google.cloud:libraries-bom from 26.50.0 to 26.51.0 [pinot]

2024-12-11 Thread via GitHub
Jackie-Jiang closed pull request #14606: Bump com.google.cloud:libraries-bom from 26.50.0 to 26.51.0 URL: https://github.com/apache/pinot/pull/14606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] Fix H3 index boundary calculations. [pinot]

2024-12-11 Thread via GitHub
Jackie-Jiang commented on code in PR #14628: URL: https://github.com/apache/pinot/pull/14628#discussion_r1880731417 ## pinot-core/src/main/java/org/apache/pinot/core/operator/filter/H3IndexFilterOperator.java: ## @@ -78,7 +78,15 @@ public H3IndexFilterOperator(IndexSegment segme

(pinot) branch dependabot/maven/com.google.cloud-libraries-bom-26.51.0 updated (558be3b8db -> 62154e6729)

2024-12-11 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.google.cloud-libraries-bom-26.51.0 in repository https://gitbox.apache.org/repos/asf/pinot.git discard 558be3b8db Bump com.google.cloud:libraries-bom from 26.50.0 to 26

(pinot) branch master updated (e33ad86d1f -> dfcc489311)

2024-12-11 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from e33ad86d1f Bump org.jline:jline from 3.27.1 to 3.28.0 (#14635) add dfcc489311 Bump io.grpc:grpc-bom from 1.68.2 to

Re: [PR] Bump org.jline:jline from 3.27.1 to 3.28.0 [pinot]

2024-12-11 Thread via GitHub
Jackie-Jiang merged PR #14635: URL: https://github.com/apache/pinot/pull/14635 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated (57d1f770da -> e33ad86d1f)

2024-12-11 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 57d1f770da Bump software.amazon.awssdk:bom from 2.29.30 to 2.29.31 (#14637) add e33ad86d1f Bump org.jline:jline f

Re: [PR] Bump io.grpc:grpc-bom from 1.68.2 to 1.69.0 [pinot]

2024-12-11 Thread via GitHub
Jackie-Jiang merged PR #14636: URL: https://github.com/apache/pinot/pull/14636 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch dependabot/maven/io.grpc-grpc-bom-1.69.0 deleted (was 33e0e417b4)

2024-12-11 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/io.grpc-grpc-bom-1.69.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was 33e0e417b4 Bump io.grpc:grpc-bom from 1.68.2 to 1.69.0 The revisions that were on th

(pinot) branch dependabot/maven/org.jline-jline-3.28.0 deleted (was 77448c3245)

2024-12-11 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/org.jline-jline-3.28.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was 77448c3245 Bump org.jline:jline from 3.27.1 to 3.28.0 The revisions that were on this

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.29.31 deleted (was f77daab3bb)

2024-12-11 Thread pratik
This is an automated email from the ASF dual-hosted git repository. pratik pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.29.31 in repository https://gitbox.apache.org/repos/asf/pinot.git was f77daab3bb Bump software.amazon.awssdk:bom from 2.29.30 to 2.29.31 The r

(pinot) branch master updated (b4066fbd40 -> 57d1f770da)

2024-12-11 Thread pratik
This is an automated email from the ASF dual-hosted git repository. pratik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from b4066fbd40 Fix flaky quota integration tests (#14602) add 57d1f770da Bump software.amazon.awssdk:bom from 2.29.30

Re: [PR] Expose QueryScheduler from ServerInstance & Custom interface [pinot]

2024-12-11 Thread via GitHub
vvivekiyer commented on code in PR #14630: URL: https://github.com/apache/pinot/pull/14630#discussion_r1880542399 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java: ## @@ -3837,6 +3838,11 @@ public void endReplaceSegments(Str

Re: [PR] Make segment completion FSM pluggable [pinot]

2024-12-11 Thread via GitHub
KKcorps commented on code in PR #14088: URL: https://github.com/apache/pinot/pull/14088#discussion_r1880235825 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/SegmentCompletionFSM.java: ## @@ -0,0 +1,128 @@ +/** + * Licensed to the Apache Softwa

Re: [PR] Make segment completion FSM pluggable [pinot]

2024-12-11 Thread via GitHub
KKcorps commented on code in PR #14088: URL: https://github.com/apache/pinot/pull/14088#discussion_r1880187070 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/SegmentCompletionConfig.java: ## @@ -0,0 +1,44 @@ +/** + * Licensed to the Apache Soft

Re: [I] numServersQueried, responded is not set in BrokerResponse for MSQE [pinot]

2024-12-11 Thread via GitHub
yashmayya commented on issue #14624: URL: https://github.com/apache/pinot/issues/14624#issuecomment-2535908835 It should be fairly straightforward to get the servers queried from the query plan in the broker. I'm not sure if there's a straightforward way to get the servers responded stats t

Re: [I] numServersQueried, responded is not set in BrokerResponse for MSQE [pinot]

2024-12-11 Thread via GitHub
yashmayya commented on issue #14624: URL: https://github.com/apache/pinot/issues/14624#issuecomment-2535893269 Looks like this was left as a TODO - https://github.com/apache/pinot/blob/b4066fbd40cce1e035a70968382fc24b3b7f4427/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/

(pinot) branch dependabot/maven/io.grpc-grpc-bom-1.69.0 created (now 33e0e417b4)

2024-12-11 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/io.grpc-grpc-bom-1.69.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at 33e0e417b4 Bump io.grpc:grpc-bom from 1.68.2 to 1.69.0 No new revisions were add

[PR] Bump org.jline:jline from 3.27.1 to 3.28.0 [pinot]

2024-12-11 Thread via GitHub
dependabot[bot] opened a new pull request, #14635: URL: https://github.com/apache/pinot/pull/14635 Bumps [org.jline:jline](https://github.com/jline/jline3) from 3.27.1 to 3.28.0. Release notes Sourced from https://github.com/jline/jline3/releases";>org.jline:jline's releases.

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.29.31 created (now f77daab3bb)

2024-12-11 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.29.31 in repository https://gitbox.apache.org/repos/asf/pinot.git at f77daab3bb Bump software.amazon.awssdk:bom from 2.29.30 to 2.29.31 N

[PR] Bump software.amazon.awssdk:bom from 2.29.30 to 2.29.31 [pinot]

2024-12-11 Thread via GitHub
dependabot[bot] opened a new pull request, #14637: URL: https://github.com/apache/pinot/pull/14637 Bumps software.amazon.awssdk:bom from 2.29.30 to 2.29.31. Most Recent Ignore Conditions Applied to This Pull Request | Dependency Name | Ignore Conditions | | --- | --- |

(pinot) branch dependabot/maven/org.jline-jline-3.28.0 created (now 77448c3245)

2024-12-11 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.jline-jline-3.28.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at 77448c3245 Bump org.jline:jline from 3.27.1 to 3.28.0 No new revisions were added

[PR] Bump io.grpc:grpc-bom from 1.68.2 to 1.69.0 [pinot]

2024-12-11 Thread via GitHub
dependabot[bot] opened a new pull request, #14636: URL: https://github.com/apache/pinot/pull/14636 Bumps [io.grpc:grpc-bom](https://github.com/grpc/grpc-java) from 1.68.2 to 1.69.0. Commits https://github.com/grpc/grpc-java/commit/34a7cffcf3dca012cd3e48da14d127c3afd924bf";>34a7

Re: [PR] Adding gauges for upstream and consuming offsets [pinot]

2024-12-11 Thread via GitHub
suddendust commented on PR #14600: URL: https://github.com/apache/pinot/pull/14600#issuecomment-2535535720 @soumitra-st Can you check the failing tests? Looks like `YammerServerPrometheusMetricsTest` is failing -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Fix H3 index boundary calculations. [pinot]

2024-12-11 Thread via GitHub
bziobrowski commented on code in PR #14628: URL: https://github.com/apache/pinot/pull/14628#discussion_r1879603841 ## pinot-core/src/main/java/org/apache/pinot/core/operator/filter/H3IndexFilterOperator.java: ## @@ -78,7 +78,15 @@ public H3IndexFilterOperator(IndexSegment segmen

Re: [PR] Fix H3 index boundary calculations. [pinot]

2024-12-11 Thread via GitHub
bziobrowski commented on code in PR #14628: URL: https://github.com/apache/pinot/pull/14628#discussion_r1879603841 ## pinot-core/src/main/java/org/apache/pinot/core/operator/filter/H3IndexFilterOperator.java: ## @@ -78,7 +78,15 @@ public H3IndexFilterOperator(IndexSegment segmen

Re: [I] Add a Server API to list segments of a table that are out of date [pinot]

2024-12-11 Thread via GitHub
vrajat closed issue #14450: Add a Server API to list segments of a table that are out of date URL: https://github.com/apache/pinot/issues/14450 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-12-11 Thread via GitHub
vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1879664114 ## pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotClientRequest.java: ## @@ -437,6 +456,22 @@ private BrokerResponse executeSqlQuery(ObjectNode s

[I] Support for size based minion UpsertCompactMerge task [pinot]

2024-12-11 Thread via GitHub
tibrewalpratik17 opened a new issue, #14634: URL: https://github.com/apache/pinot/issues/14634 Similar to #12225 Follow-up from https://github.com/apache/pinot/pull/14477#discussion_r1879091859 Right now, we use `maxNumRecordsPerTask` / `maxNumRecordsPerSegment` for tracking the o

Re: [PR] Improve the unit test dataset used by CLPMutableForwardIndexV2Test and CLPForwardIndexCreatorV2Test [pinot]

2024-12-11 Thread via GitHub
codecov-commenter commented on PR #14632: URL: https://github.com/apache/pinot/pull/14632#issuecomment-2535246311 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14632?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Upsert small segment merger task in minions [pinot]

2024-12-11 Thread via GitHub
tibrewalpratik17 commented on code in PR #14477: URL: https://github.com/apache/pinot/pull/14477#discussion_r1879654220 ## pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompactmerge/UpsertCompactMergeTaskGenerator.ja

[I] SegmentRefresh task compatibility with UpsertCompactMerge task [pinot]

2024-12-11 Thread via GitHub
tibrewalpratik17 opened a new issue, #14633: URL: https://github.com/apache/pinot/issues/14633 Creating this issue from comment: https://github.com/apache/pinot/pull/14477#discussion_r1870284658 The current approach for determining the latest uploaded segment in the UploadedRealtimeS

Re: [PR] Upsert small segment merger task in minions [pinot]

2024-12-11 Thread via GitHub
tibrewalpratik17 commented on code in PR #14477: URL: https://github.com/apache/pinot/pull/14477#discussion_r1879646273 ## pinot-core/src/main/java/org/apache/pinot/core/common/MinionConstants.java: ## @@ -199,4 +200,59 @@ public static class UpsertCompactionTask { */

Re: [PR] Upsert small segment merger task in minions [pinot]

2024-12-11 Thread via GitHub
tibrewalpratik17 commented on code in PR #14477: URL: https://github.com/apache/pinot/pull/14477#discussion_r1879628123 ## pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompactmerge/UpsertCompactMergeTaskExecutor.jav

Re: [PR] Fix H3 index boundary calculations. [pinot]

2024-12-11 Thread via GitHub
bziobrowski commented on code in PR #14628: URL: https://github.com/apache/pinot/pull/14628#discussion_r1879603841 ## pinot-core/src/main/java/org/apache/pinot/core/operator/filter/H3IndexFilterOperator.java: ## @@ -78,7 +78,15 @@ public H3IndexFilterOperator(IndexSegment segmen

[PR] Improve the unit test dataset used by CLPMutableForwardIndexV2Test and CLPForwardIndexCreatorV2Test [pinot]

2024-12-11 Thread via GitHub
jackluo923 opened a new pull request, #14632: URL: https://github.com/apache/pinot/pull/14632 This PR updates the unit tests for CLPMutableForwardIndexV2Test and CLPForwardIndexCreatorV2Test, which previously inherited trivial input data from CLPMutableForwardIndexTest and CLPForwardIndexCr