Re: [PR] [Multi-stage] Allow filter for lookup JOIN [pinot]

2024-11-24 Thread via GitHub
gortiz commented on code in PR #14523: URL: https://github.com/apache/pinot/pull/14523#discussion_r1856010755 ## pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotFilterJoinRule.java: ## @@ -0,0 +1,262 @@ +/** + * Licensed to the Apache Software Foundatio

Re: [I] Convert BYTES DataType to DECIMAL in Apache Pinot [pinot]

2024-11-24 Thread via GitHub
rajat-sr1704 commented on issue #14510: URL: https://github.com/apache/pinot/issues/14510#issuecomment-2497037361 also @Jackie-Jiang can you tell me if i am creating the UDF, where should I put the jar files in the pinot? -- This is an automated message from the Apache Git Service. To

Re: [PR] Adds check if controller tmp dir exists [pinot]

2024-11-24 Thread via GitHub
shounakmk219 commented on code in PR #14503: URL: https://github.com/apache/pinot/pull/14503#discussion_r1855876987 ## pinot-controller/src/test/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResourceTest.java: ## @@ -56,20 +66,27 @@ public class

Re: [PR] Add a Server API to list segments that need to be refreshed for a table [pinot]

2024-11-24 Thread via GitHub
vrajat commented on code in PR #14451: URL: https://github.com/apache/pinot/pull/14451#discussion_r1855827237 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java: ## @@ -891,6 +892,31 @@ public String getTableReloadMetadat

Re: [PR] Add a Server API to list segments that need to be refreshed for a table [pinot]

2024-11-24 Thread via GitHub
vrajat commented on code in PR #14451: URL: https://github.com/apache/pinot/pull/14451#discussion_r1855820871 ## pinot-controller/src/main/java/org/apache/pinot/controller/util/ServerSegmentMetadataReader.java: ## @@ -397,6 +398,39 @@ public ValidDocIdsBitmapResponse getValidDo

Re: [I] Spark ingestion with yarn cluster mode expecting the spec file to be available across all the node manage nodes [pinot]

2024-11-24 Thread via GitHub
chrajeshbabu commented on issue #14527: URL: https://github.com/apache/pinot/issues/14527#issuecomment-2496847813 It's an improvement and working on it other wise it's painful to add the spec file across the nodes when there are many node managers in the cluster because containers can be la

Re: [PR] Add a Server API to list segments that need to be refreshed for a table [pinot]

2024-11-24 Thread via GitHub
vrajat commented on code in PR #14451: URL: https://github.com/apache/pinot/pull/14451#discussion_r1855815497 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java: ## @@ -1046,6 +1064,261 @@ public boolean needReloadSegments() return need

[I] Spark ingestion with yarn cluster mode expecting the spec file to be available across all the node manage nodes [pinot]

2024-11-24 Thread via GitHub
chrajeshbabu opened a new issue, #14527: URL: https://github.com/apache/pinot/issues/14527 When we just define ingestion spec file at one place start a spark ingestion job getting spec file not found exception. The reason is the spec file is not is getting distributing as like other depende

Re: [PR] Support for S3A Connector #14312 [pinot]

2024-11-24 Thread via GitHub
chrajeshbabu commented on PR #14474: URL: https://github.com/apache/pinot/pull/14474#issuecomment-2496830044 Thank you merging it @xiangfu0. @mayankshriv for review. Will add the release notes. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Add a Server API to list segments that need to be refreshed for a table [pinot]

2024-11-24 Thread via GitHub
swaminathanmanish commented on code in PR #14451: URL: https://github.com/apache/pinot/pull/14451#discussion_r1855428433 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/data/manager/NeedRefreshResponse.java: ## @@ -0,0 +1,62 @@ +/** + * Licensed to the Apache

Re: [PR] Configurable sketch accuracy in merge rollup task [pinot]

2024-11-24 Thread via GitHub
swaminathanmanish commented on code in PR #14373: URL: https://github.com/apache/pinot/pull/14373#discussion_r1855425265 ## pinot-core/src/main/java/org/apache/pinot/core/segment/processing/aggregator/DistinctCountCPCSketchAggregator.java: ## @@ -30,7 +31,7 @@ public DistinctCou

Re: [PR] Extend the merge rollup task capabilities [pinot]

2024-11-24 Thread via GitHub
swaminathanmanish commented on code in PR #14355: URL: https://github.com/apache/pinot/pull/14355#discussion_r1855422209 ## pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/DimensionValueTransformer.java: