Re: [I] Not able to connect to slack [pinot]

2024-10-24 Thread via GitHub
yeshu044 commented on issue #14297: URL: https://github.com/apache/pinot/issues/14297#issuecomment-2435595255 https://github.com/user-attachments/assets/a6357951-6b9c-4dca-b4c5-8d654e165161";> -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[PR] [Bugfix] delete segment API always deletes consuming segments [pinot]

2024-10-24 Thread via GitHub
tibrewalpratik17 opened a new pull request, #14293: URL: https://github.com/apache/pinot/pull/14293 label: `bugfix` At present, while using DELETE API `"/segments/{tableName}/choose"` we always end up deleting consuming segments. This is because of using common segments selection

Re: [PR] Add IGNORE NULLS option to FIRST_VALUE and LAST_VALUE window functions [pinot]

2024-10-24 Thread via GitHub
Jackie-Jiang commented on code in PR #14264: URL: https://github.com/apache/pinot/pull/14264#discussion_r1815544184 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/NullHandlingIntegrationTest.java: ## @@ -326,6 +326,31 @@ public void testAggregateServ

Re: [PR] Bump com.google.protobuf:protobuf-bom from 3.25.5 to 4.28.3 [pinot]

2024-10-24 Thread via GitHub
dependabot[bot] closed pull request #14291: Bump com.google.protobuf:protobuf-bom from 3.25.5 to 4.28.3 URL: https://github.com/apache/pinot/pull/14291 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] [Bugfix] delete segment API always deletes consuming segments [pinot]

2024-10-24 Thread via GitHub
tibrewalpratik17 commented on PR #14293: URL: https://github.com/apache/pinot/pull/14293#issuecomment-2436247441 > I'd suggest modifying the logic to not selecting consuming segment when end timestamp is specified. Essentially counting the consuming segment as always match the start timesta

Re: [PR] bugfix: TextMatchFilterOptimizer grouping for inner compound query [pinot]

2024-10-24 Thread via GitHub
codecov-commenter commented on PR #14299: URL: https://github.com/apache/pinot/pull/14299#issuecomment-2436345679 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14299?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] [spool] Define equivalence between stages [pinot]

2024-10-24 Thread via GitHub
vrajat commented on code in PR #14296: URL: https://github.com/apache/pinot/pull/14296#discussion_r1815439888 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/plannode/PlanNodeVisitor.java: ## @@ -63,4 +63,150 @@ public interface PlanNodeVisitor { T visitEx

Re: [I] Pinot Controller leader re-election not triggered [pinot]

2024-10-24 Thread via GitHub
Jackie-Jiang closed issue #13990: Pinot Controller leader re-election not triggered URL: https://github.com/apache/pinot/issues/13990 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] do not add column name separator on dowload [pinot]

2024-10-24 Thread via GitHub
codecov-commenter commented on PR #14303: URL: https://github.com/apache/pinot/pull/14303#issuecomment-2436580674 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14303?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Add optional 5th parameter - bucketing time zone - to dateTimeConvet() function [pinot]

2024-10-24 Thread via GitHub
bziobrowski opened a new pull request, #14298: URL: https://github.com/apache/pinot/pull/14298 This PR adds an optional parameter to dateTimeConvert() function - bucketing time zone. It allows specifying specific time zone to bucketing, regardless of output time zone - which could be epo

(pinot) branch master updated: Use fixed thread pool in Pinot Controller (#14159)

2024-10-24 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 44eb01feae Use fixed thread pool in Pinot Control

[PR] do not add column name separator on dowload [pinot]

2024-10-24 Thread via GitHub
jadami10 opened a new pull request, #14303: URL: https://github.com/apache/pinot/pull/14303 This is a `ui` `bugfix` that closes #14302 columnNameSeparator was added in #8131 to allow displaying columns with the same name. But we don't need to carry that over when downloading the data.

Re: [PR] Update slack invite link [pinot-site]

2024-10-24 Thread via GitHub
xiangfu0 merged PR #137: URL: https://github.com/apache/pinot-site/pull/137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

Re: [PR] Minion Task to support automatic Segment Refresh [pinot]

2024-10-24 Thread via GitHub
ankitsultana commented on PR #14300: URL: https://github.com/apache/pinot/pull/14300#issuecomment-2436438032 @vvivekiyer : the idea is quite interesting and the value add I see here is: * We can increase concurrency for segment refresh thereby reducing the total time to reload all seg

Re: [PR] Minion Task to support automatic Segment Refresh [pinot]

2024-10-24 Thread via GitHub
codecov-commenter commented on PR #14300: URL: https://github.com/apache/pinot/pull/14300#issuecomment-2436476955 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14300?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Upgrade http5 Client to 5.4 and using Http 2 Protocol [pinot]

2024-10-24 Thread via GitHub
abhioncbr commented on PR #14191: URL: https://github.com/apache/pinot/pull/14191#issuecomment-2436418018 > This is the highlighted release note, not sure if related to the issue we encountered: > > ``` > IMPORTANT! The new cache entry serialization format is incompatible with ear

Re: [PR] Use fixed thread pool in Pinot Controller [pinot]

2024-10-24 Thread via GitHub
Jackie-Jiang commented on PR #14159: URL: https://github.com/apache/pinot/pull/14159#issuecomment-2436283408 Thanks for the contribution! Please help update pinot doc about these new configs -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Use fixed thread pool in Pinot Controller [pinot]

2024-10-24 Thread via GitHub
Jackie-Jiang merged PR #14159: URL: https://github.com/apache/pinot/pull/14159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Use fixed thread pool in Pinot Controller [pinot]

2024-10-24 Thread via GitHub
tibrewalpratik17 commented on PR #14159: URL: https://github.com/apache/pinot/pull/14159#issuecomment-2436249618 @Jackie-Jiang does this change address all your comments? Waiting for your approval before merging this. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Deprecate _segmentAssignmentStrategy in SegmentsValidationAndRetentionConfig [pinot]

2024-10-24 Thread via GitHub
jadami10 commented on code in PR #11869: URL: https://github.com/apache/pinot/pull/11869#discussion_r1815599729 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/IngestionConfigUtils.java: ## @@ -116,7 +117,7 @@ public static String getBatchSegmentIngestionType(TableConfig

Re: [I] [proposal] Reuse common expressions in a query [pinot]

2024-10-24 Thread via GitHub
ankitsultana commented on issue #14196: URL: https://github.com/apache/pinot/issues/14196#issuecomment-2436149014 @gortiz : do you folks have some numbers which show the performance gains with this approach? And specifically which queries this will help? I have seen CTE reuse in query

Re: [PR] Add optional 5th parameter - bucketing time zone - to dateTimeConvet() function [pinot]

2024-10-24 Thread via GitHub
codecov-commenter commented on PR #14298: URL: https://github.com/apache/pinot/pull/14298#issuecomment-2436158001 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14298?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Upgrade http5 Client to 5.4 and using Http 2 Protocol [pinot]

2024-10-24 Thread via GitHub
Jackie-Jiang commented on PR #14191: URL: https://github.com/apache/pinot/pull/14191#issuecomment-2436124636 This is the highlighted release note, not sure if related to the issue we encountered: ``` IMPORTANT! The new cache entry serialization format is incompatible with earlier v

Re: [PR] Add support for defining custom window frame bounds for window functions [pinot]

2024-10-24 Thread via GitHub
Jackie-Jiang merged PR #14273: URL: https://github.com/apache/pinot/pull/14273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [I] [Multi Stage] Add ROWS support for aggregation window functions [pinot]

2024-10-24 Thread via GitHub
Jackie-Jiang closed issue #11406: [Multi Stage] Add ROWS support for aggregation window functions URL: https://github.com/apache/pinot/issues/11406 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

(pinot) branch dependabot/maven/lucene.version-10.0.0 deleted (was beed9830b2)

2024-10-24 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/lucene.version-10.0.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was beed9830b2 Bump lucene.version from 9.11.1 to 10.0.0 The revisions that were on th

Re: [PR] Bump lucene.version from 9.11.1 to 10.0.0 [pinot]

2024-10-24 Thread via GitHub
Jackie-Jiang commented on PR #14219: URL: https://github.com/apache/pinot/pull/14219#issuecomment-2436014097 @dependabot ignore this major version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] Lucene 10.0 upgrade [pinot]

2024-10-24 Thread via GitHub
Jackie-Jiang commented on issue #14232: URL: https://github.com/apache/pinot/issues/14232#issuecomment-2436019406 Thanks for the investigation! Shall we upgrade to `9.12.0` instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] Bump lucene.version from 9.11.1 to 10.0.0 [pinot]

2024-10-24 Thread via GitHub
dependabot[bot] commented on PR #14219: URL: https://github.com/apache/pinot/pull/14219#issuecomment-2436014335 OK, I won't notify you about version 10.x.x again, unless you re-open this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Bump lucene.version from 9.11.1 to 10.0.0 [pinot]

2024-10-24 Thread via GitHub
dependabot[bot] closed pull request #14219: Bump lucene.version from 9.11.1 to 10.0.0 URL: https://github.com/apache/pinot/pull/14219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] Bump lucene.version from 9.11.1 to 10.0.0 [pinot]

2024-10-24 Thread via GitHub
Jackie-Jiang commented on PR #14219: URL: https://github.com/apache/pinot/pull/14219#issuecomment-2436011491 Here is the release doc: https://lucene.apache.org/core/corenews.html#apache-lucenetm-1000-available @abhioncbr In that case, should we try to upgrade to `9.12.0` instead? --

Re: [PR] Bump io.prometheus.jmx:jmx_prometheus_javaagent from 0.19.0 to 1.0.1 [pinot]

2024-10-24 Thread via GitHub
Jackie-Jiang commented on PR #14292: URL: https://github.com/apache/pinot/pull/14292#issuecomment-2435999222 @suddendust Can you help take a look? Do we want to upgrade to the latest version? -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] Bump com.google.protobuf:protobuf-bom from 3.25.5 to 4.28.3 [pinot]

2024-10-24 Thread via GitHub
dependabot[bot] commented on PR #14291: URL: https://github.com/apache/pinot/pull/14291#issuecomment-2435960279 OK, I won't notify you about version 4.x.x again, unless you re-open this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] [spool] Define equivalence between stages [pinot]

2024-10-24 Thread via GitHub
codecov-commenter commented on PR #14296: URL: https://github.com/apache/pinot/pull/14296#issuecomment-2435591381 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14296?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

(pinot-site) 01/01: Update slack invite link

2024-10-24 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch update-invite-link in repository https://gitbox.apache.org/repos/asf/pinot-site.git commit 84cc36b82c7536b8bd8c6c2094b6df2f9a922560 Author: Xiang Fu AuthorDate: Thu Oct 24 10:10:41 2024 -0700

(pinot-site) branch update-invite-link created (now 84cc36b8)

2024-10-24 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch update-invite-link in repository https://gitbox.apache.org/repos/asf/pinot-site.git at 84cc36b8 Update slack invite link This branch includes the following new commits: new 84cc36b8

[PR] Update slack invite link [pinot-site]

2024-10-24 Thread via GitHub
xiangfu0 opened a new pull request, #137: URL: https://github.com/apache/pinot-site/pull/137 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

(pinot) branch master updated: fix(ui): remove redundant api calls in home page (#14295)

2024-10-24 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 30f414925c fix(ui): remove redundant api calls in

Re: [PR] fix(ui): remove redundant api calls in home page [pinot]

2024-10-24 Thread via GitHub
Jackie-Jiang merged PR #14295: URL: https://github.com/apache/pinot/pull/14295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[I] Not able to connect to slack [pinot]

2024-10-24 Thread via GitHub
yeshu044 opened a new issue, #14297: URL: https://github.com/apache/pinot/issues/14297 From the apache pinot official webpage , I tried to connect to slack channel it gave me an error like this ![Uploading Screenshot 2024-10-24 at 8.49.47 PM.png…]() -- This is an automated mess

Re: [PR] [spool] Define equivalence between stages [pinot]

2024-10-24 Thread via GitHub
gortiz commented on PR #14296: URL: https://github.com/apache/pinot/pull/14296#issuecomment-2435449673 cc @bziobrowski @vrajat -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[PR] [spool] Define equivalence between stages [pinot]

2024-10-24 Thread via GitHub
gortiz opened a new pull request, #14296: URL: https://github.com/apache/pinot/pull/14296 This PR includes the code that defines when two stages are equivalent and it is the first step to implement #14196. Instead of implementing the ability to reuse common expressions in a single an

[PR] fix(ui): remove redundant api calls in home page [pinot]

2024-10-24 Thread via GitHub
jayeshchoudhary opened a new pull request, #14295: URL: https://github.com/apache/pinot/pull/14295 resolves - #14065 this is `ui`, `bugfix` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Upgrade http5 Client to 5.4 and using Http 2 Protocol [pinot]

2024-10-24 Thread via GitHub
abhioncbr commented on PR #14191: URL: https://github.com/apache/pinot/pull/14191#issuecomment-2435352441 > Thanks for debugging this! > > Can you elaborate more on the root cause? Since the bug was fixed in the new version, why would our test fail? Is there extra overhead if we do no

Re: [PR] [Bugfix] delete segment API always deletes consuming segments [pinot]

2024-10-24 Thread via GitHub
codecov-commenter commented on PR #14293: URL: https://github.com/apache/pinot/pull/14293#issuecomment-2435312616 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14293?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Bump com.google.protobuf:protobuf-bom from 3.25.5 to 4.28.3 [pinot]

2024-10-24 Thread via GitHub
dependabot[bot] opened a new pull request, #14291: URL: https://github.com/apache/pinot/pull/14291 Bumps [com.google.protobuf:protobuf-bom](https://github.com/protocolbuffers/protobuf) from 3.25.5 to 4.28.3. Commits See full diff in https://github.com/protocolbuffers/protobuf/

(pinot) branch dependabot/maven/io.prometheus.jmx-jmx_prometheus_javaagent-1.0.1 created (now 976aa2c8e7)

2024-10-24 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/io.prometheus.jmx-jmx_prometheus_javaagent-1.0.1 in repository https://gitbox.apache.org/repos/asf/pinot.git at 976aa2c8e7 Bump io.prometheus.jmx:jmx_prometheus_javaag

[PR] Bump io.prometheus.jmx:jmx_prometheus_javaagent from 0.19.0 to 1.0.1 [pinot]

2024-10-24 Thread via GitHub
dependabot[bot] opened a new pull request, #14292: URL: https://github.com/apache/pinot/pull/14292 Bumps [io.prometheus.jmx:jmx_prometheus_javaagent](https://github.com/prometheus/jmx_exporter) from 0.19.0 to 1.0.1. Release notes Sourced from https://github.com/prometheus/jmx_expo

(pinot) branch dependabot/maven/com.google.protobuf-protobuf-bom-4.28.3 created (now 0421ca5e0b)

2024-10-24 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.google.protobuf-protobuf-bom-4.28.3 in repository https://gitbox.apache.org/repos/asf/pinot.git at 0421ca5e0b Bump com.google.protobuf:protobuf-bom from 3.25.5 to

(pinot) branch intellij-method-chain-chop-if-long updated (0c50528668 -> 202fc995d1)

2024-10-24 Thread gortiz
This is an automated email from the ASF dual-hosted git repository. gortiz pushed a change to branch intellij-method-chain-chop-if-long in repository https://gitbox.apache.org/repos/asf/pinot.git from 0c50528668 Change method call chain wrap in intellij to chop if long add 202fc995d1 ke

Re: [PR] Add support for defining custom window frame bounds for window functions [pinot]

2024-10-24 Thread via GitHub
yashmayya commented on code in PR #14273: URL: https://github.com/apache/pinot/pull/14273#discussion_r1814556802 ## pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotWindowExchangeNodeInsertRule.java: ## @@ -144,60 +147,88 @@ public void onMatch(RelOptRul

[PR] Change method call chain wrap in intellij to chop if long [pinot]

2024-10-24 Thread via GitHub
gortiz opened a new pull request, #14290: URL: https://github.com/apache/pinot/pull/14290 We have been (ab)using of `//@formatter:off` to be able to write things like: ``` //@formatter:off QueryEnvironment queryEnvironment = new QueryEnvironment(QueryEnvironment.conf

Re: [PR] Avoid collision in SegmentLocks [pinot]

2024-10-24 Thread via GitHub
Jackie-Jiang commented on PR #13632: URL: https://github.com/apache/pinot/pull/13632#issuecomment-2434582447 @xiangfu0 Seems like this is a critical bug which impacts multiple users. We should consider releasing a patched version -- This is an automated message from the Apache Git Service

(pinot) 01/01: Change method call chain wrap in intellij to chop if long

2024-10-24 Thread gortiz
This is an automated email from the ASF dual-hosted git repository. gortiz pushed a commit to branch intellij-method-chain-chop-if-long in repository https://gitbox.apache.org/repos/asf/pinot.git commit 0c50528668d7086f05dbd68e69b75257ef2b7d48 Author: Gonzalo Ortiz Jaureguizar AuthorDate: Thu Oc

(pinot) branch intellij-method-chain-chop-if-long created (now 0c50528668)

2024-10-24 Thread gortiz
This is an automated email from the ASF dual-hosted git repository. gortiz pushed a change to branch intellij-method-chain-chop-if-long in repository https://gitbox.apache.org/repos/asf/pinot.git at 0c50528668 Change method call chain wrap in intellij to chop if long This branch includes

Re: [PR] Add a flexible json config way [pinot]

2024-10-24 Thread via GitHub
ashishjayamohan commented on code in PR #14229: URL: https://github.com/apache/pinot/pull/14229#discussion_r1814272329 ## pinot-spi/src/test/java/org/apache/pinot/spi/utils/JsonUtilsTest.java: ## @@ -641,4 +641,71 @@ public void testEmptyString() List> flattenedRecords = Js

Re: [PR] Add all supported types to return type inference from string literal for JSON extract functions in the multi-stage query engine [pinot]

2024-10-24 Thread via GitHub
codecov-commenter commented on PR #14289: URL: https://github.com/apache/pinot/pull/14289#issuecomment-2434425230 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14289?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Speed up dev build. [pinot]

2024-10-24 Thread via GitHub
gortiz merged PR #14210: URL: https://github.com/apache/pinot/pull/14210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apach