Re: [PR] Test Cases for JMX -> Prom Exporter Regexps [pinot]

2024-10-20 Thread via GitHub
gortiz commented on code in PR #14155: URL: https://github.com/apache/pinot/pull/14155#discussion_r1808200196 ## pinot-common/src/test/java/org/apache/pinot/common/metrics/BrokerJMXToPromMetricsTest.java: ## @@ -0,0 +1,162 @@ +/** + * Licensed to the Apache Software Foundation (

Re: [I] Hadoop Ingestion job configured with hdfs is failing with IllegalArgumentException [pinot]

2024-10-20 Thread via GitHub
chrajeshbabu commented on issue #14236: URL: https://github.com/apache/pinot/issues/14236#issuecomment-2425758273 @Jackie-Jiang could you please add me as assignee to this ticket. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [I] Replace fmpp-maven-plugin with fmpp Ant Task to avoid pulling the vulnerable log4j jars [pinot]

2024-10-20 Thread via GitHub
chrajeshbabu closed issue #14011: Replace fmpp-maven-plugin with fmpp Ant Task to avoid pulling the vulnerable log4j jars URL: https://github.com/apache/pinot/issues/14011 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Replace fmpp-maven-plugin with fmpp Ant Task to avoid pulling the vulnerable log4j jars [pinot]

2024-10-20 Thread via GitHub
chrajeshbabu commented on PR #14015: URL: https://github.com/apache/pinot/pull/14015#issuecomment-2425746588 Thank you @Jackie-Jiang for merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] Test Cases for JMX -> Prom Exporter Regexps [pinot]

2024-10-20 Thread via GitHub
suddendust commented on code in PR #14155: URL: https://github.com/apache/pinot/pull/14155#discussion_r1808191166 ## pinot-common/src/test/java/org/apache/pinot/common/metrics/PinotJMXToPromMetricsTest.java: ## @@ -0,0 +1,379 @@ +/** + * Licensed to the Apache Software Foundatio

(pinot) branch master updated: Replace fmpp-maven-plugin with fmpp Ant Task to avoid pulling the vulnerable log4j jars (#14015)

2024-10-20 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 9db1625497 Replace fmpp-maven-plugin with fmpp An

Re: [PR] Replace fmpp-maven-plugin with fmpp Ant Task to avoid pulling the vulnerable log4j jars [pinot]

2024-10-20 Thread via GitHub
Jackie-Jiang merged PR #14015: URL: https://github.com/apache/pinot/pull/14015 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Add support for application -level query quota. [pinot]

2024-10-20 Thread via GitHub
shounakmk219 commented on code in PR #14226: URL: https://github.com/apache/pinot/pull/14226#discussion_r1808135587 ## pinot-broker/src/main/java/org/apache/pinot/broker/queryquota/HelixExternalViewBasedQueryQuotaManager.java: ## @@ -81,15 +81,32 @@ public class HelixExternalVie

Re: [PR] Replace fmpp-maven-plugin with fmpp Ant Task to avoid pulling the vulnerable log4j jars [pinot]

2024-10-20 Thread via GitHub
chrajeshbabu commented on PR #14015: URL: https://github.com/apache/pinot/pull/14015#issuecomment-2425656866 > > @chrajeshbabu Can you rebase this to the current master? The flaky test has been fixed in the master > > Will do in sometime @Jackie-Jiang . Thanks Rebased. -- Th

Re: [PR] Add support for application -level query quota. [pinot]

2024-10-20 Thread via GitHub
shounakmk219 commented on code in PR #14226: URL: https://github.com/apache/pinot/pull/14226#discussion_r1808118634 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotApplicationQuotaRestletResource.java: ## @@ -0,0 +1,163 @@ +/** + * Licensed to th

Re: [PR] Replace fmpp-maven-plugin with fmpp Ant Task to avoid pulling the vulnerable log4j jars [pinot]

2024-10-20 Thread via GitHub
chrajeshbabu commented on PR #14015: URL: https://github.com/apache/pinot/pull/14015#issuecomment-2425275745 > @chrajeshbabu Can you rebase this to the current master? The flaky test has been fixed in the master Will do in sometime @Jackie-Jiang . Thanks -- This is an automated me

Re: [PR] Add support for application -level query quota. [pinot]

2024-10-20 Thread via GitHub
bziobrowski commented on code in PR #14226: URL: https://github.com/apache/pinot/pull/14226#discussion_r1807937871 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java: ## @@ -1664,6 +1679,18 @@ public void updateDatabaseConfig(

Re: [PR] Add support for application -level query quota. [pinot]

2024-10-20 Thread via GitHub
bziobrowski commented on code in PR #14226: URL: https://github.com/apache/pinot/pull/14226#discussion_r1807937451 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotApplicationQuotaRestletResource.java: ## @@ -0,0 +1,163 @@ +/** + * Licensed to the

Re: [PR] Add support for application -level query quota. [pinot]

2024-10-20 Thread via GitHub
bziobrowski commented on code in PR #14226: URL: https://github.com/apache/pinot/pull/14226#discussion_r1807937373 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotApplicationQuotaRestletResource.java: ## @@ -0,0 +1,163 @@ +/** + * Licensed to the

Re: [PR] Add support for application -level query quota. [pinot]

2024-10-20 Thread via GitHub
bziobrowski commented on code in PR #14226: URL: https://github.com/apache/pinot/pull/14226#discussion_r1807937143 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java: ## @@ -308,6 +308,16 @@ protected BrokerResponse hand

Re: [PR] Test Cases for JMX -> Prom Exporter Regexps [pinot]

2024-10-20 Thread via GitHub
suddendust commented on code in PR #14155: URL: https://github.com/apache/pinot/pull/14155#discussion_r1807934821 ## pinot-common/src/test/java/org/apache/pinot/common/metrics/BrokerJMXToPromMetricsTest.java: ## @@ -0,0 +1,162 @@ +/** + * Licensed to the Apache Software Foundati

Re: [I] Support maxNumRowsPerTask in RealtimeToOfflineSegmentsTask [pinot]

2024-10-20 Thread via GitHub
pratikpugalia commented on issue #12857: URL: https://github.com/apache/pinot/issues/12857#issuecomment-2425196727 Hey @swaminathanmanish No worries, I'll look at other issues I could possibly pickup! -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [WIP] Support preceding and following in WINDOW [pinot]

2024-10-20 Thread via GitHub
Jackie-Jiang closed pull request #14233: [WIP] Support preceding and following in WINDOW URL: https://github.com/apache/pinot/pull/14233 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Replace fmpp-maven-plugin with fmpp Ant Task to avoid pulling the vulnerable log4j jars [pinot]

2024-10-20 Thread via GitHub
Jackie-Jiang commented on PR #14015: URL: https://github.com/apache/pinot/pull/14015#issuecomment-2425167521 @chrajeshbabu Can you rebase this to the current master? The flaky test has been fixed in the master -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Test Cases for JMX -> Prom Exporter Regexps [pinot]

2024-10-20 Thread via GitHub
soumitra-st commented on code in PR #14155: URL: https://github.com/apache/pinot/pull/14155#discussion_r1807914546 ## pinot-common/src/test/java/org/apache/pinot/common/metrics/BrokerJMXToPromMetricsTest.java: ## @@ -0,0 +1,162 @@ +/** + * Licensed to the Apache Software Foundat

Re: [PR] Test Cases for JMX -> Prom Exporter Regexps [pinot]

2024-10-20 Thread via GitHub
suddendust commented on code in PR #14155: URL: https://github.com/apache/pinot/pull/14155#discussion_r1807896168 ## pinot-common/src/test/java/org/apache/pinot/common/metrics/BrokerJMXToPromMetricsTest.java: ## @@ -0,0 +1,162 @@ +/** + * Licensed to the Apache Software Foundati

Re: [PR] Test Cases for JMX -> Prom Exporter Regexps [pinot]

2024-10-20 Thread via GitHub
suddendust commented on code in PR #14155: URL: https://github.com/apache/pinot/pull/14155#discussion_r1807900879 ## pinot-common/src/test/java/org/apache/pinot/common/metrics/BrokerJMXToPromMetricsTest.java: ## @@ -0,0 +1,162 @@ +/** + * Licensed to the Apache Software Foundati

Re: [PR] Test Cases for JMX -> Prom Exporter Regexps [pinot]

2024-10-20 Thread via GitHub
suddendust commented on code in PR #14155: URL: https://github.com/apache/pinot/pull/14155#discussion_r1807896304 ## pinot-common/src/test/java/org/apache/pinot/common/metrics/PinotJMXToPromMetricsTest.java: ## @@ -0,0 +1,379 @@ +/** + * Licensed to the Apache Software Foundatio

Re: [PR] Test Cases for JMX -> Prom Exporter Regexps [pinot]

2024-10-20 Thread via GitHub
suddendust commented on code in PR #14155: URL: https://github.com/apache/pinot/pull/14155#discussion_r1807896239 ## pinot-common/src/test/java/org/apache/pinot/common/metrics/BrokerJMXToPromMetricsTest.java: ## @@ -0,0 +1,162 @@ +/** + * Licensed to the Apache Software Foundati

Re: [PR] Test Cases for JMX -> Prom Exporter Regexps [pinot]

2024-10-20 Thread via GitHub
suddendust commented on code in PR #14155: URL: https://github.com/apache/pinot/pull/14155#discussion_r1807896271 ## pinot-common/src/test/java/org/apache/pinot/common/metrics/PinotJMXToPromMetricsTest.java: ## @@ -0,0 +1,379 @@ +/** + * Licensed to the Apache Software Foundatio

Re: [I] Support maxNumRowsPerTask in RealtimeToOfflineSegmentsTask [pinot]

2024-10-20 Thread via GitHub
swaminathanmanish commented on issue #12857: URL: https://github.com/apache/pinot/issues/12857#issuecomment-2425017231 @pratikpugalia - We have a slightly urgent ask to pick this up to address scaling issues in this task. Could I or someone from my team pick this up and you could pick somet

Re: [PR] Test Cases for JMX -> Prom Exporter Regexps [pinot]

2024-10-20 Thread via GitHub
suddendust commented on code in PR #14155: URL: https://github.com/apache/pinot/pull/14155#discussion_r1807763843 ## pinot-common/src/test/java/org/apache/pinot/common/metrics/PinotJMXToPromMetricsTest.java: ## @@ -0,0 +1,379 @@ +/** + * Licensed to the Apache Software Foundatio