(pinot) branch master updated: Add BETWEEN support to NumericalFilterOptimizer (#14163)

2024-10-10 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 782e769f6c Add BETWEEN support to NumericalFilter

Re: [PR] Add BETWEEN support to NumericalFilterOptimizer [pinot]

2024-10-10 Thread via GitHub
Jackie-Jiang merged PR #14163: URL: https://github.com/apache/pinot/pull/14163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Add a flexible json config way [pinot]

2024-10-10 Thread via GitHub
chenboat commented on code in PR #14200: URL: https://github.com/apache/pinot/pull/14200#discussion_r1796374936 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/JsonUtils.java: ## @@ -82,6 +84,7 @@ private JsonUtils() { // For querying public static final String WIL

Re: [PR] colocated-without-hints [pinot]

2024-10-10 Thread via GitHub
Jackie-Jiang commented on code in PR #13943: URL: https://github.com/apache/pinot/pull/13943#discussion_r1796257745 ## pinot-query-planner/src/main/java/org/apache/pinot/query/QueryEnvironment.java: ## @@ -398,8 +442,44 @@ private static HepProgram getTraitProgram() { }

Re: [PR] Upgrade Jersey from 2.42 to 2.45 [pinot]

2024-10-10 Thread via GitHub
Jackie-Jiang merged PR #14208: URL: https://github.com/apache/pinot/pull/14208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated: Upgrade Jersey from 2.42 to 2.45 (#14208)

2024-10-10 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 9d2cd3116a Upgrade Jersey from 2.42 to 2.45 (#142

Re: [PR] Extract common MV ser/de logic into ArraySerDeUtils [pinot]

2024-10-10 Thread via GitHub
codecov-commenter commented on PR #14209: URL: https://github.com/apache/pinot/pull/14209#issuecomment-2406253495 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14209?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Allows multiple requests per server per request ID [pinot]

2024-10-10 Thread via GitHub
egalpin commented on code in PR #13742: URL: https://github.com/apache/pinot/pull/13742#discussion_r1796224649 ## pinot-core/src/main/java/org/apache/pinot/core/transport/QueryResponse.java: ## @@ -49,12 +50,12 @@ enum Status { /** * Returns the current server responses w

Re: [PR] Allows multiple requests per server per request ID [pinot]

2024-10-10 Thread via GitHub
egalpin commented on code in PR #13742: URL: https://github.com/apache/pinot/pull/13742#discussion_r1796222438 ## pinot-core/src/main/java/org/apache/pinot/core/transport/QueryResponse.java: ## @@ -49,12 +50,12 @@ enum Status { /** * Returns the current server responses w

Re: [PR] Introduce raw fwd index version V5 containing implicit num doc length, improving space efficiency [pinot]

2024-10-10 Thread via GitHub
Jackie-Jiang commented on code in PR #14105: URL: https://github.com/apache/pinot/pull/14105#discussion_r1796219080 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/forward/ForwardIndexReaderFactory.java: ## @@ -106,6 +108,10 @@ public static For

[PR] Extract common MV ser/de logic into ArraySerDeUtils [pinot]

2024-10-10 Thread via GitHub
Jackie-Jiang opened a new pull request, #14209: URL: https://github.com/apache/pinot/pull/14209 Extract the common logic for MV ser/de in raw index writer/reader This can help simplify #14105 -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [I] Add documentation for `JSON_EXTRACT_INDEX` [pinot]

2024-10-10 Thread via GitHub
itschrispeck commented on issue #14202: URL: https://github.com/apache/pinot/issues/14202#issuecomment-2406056451 Yep, I think I owe some docs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Added http client connection reusable strategy [pinot]

2024-10-10 Thread via GitHub
Jackie-Jiang commented on PR #14191: URL: https://github.com/apache/pinot/pull/14191#issuecomment-2406043509 Thanks for debugging this! Can you elaborate more on the root cause? Since the bug was fixed in the new version, why would our test fail? Is there extra overhead if we do no

Re: [PR] Bump lucene.version from 9.11.1 to 9.12.0 [pinot]

2024-10-10 Thread via GitHub
abhioncbr commented on PR #14114: URL: https://github.com/apache/pinot/pull/14114#issuecomment-2406012737 > Seems `Lucene99Codec` is no longer available. @abhioncbr Do you want to help take a look? Sure let me have a look. Thanks -- This is an automated message from the Apache Git

Re: [PR] Upgrade Jersey from 2.42 to 2.45 [pinot]

2024-10-10 Thread via GitHub
codecov-commenter commented on PR #14208: URL: https://github.com/apache/pinot/pull/14208#issuecomment-2405899048 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14208?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Remove setters dependency of IndexLoadingConfig class in Test Classes [pinot]

2024-10-10 Thread via GitHub
Jackie-Jiang merged PR #14201: URL: https://github.com/apache/pinot/pull/14201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated: Remove setters dependency of IndexLoadingConfig class in Test Classes (#14201)

2024-10-10 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 9ef4beaee6 Remove setters dependency of IndexLoad

[PR] Upgrade Jersey from 2.42 to 2.45 [pinot]

2024-10-10 Thread via GitHub
Jackie-Jiang opened a new pull request, #14208: URL: https://github.com/apache/pinot/pull/14208 We are still on Jersey 2, so upgrade Jersey to the latest Jersey 2 version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

(pinot) branch dependabot/maven/com.yscope.clp-clp-ffi-0.4.6 deleted (was 54c771e806)

2024-10-10 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/com.yscope.clp-clp-ffi-0.4.6 in repository https://gitbox.apache.org/repos/asf/pinot.git was 54c771e806 Bump com.yscope.clp:clp-ffi from 0.4.5 to 0.4.6 The revisions that w

(pinot) branch master updated (9792dfb67f -> 5c42317df2)

2024-10-10 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 9792dfb67f Bump kotlin.stdlib.version from 2.0.20 to 2.0.21 (#14205) add 5c42317df2 Bump com.yscope.clp:clp-ffi fr

Re: [PR] Bump com.yscope.clp:clp-ffi from 0.4.5 to 0.4.6 [pinot]

2024-10-10 Thread via GitHub
Jackie-Jiang merged PR #14206: URL: https://github.com/apache/pinot/pull/14206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch dependabot/maven/kotlin.stdlib.version-2.0.21 deleted (was b79d0cf8de)

2024-10-10 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/kotlin.stdlib.version-2.0.21 in repository https://gitbox.apache.org/repos/asf/pinot.git was b79d0cf8de Bump kotlin.stdlib.version from 2.0.20 to 2.0.21 The revisions that

Re: [PR] Bump kotlin.stdlib.version from 2.0.20 to 2.0.21 [pinot]

2024-10-10 Thread via GitHub
Jackie-Jiang merged PR #14205: URL: https://github.com/apache/pinot/pull/14205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Bump jersey.version from 2.42 to 3.0.0 [pinot]

2024-10-10 Thread via GitHub
dependabot[bot] closed pull request #14204: Bump jersey.version from 2.42 to 3.0.0 URL: https://github.com/apache/pinot/pull/14204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

(pinot) branch master updated (81777709bc -> 9792dfb67f)

2024-10-10 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 8109bc Add NULLIF scalar function (#14203) add 9792dfb67f Bump kotlin.stdlib.version from 2.0.20 to 2.0.21 (#1

(pinot) branch dependabot/maven/jersey.version-3.0.0 deleted (was 293be785ae)

2024-10-10 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/jersey.version-3.0.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was 293be785ae Bump jersey.version from 2.42 to 3.0.0 The revisions that were on this b

Re: [PR] Bump jersey.version from 2.42 to 3.0.0 [pinot]

2024-10-10 Thread via GitHub
dependabot[bot] commented on PR #14204: URL: https://github.com/apache/pinot/pull/14204#issuecomment-2405810256 OK, I won't notify you about version 3.x.x again, unless you re-open this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Bump jersey.version from 2.42 to 3.0.0 [pinot]

2024-10-10 Thread via GitHub
Jackie-Jiang commented on PR #14204: URL: https://github.com/apache/pinot/pull/14204#issuecomment-2405810099 @dependabot ignore this major version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] Regression with NULLIF function in the multi-stage query engine [pinot]

2024-10-10 Thread via GitHub
yashmayya closed issue #14207: Regression with NULLIF function in the multi-stage query engine URL: https://github.com/apache/pinot/issues/14207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

(pinot) branch master updated (fbd3e708be -> 81777709bc)

2024-10-10 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from fbd3e708be Fix bug with server return final aggregation result when null handling is enabled (#14181) add 810

Re: [PR] Add NULLIF scalar function [pinot]

2024-10-10 Thread via GitHub
Jackie-Jiang merged PR #14203: URL: https://github.com/apache/pinot/pull/14203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Add NULLIF scalar function [pinot]

2024-10-10 Thread via GitHub
Jackie-Jiang commented on code in PR #14203: URL: https://github.com/apache/pinot/pull/14203#discussion_r1795830680 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ObjectFunctions.java: ## @@ -74,4 +74,14 @@ public static Object caseWhen(Object... objs) {

Re: [PR] Add NULLIF scalar function [pinot]

2024-10-10 Thread via GitHub
yashmayya commented on PR #14203: URL: https://github.com/apache/pinot/pull/14203#issuecomment-2405563949 Fixes https://github.com/apache/pinot/issues/14207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] [proposal] Reuse common expressions in a query [pinot]

2024-10-10 Thread via GitHub
ankitsultana commented on issue #14196: URL: https://github.com/apache/pinot/issues/14196#issuecomment-2405275848 @gortiz : can you enable comment access on the doc? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] colocated-without-hints [pinot]

2024-10-10 Thread via GitHub
gortiz commented on code in PR #13943: URL: https://github.com/apache/pinot/pull/13943#discussion_r1795376195 ## pinot-query-planner/pom.xml: ## @@ -49,6 +49,11 @@ org.codehaus.janino commons-compiler + + org.immutables + value Review Comment:

Re: [PR] colocated-without-hints [pinot]

2024-10-10 Thread via GitHub
gortiz commented on code in PR #13943: URL: https://github.com/apache/pinot/pull/13943#discussion_r1795374252 ## pinot-query-planner/src/main/java/org/apache/pinot/query/QueryEnvironment.java: ## @@ -398,8 +442,44 @@ private static HepProgram getTraitProgram() { } //

Re: [PR] colocated-without-hints [pinot]

2024-10-10 Thread via GitHub
gortiz commented on code in PR #13943: URL: https://github.com/apache/pinot/pull/13943#discussion_r1795372378 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ## @@ -343,6 +343,8 @@ public static class Broker { public static final String CONFIG_OF

Re: [PR] colocated-without-hints [pinot]

2024-10-10 Thread via GitHub
gortiz commented on code in PR #13943: URL: https://github.com/apache/pinot/pull/13943#discussion_r1795369685 ## pinot-query-planner/src/main/java/org/apache/pinot/query/QueryEnvironment.java: ## @@ -100,26 +111,58 @@ public class QueryEnvironment { private final FrameworkCon

Re: [PR] colocated-without-hints [pinot]

2024-10-10 Thread via GitHub
gortiz commented on code in PR #13943: URL: https://github.com/apache/pinot/pull/13943#discussion_r1795331857 ## pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotImplicitTableHintRule.java: ## @@ -0,0 +1,283 @@ +/** + * Licensed to the Apache Software Fo

[PR] Bump com.yscope.clp:clp-ffi from 0.4.5 to 0.4.6 [pinot]

2024-10-10 Thread via GitHub
dependabot[bot] opened a new pull request, #14206: URL: https://github.com/apache/pinot/pull/14206 Bumps [com.yscope.clp:clp-ffi](https://github.com/y-scope/clp-ffi-java) from 0.4.5 to 0.4.6. Commits See full diff in https://github.com/y-scope/clp-ffi-java/commits/v0.4.6";>comp

(pinot) branch dependabot/maven/com.yscope.clp-clp-ffi-0.4.6 created (now 54c771e806)

2024-10-10 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.yscope.clp-clp-ffi-0.4.6 in repository https://gitbox.apache.org/repos/asf/pinot.git at 54c771e806 Bump com.yscope.clp:clp-ffi from 0.4.5 to 0.4.6 No new revision

(pinot) branch dependabot/maven/kotlin.stdlib.version-2.0.21 created (now b79d0cf8de)

2024-10-10 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/kotlin.stdlib.version-2.0.21 in repository https://gitbox.apache.org/repos/asf/pinot.git at b79d0cf8de Bump kotlin.stdlib.version from 2.0.20 to 2.0.21 No new revisio

[PR] Bump kotlin.stdlib.version from 2.0.20 to 2.0.21 [pinot]

2024-10-10 Thread via GitHub
dependabot[bot] opened a new pull request, #14205: URL: https://github.com/apache/pinot/pull/14205 Bumps `kotlin.stdlib.version` from 2.0.20 to 2.0.21. Updates `org.jetbrains.kotlin:kotlin-stdlib-jdk8` from 2.0.20 to 2.0.21 Release notes Sourced from https://github.com/JetBrains/

(pinot) branch dependabot/maven/jersey.version-3.0.0 created (now 293be785ae)

2024-10-10 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/jersey.version-3.0.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at 293be785ae Bump jersey.version from 2.42 to 3.0.0 No new revisions were added by th

[PR] Bump jersey.version from 2.42 to 3.0.0 [pinot]

2024-10-10 Thread via GitHub
dependabot[bot] opened a new pull request, #14204: URL: https://github.com/apache/pinot/pull/14204 Bumps `jersey.version` from 2.42 to 3.0.0. Updates `org.glassfish.jersey.core:jersey-server` from 2.42 to 3.0.0 Updates `org.glassfish.jersey.core:jersey-client` from 2.42 to 3.0.0

Re: [PR] Use fixed thread pool in Pinot Controller [pinot]

2024-10-10 Thread via GitHub
shounakmk219 commented on code in PR #14159: URL: https://github.com/apache/pinot/pull/14159#discussion_r1795034033 ## pinot-controller/src/main/java/org/apache/pinot/controller/BaseControllerStarter.java: ## @@ -252,10 +253,13 @@ public void init(PinotConfiguration pinotConfigu

Re: [PR] Add NULLIF scalar function [pinot]

2024-10-10 Thread via GitHub
codecov-commenter commented on PR #14203: URL: https://github.com/apache/pinot/pull/14203#issuecomment-2404284715 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14203?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u