Re: [PR] [Draft] Update cardinality to container size [pinot]

2024-09-20 Thread via GitHub
codecov-commenter commented on PR #14049: URL: https://github.com/apache/pinot/pull/14049#issuecomment-2365033380 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14049?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] [Draft] Update cardinality to container size [pinot]

2024-09-20 Thread via GitHub
anandheritage closed pull request #14049: [Draft]Update cardinality to container size URL: https://github.com/apache/pinot/pull/14049 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] update the sorting logic from cardinality to container count [pinot]

2024-09-20 Thread via GitHub
anandheritage opened a new pull request, #14050: URL: https://github.com/apache/pinot/pull/14050 Instructions: 1. The PR has to be tagged with at least one of the following labels (*): 1. `feature` 2. `bugfix` 3. `performance` 4. `ui` 5. `backward-incompat`

[PR] [Draft] Update cardinality to container size [pinot]

2024-09-20 Thread via GitHub
anandheritage opened a new pull request, #14049: URL: https://github.com/apache/pinot/pull/14049 Instructions: 1. The PR has to be tagged with at least one of the following labels (*): 1. `feature` 2. `bugfix` 3. `performance` 4. `ui` 5. `backward-incompat`

Re: [PR] Make Custom Config Optional [pinot]

2024-09-20 Thread via GitHub
ashishjayamohan commented on PR #14014: URL: https://github.com/apache/pinot/pull/14014#issuecomment-2364701411 That makes sense. I've switched the custom config key back to "metadata." -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

(pinot) branch dependabot/maven/org.apache.httpcomponents.client5-httpclient5-5.4 updated (fe49d921b8 -> 24b61aa8b3)

2024-09-20 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.apache.httpcomponents.client5-httpclient5-5.4 in repository https://gitbox.apache.org/repos/asf/pinot.git discard fe49d921b8 Bump org.apache.httpcomponents.client5:http

Re: [PR] Bump org.apache.httpcomponents.client5:httpclient5 from 5.3.1 to 5.4 [pinot]

2024-09-20 Thread via GitHub
Jackie-Jiang commented on PR #14045: URL: https://github.com/apache/pinot/pull/14045#issuecomment-2364688029 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

(pinot) branch dependabot/maven/com.adobe.testing-s3mock-testcontainers-3.10.1 deleted (was 654e751d1a)

2024-09-20 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.adobe.testing-s3mock-testcontainers-3.10.1 in repository https://gitbox.apache.org/repos/asf/pinot.git was 654e751d1a Bump com.adobe.testing:s3mock-testcontainers f

Re: [PR] Bump com.adobe.testing:s3mock-testcontainers from 2.17.0 to 3.10.1 [pinot]

2024-09-20 Thread via GitHub
Jackie-Jiang closed pull request #14047: Bump com.adobe.testing:s3mock-testcontainers from 2.17.0 to 3.10.1 URL: https://github.com/apache/pinot/pull/14047 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Adding an `Open in DevZero` button [pinot]

2024-09-20 Thread via GitHub
Jackie-Jiang closed pull request #14041: Adding an `Open in DevZero` button URL: https://github.com/apache/pinot/pull/14041 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] Make Custom Config Optional [pinot]

2024-09-20 Thread via GitHub
jackjlli commented on PR #14014: URL: https://github.com/apache/pinot/pull/14014#issuecomment-2364669912 We couldn't afford to rename the `metadata` field to `customConfig` as that will break all the existing logic regardless of internal one and OSS. I'd prefer just keeping the field name t

(pinot) branch dependabot/maven/com.google.protobuf-protobuf-bom-4.28.2 deleted (was 6ecf31c6f3)

2024-09-20 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.google.protobuf-protobuf-bom-4.28.2 in repository https://gitbox.apache.org/repos/asf/pinot.git was 6ecf31c6f3 Bump com.google.protobuf:protobuf-bom from 3.25.4 to

Re: [PR] Bump com.adobe.testing:s3mock-testcontainers from 2.17.0 to 3.10.1 [pinot]

2024-09-20 Thread via GitHub
dependabot[bot] commented on PR #14047: URL: https://github.com/apache/pinot/pull/14047#issuecomment-2364669836 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

Re: [PR] Bump com.google.protobuf:protobuf-bom from 3.25.4 to 4.28.2 [pinot]

2024-09-20 Thread via GitHub
dependabot[bot] commented on PR #14035: URL: https://github.com/apache/pinot/pull/14035#issuecomment-2364669937 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

Re: [PR] Bump com.google.protobuf:protobuf-bom from 3.25.4 to 4.28.2 [pinot]

2024-09-20 Thread via GitHub
Jackie-Jiang closed pull request #14035: Bump com.google.protobuf:protobuf-bom from 3.25.4 to 4.28.2 URL: https://github.com/apache/pinot/pull/14035 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] Make Custom Config Optional [pinot]

2024-09-20 Thread via GitHub
Jackie-Jiang commented on PR #14014: URL: https://github.com/apache/pinot/pull/14014#issuecomment-2364664801 The main concern is the change of the key from "metadata" to "customConfig". This can prevent old table config being properly loaded, and is the reason why all backward compatibility

Re: [PR] Improve database handling in multi-stage engine [pinot]

2024-09-20 Thread via GitHub
Jackie-Jiang commented on PR #14040: URL: https://github.com/apache/pinot/pull/14040#issuecomment-2364628497 Seems the test is added in #12591, and I believe the correct syntax should be `SELECT * FROM default."tbl-escape-naming"`. Modified the test accordingly -- This is an automated mes

(pinot) branch master updated: Updated stream Ingestion Readme (#14043)

2024-09-20 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 345896b7d1 Updated stream Ingestion Readme (#1404

Re: [PR] Updated stream Ingestion Readme [pinot]

2024-09-20 Thread via GitHub
Jackie-Jiang merged PR #14043: URL: https://github.com/apache/pinot/pull/14043 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Bump commons-io:commons-io from 2.11.0 to 2.17.0 [pinot]

2024-09-20 Thread via GitHub
Jackie-Jiang closed pull request #14046: Bump commons-io:commons-io from 2.11.0 to 2.17.0 URL: https://github.com/apache/pinot/pull/14046 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

(pinot) branch dependabot/maven/commons-io-commons-io-2.17.0 deleted (was 1cee5299bf)

2024-09-20 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/commons-io-commons-io-2.17.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was 1cee5299bf Bump commons-io:commons-io from 2.11.0 to 2.17.0 The revisions

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.28.5 deleted (was a39819a4e9)

2024-09-20 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.28.5 in repository https://gitbox.apache.org/repos/asf/pinot.git was a39819a4e9 Bump software.amazon.awssdk:bom from 2.28.4 to 2.28.5 The revi

Re: [PR] Bump commons-io:commons-io from 2.11.0 to 2.17.0 [pinot]

2024-09-20 Thread via GitHub
dependabot[bot] commented on PR #14046: URL: https://github.com/apache/pinot/pull/14046#issuecomment-2364514973 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

(pinot) branch master updated: Bump software.amazon.awssdk:bom from 2.28.4 to 2.28.5 (#14044)

2024-09-20 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 5673f941fe Bump software.amazon.awssdk:bom from 2

Re: [PR] Bump software.amazon.awssdk:bom from 2.28.4 to 2.28.5 [pinot]

2024-09-20 Thread via GitHub
Jackie-Jiang merged PR #14044: URL: https://github.com/apache/pinot/pull/14044 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] [WIP] Part-4: Working E2E Quickstart for Time Series Engine [pinot]

2024-09-20 Thread via GitHub
codecov-commenter commented on PR #14048: URL: https://github.com/apache/pinot/pull/14048#issuecomment-2364210654 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14048?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] [WIP] Part-4: Working E2E Quickstart for Time Series Engine [pinot]

2024-09-20 Thread via GitHub
ankitsultana opened a new pull request, #14048: URL: https://github.com/apache/pinot/pull/14048 TBD -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Make Custom Config Optional [pinot]

2024-09-20 Thread via GitHub
ashishjayamohan commented on PR #14014: URL: https://github.com/apache/pinot/pull/14014#issuecomment-2364041684 Honestly, the rationale is pretty simplistic - it just seems like excess overhead if not needed. Additionally, making it optional (and please correct me on this if I'm wrong) shou

Re: [PR] Fixing the vulnerabilities of amazon corretto pinot-base-runtime docker image. [pinot]

2024-09-20 Thread via GitHub
abhioncbr commented on PR #14042: URL: https://github.com/apache/pinot/pull/14042#issuecomment-2363853902 > > What I don't get is why we need to remove the Amazon Corretto support. Right now we publish three different flavors (corretto, microsoft and openjdk). We can just create a new o

Re: [PR] Improve database handling in multi-stage engine [pinot]

2024-09-20 Thread via GitHub
gortiz commented on PR #14040: URL: https://github.com/apache/pinot/pull/14040#issuecomment-2363838694 I think @shounakmk219 is more informed to answer that question. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Improvements to OOM protection for Multi-Stage Engine [pinot]

2024-09-20 Thread via GitHub
gortiz merged PR #13955: URL: https://github.com/apache/pinot/pull/13955 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apach

(pinot) branch master updated: Improvements to OOM protection for Multi-Stage Engine (#13955)

2024-09-20 Thread gortiz
This is an automated email from the ASF dual-hosted git repository. gortiz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 75b7b6fcbf Improvements to OOM protection for Mul

(pinot) branch master updated (3aeaee9835 -> f976cda57c)

2024-09-20 Thread gortiz
This is an automated email from the ASF dual-hosted git repository. gortiz pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 3aeaee9835 Bump com.google.cloud:libraries-bom from 26.46.0 to 26.47.0 (#14034) add f976cda57c remove parent rela

Re: [PR] remove parent relative path, which was incorrect [pinot]

2024-09-20 Thread via GitHub
gortiz commented on PR #14037: URL: https://github.com/apache/pinot/pull/14037#issuecomment-2363644952 > There is one more in pinot-timeseries-spi as ../../pom.xml. Is that correct? It looks odd. I don't know why @ankitsultana used that reference. Anyway, that value may be semantical

Re: [PR] remove parent relative path, which was incorrect [pinot]

2024-09-20 Thread via GitHub
gortiz merged PR #14037: URL: https://github.com/apache/pinot/pull/14037 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apach

Re: [PR] Fixing the vulnerabilities of amazon corretto pinot-base-runtime docker image. [pinot]

2024-09-20 Thread via GitHub
gortiz commented on PR #14042: URL: https://github.com/apache/pinot/pull/14042#issuecomment-2363636538 Personally, I don't like Alpine images given the docker image size is not that important* and the fact that Alpine uses musl instead of glib may have unexpected side effects. But I underst

(pinot) branch dependabot/maven/com.adobe.testing-s3mock-testcontainers-3.10.1 created (now 654e751d1a)

2024-09-20 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.adobe.testing-s3mock-testcontainers-3.10.1 in repository https://gitbox.apache.org/repos/asf/pinot.git at 654e751d1a Bump com.adobe.testing:s3mock-testcontainers f

[PR] Bump com.adobe.testing:s3mock-testcontainers from 2.17.0 to 3.10.1 [pinot]

2024-09-20 Thread via GitHub
dependabot[bot] opened a new pull request, #14047: URL: https://github.com/apache/pinot/pull/14047 Bumps com.adobe.testing:s3mock-testcontainers from 2.17.0 to 3.10.1. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-

(pinot) branch dependabot/maven/commons-io-commons-io-2.17.0 created (now 1cee5299bf)

2024-09-20 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/commons-io-commons-io-2.17.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at 1cee5299bf Bump commons-io:commons-io from 2.11.0 to 2.17.0 No new revisio

[PR] Bump commons-io:commons-io from 2.11.0 to 2.17.0 [pinot]

2024-09-20 Thread via GitHub
dependabot[bot] opened a new pull request, #14046: URL: https://github.com/apache/pinot/pull/14046 Bumps commons-io:commons-io from 2.11.0 to 2.17.0. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=commons-io:co

[PR] Bump org.apache.httpcomponents.client5:httpclient5 from 5.3.1 to 5.4 [pinot]

2024-09-20 Thread via GitHub
dependabot[bot] opened a new pull request, #14045: URL: https://github.com/apache/pinot/pull/14045 Bumps [org.apache.httpcomponents.client5:httpclient5](https://github.com/apache/httpcomponents-client) from 5.3.1 to 5.4. Changelog Sourced from https://github.com/apache/httpcompone

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.28.5 created (now a39819a4e9)

2024-09-20 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.28.5 in repository https://gitbox.apache.org/repos/asf/pinot.git at a39819a4e9 Bump software.amazon.awssdk:bom from 2.28.4 to 2.28.5 No n

(pinot) branch dependabot/maven/org.apache.httpcomponents.client5-httpclient5-5.4 created (now fe49d921b8)

2024-09-20 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.apache.httpcomponents.client5-httpclient5-5.4 in repository https://gitbox.apache.org/repos/asf/pinot.git at fe49d921b8 Bump org.apache.httpcomponents.client5:http

[PR] Bump software.amazon.awssdk:bom from 2.28.4 to 2.28.5 [pinot]

2024-09-20 Thread via GitHub
dependabot[bot] opened a new pull request, #14044: URL: https://github.com/apache/pinot/pull/14044 Bumps software.amazon.awssdk:bom from 2.28.4 to 2.28.5. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=software

[PR] Updated stream Ingestion Readme [pinot]

2024-09-20 Thread via GitHub
abhioncbr opened a new pull request, #14043: URL: https://github.com/apache/pinot/pull/14043 Minor PR to update the outdated Stream Ingestion Readme. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[PR] Fixing the vulnerabilities of amazon corretto pinot-base-runtime docker image. [pinot]

2024-09-20 Thread via GitHub
abhioncbr opened a new pull request, #14042: URL: https://github.com/apache/pinot/pull/14042 As per https://github.com/apache/pinot/issues/13461, This PR tries to fix the vulnerabilities of the Amazon corretto jdk image. Here are some details - There are 0 vulnerabilities in the Amazon co