Re: [PR] TLS Configuration Support for QueryServer and Dispatch Client [pinot]

2024-08-24 Thread via GitHub
anandheritage commented on code in PR #13645: URL: https://github.com/apache/pinot/pull/13645#discussion_r1730226104 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/service/dispatch/DispatchClient.java: ## @@ -58,4 +90,26 @@ public void cancel(long requestId) {

Re: [PR] TLS Configuration Support for QueryServer and Dispatch Client [pinot]

2024-08-24 Thread via GitHub
anandheritage commented on code in PR #13645: URL: https://github.com/apache/pinot/pull/13645#discussion_r1730226104 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/service/dispatch/DispatchClient.java: ## @@ -58,4 +90,26 @@ public void cancel(long requestId) {

Re: [PR] TLS Configuration Support for QueryServer and Dispatch Client [pinot]

2024-08-24 Thread via GitHub
anandheritage commented on code in PR #13645: URL: https://github.com/apache/pinot/pull/13645#discussion_r1730225172 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/service/server/QueryServer.java: ## @@ -71,7 +88,17 @@ public void start() { LOGGER.info("Startin

Re: [PR] TLS Configuration Support for QueryServer and Dispatch Client [pinot]

2024-08-24 Thread via GitHub
anandheritage commented on code in PR #13645: URL: https://github.com/apache/pinot/pull/13645#discussion_r1730225393 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/service/dispatch/DispatchClient.java: ## @@ -36,12 +52,28 @@ */ class DispatchClient { private s

Re: [PR] TLS Configuration Support for QueryServer and Dispatch Client [pinot]

2024-08-24 Thread via GitHub
anandheritage commented on code in PR #13645: URL: https://github.com/apache/pinot/pull/13645#discussion_r1730224851 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/channel/GrpcMailboxServer.java: ## @@ -37,17 +54,33 @@ * send by the sender of the sender/re

Re: [PR] Avro version upgrade with primitive array handling. [pinot]

2024-08-24 Thread via GitHub
abhioncbr commented on PR #13823: URL: https://github.com/apache/pinot/pull/13823#issuecomment-2308604701 > Thanks for digging into the problem and finding the root cause! I think `PrimitiveArrays` are introduced to reduce memory usage, so I'd prefer to keep that and handle the new types wi

Re: [PR] add metric for time retention failing due to end time [pinot]

2024-08-24 Thread via GitHub
jadami10 commented on code in PR #13879: URL: https://github.com/apache/pinot/pull/13879#discussion_r1730163813 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -1505,7 +1505,7 @@ public void uploadToDee

Re: [I] [Proposal] Generic Time Series Engine in Pinot [pinot]

2024-08-24 Thread via GitHub
ankitsultana commented on issue #13760: URL: https://github.com/apache/pinot/issues/13760#issuecomment-2308483029 @siddharthteotia done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [I] [Proposal] Generic Time Series Engine in Pinot [pinot]

2024-08-24 Thread via GitHub
siddharthteotia commented on issue #13760: URL: https://github.com/apache/pinot/issues/13760#issuecomment-2308455739 @ankitsultana - can you open the design doc for comment access please ? -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Binary Workload Scheduler for constrained execution of a set of queries [pinot]

2024-08-24 Thread via GitHub
siddharthteotia commented on PR #13847: URL: https://github.com/apache/pinot/pull/13847#issuecomment-2308455105 @vvivekiyer - please add user docs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

(pinot) branch master updated: Binary Workload Scheduler for constrained execution of a set of queries (#13847)

2024-08-24 Thread siddteotia
This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 3a75d4abb2 Binary Workload Scheduler for cons

Re: [PR] Binary Workload Scheduler for constrained execution of a set of queries [pinot]

2024-08-24 Thread via GitHub
siddharthteotia merged PR #13847: URL: https://github.com/apache/pinot/pull/13847 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pi