[PR] Allow override of StreamConfig property server upload to deepstore [pinot]

2024-08-18 Thread via GitHub
raghavyadav01 opened a new pull request, #13836: URL: https://github.com/apache/pinot/pull/13836 Currently default value of StreamConfig property "defaultServerUploadToDeepStore" is not configurable and can only be changed through table stream config. The change allow the default value

Re: [PR] Return correct dataschema for empty results [pinot]

2024-08-18 Thread via GitHub
jadami10 commented on PR #13831: URL: https://github.com/apache/pinot/pull/13831#issuecomment-2295383548 +1 to jackie's idea of leaving the column types as TODOs. We've noticed internally that the bigger issue is we're strictly missing the result table. We don't even use the column t

Re: [PR] Return correct dataschema for empty results [pinot]

2024-08-18 Thread via GitHub
Jackie-Jiang commented on PR #13831: URL: https://github.com/apache/pinot/pull/13831#issuecomment-2295367180 1 is not always possible in the following cases: - There is no segment at all - There are only empty segments I prefer 2 because we should be able to derive the data type

Re: [PR] intellij-language-annotation: add annotation on tests [pinot]

2024-08-18 Thread via GitHub
Jackie-Jiang merged PR #13793: URL: https://github.com/apache/pinot/pull/13793 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated (cc14cbe29c -> 186115880e)

2024-08-18 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from cc14cbe29c Improve logging in SegmentPreProcessor::needProcess (#13700) add 186115880e intellij-language-annotatio

(pinot) branch master updated (426160a206 -> cc14cbe29c)

2024-08-18 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 426160a206 fixing TLS configuration for http clients (#13477) add cc14cbe29c Improve logging in SegmentPreProcesso

Re: [PR] Improve logging in SegmentPreProcessor::needProcess [pinot]

2024-08-18 Thread via GitHub
Jackie-Jiang merged PR #13700: URL: https://github.com/apache/pinot/pull/13700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated (0333fe6b8c -> 426160a206)

2024-08-18 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 0333fe6b8c Reduce shading (#13834) add 426160a206 fixing TLS configuration for http clients (#13477) No new revis

Re: [PR] fixing TLS configuration for http clients [pinot]

2024-08-18 Thread via GitHub
Jackie-Jiang merged PR #13477: URL: https://github.com/apache/pinot/pull/13477 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Add support for configuring aggregation function parameters in the star-tree index [pinot]

2024-08-18 Thread via GitHub
yashmayya commented on code in PR #13835: URL: https://github.com/apache/pinot/pull/13835#discussion_r1720962052 ## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/AggregationFunctionType.java: ## @@ -344,6 +346,55 @@ public static AggregationFunctionType getAggreg

Re: [PR] Add support for configuring aggregation function parameters in the star-tree index [pinot]

2024-08-18 Thread via GitHub
yashmayya commented on code in PR #13835: URL: https://github.com/apache/pinot/pull/13835#discussion_r1720966644 ## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/startree/AggregationFunctionColumn.java: ## @@ -127,9 +149,14 @@ public boolean equals(Object ob

Re: [PR] Add support for configuring aggregation function parameters in the star-tree index [pinot]

2024-08-18 Thread via GitHub
yashmayya commented on code in PR #13835: URL: https://github.com/apache/pinot/pull/13835#discussion_r1720962052 ## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/AggregationFunctionType.java: ## @@ -344,6 +346,55 @@ public static AggregationFunctionType getAggreg

Re: [PR] Add support for configuring aggregation function parameters in the star-tree index [pinot]

2024-08-18 Thread via GitHub
codecov-commenter commented on PR #13835: URL: https://github.com/apache/pinot/pull/13835#issuecomment-2295166510 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13835?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

(pinot) branch master updated (376970106a -> 0333fe6b8c)

2024-08-18 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 376970106a Fix bugs in DynamicBrokerSelector (#13816) add 0333fe6b8c Reduce shading (#13834) No new revisions we

Re: [PR] Reduce shading [pinot]

2024-08-18 Thread via GitHub
xiangfu0 merged PR #13834: URL: https://github.com/apache/pinot/pull/13834 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

[PR] Add support for configuring aggregation function parameters in the star-tree index [pinot]

2024-08-18 Thread via GitHub
yashmayya opened a new pull request, #13835: URL: https://github.com/apache/pinot/pull/13835 - Currently, the star-tree index doesn’t support configurable inputs for aggregation functions. - Taking the [DISTINCTCOUNTHLL](https://docs.pinot.apache.org/configuration-reference/functions/dis