Re: [PR] Database query quota [pinot]

2024-08-01 Thread via GitHub
shounakmk219 commented on code in PR #13544: URL: https://github.com/apache/pinot/pull/13544#discussion_r1701143812 ## pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BrokerUserDefinedMessageHandlerFactory.java: ## @@ -129,6 +136,32 @@ public void onError(Excepti

Re: [PR] Database query quota [pinot]

2024-08-01 Thread via GitHub
shounakmk219 commented on code in PR #13544: URL: https://github.com/apache/pinot/pull/13544#discussion_r1701133130 ## pinot-broker/src/main/java/org/apache/pinot/broker/queryquota/HelixExternalViewBasedQueryQuotaManager.java: ## @@ -230,6 +253,114 @@ private void createOrUpdate

Re: [PR] Database query quota [pinot]

2024-08-01 Thread via GitHub
shounakmk219 commented on code in PR #13544: URL: https://github.com/apache/pinot/pull/13544#discussion_r1701123366 ## pinot-broker/src/main/java/org/apache/pinot/broker/queryquota/HelixExternalViewBasedQueryQuotaManager.java: ## @@ -230,6 +253,114 @@ private void createOrUpdate

Re: [PR] Update to latest version of clp-ffi that has support for Linux and macOS ARM platforms. [pinot]

2024-08-01 Thread via GitHub
kirkrodrigues commented on PR #13687: URL: https://github.com/apache/pinot/pull/13687#issuecomment-2264367874 > After https://github.com/apache/pinot/pull/13648, these tests should be now skipped by default when being executed on aarch64. Have you verify they have being executed? Yep

Re: [PR] Acquire a lock before updating the table lineage record [pinot]

2024-08-01 Thread via GitHub
swaminathanmanish commented on code in PR #13735: URL: https://github.com/apache/pinot/pull/13735#discussion_r1701086173 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java: ## @@ -3476,160 +3476,161 @@ public String startRepla

(pinot) branch master updated: [Feature] Support configurable Lucene analyzer with args and configurable query parser (#13003)

2024-08-01 Thread tingchen
This is an automated email from the ASF dual-hosted git repository. tingchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new b657699b7c [Feature] Support configurable Lucen

Re: [PR] [Feature] Support configurable Lucene analyzer with args and configurable query parser [pinot]

2024-08-01 Thread via GitHub
chenboat merged PR #13003: URL: https://github.com/apache/pinot/pull/13003 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

Re: [PR] Acquire a lock before updating the table lineage record [pinot]

2024-08-01 Thread via GitHub
codecov-commenter commented on PR #13735: URL: https://github.com/apache/pinot/pull/13735#issuecomment-2264255812 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13735?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Ensure upsert deletion consistency when enabled with compaction flow [pinot]

2024-08-01 Thread via GitHub
klsince commented on code in PR #13347: URL: https://github.com/apache/pinot/pull/13347#discussion_r1700864392 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/TableUpsertMetadataManagerFactory.java: ## @@ -29,16 +29,15 @@ public class TableUpsertM

Re: [PR] Database query quota [pinot]

2024-08-01 Thread via GitHub
klsince commented on code in PR #13544: URL: https://github.com/apache/pinot/pull/13544#discussion_r1700630267 ## pinot-broker/src/main/java/org/apache/pinot/broker/queryquota/HelixExternalViewBasedQueryQuotaManager.java: ## @@ -230,6 +253,114 @@ private void createOrUpdateRateL

Re: [PR] Fix potential int overflow issue for memory allocation of indices in segment-local module [pinot]

2024-08-01 Thread via GitHub
sajjad-moradi commented on code in PR #13717: URL: https://github.com/apache/pinot/pull/13717#discussion_r1700649646 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/forward/FixedByteSVMutableForwardIndex.java: ## @@ -81,7 +81,10 @@ public FixedB

[PR] Multi stage explain [pinot]

2024-08-01 Thread via GitHub
gortiz opened a new pull request, #13733: URL: https://github.com/apache/pinot/pull/13733 This PR introduces a new way to explain multi-stage queries in Pinot. The main goal is to provide a more detailed explanation of the query execution plan, including information about the physical

Re: [PR] Fail multi-stage client queries in the broker if multi-stage engine is disabled [pinot]

2024-08-01 Thread via GitHub
codecov-commenter commented on PR #13732: URL: https://github.com/apache/pinot/pull/13732#issuecomment-2263036857 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13732?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Fail multi-stage client queries in the broker if multi-stage engine is disabled [pinot]

2024-08-01 Thread via GitHub
yashmayya opened a new pull request, #13732: URL: https://github.com/apache/pinot/pull/13732 - Users can use the multi-stage query engine via query options (https://docs.pinot.apache.org/developers/advanced/v2-multi-stage-query-engine) or the (currently undocumented) broker API endpoints `G

Re: [I] MinionTenant as a table config [pinot]

2024-08-01 Thread via GitHub
tibrewalpratik17 commented on issue #12698: URL: https://github.com/apache/pinot/issues/12698#issuecomment-2262831322 @tarun11Mavani -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Bump org.testcontainers:pulsar from 1.20.0 to 1.20.1 [pinot]

2024-08-01 Thread via GitHub
dependabot[bot] opened a new pull request, #13731: URL: https://github.com/apache/pinot/pull/13731 Bumps [org.testcontainers:pulsar](https://github.com/testcontainers/testcontainers-java) from 1.20.0 to 1.20.1. Release notes Sourced from https://github.com/testcontainers/testconta

(pinot) branch dependabot/maven/org.testcontainers-pulsar-1.20.1 created (now 0698536e94)

2024-08-01 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.testcontainers-pulsar-1.20.1 in repository https://gitbox.apache.org/repos/asf/pinot.git at 0698536e94 Bump org.testcontainers:pulsar from 1.20.0 to 1.20.1 No new

(pinot) branch dependabot/maven/testcontainers.version-1.20.1 created (now c3859fedd9)

2024-08-01 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/testcontainers.version-1.20.1 in repository https://gitbox.apache.org/repos/asf/pinot.git at c3859fedd9 Bump testcontainers.version from 1.20.0 to 1.20.1 No new revis

[PR] Bump testcontainers.version from 1.20.0 to 1.20.1 [pinot]

2024-08-01 Thread via GitHub
dependabot[bot] opened a new pull request, #13730: URL: https://github.com/apache/pinot/pull/13730 Bumps `testcontainers.version` from 1.20.0 to 1.20.1. Updates `org.testcontainers:testcontainers` from 1.20.0 to 1.20.1 Release notes Sourced from https://github.com/testcontainers/

(pinot) branch dependabot/maven/com.google.protobuf-protobuf-bom-4.27.2 deleted (was f3745af142)

2024-08-01 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.google.protobuf-protobuf-bom-4.27.2 in repository https://gitbox.apache.org/repos/asf/pinot.git was f3745af142 Bump com.google.protobuf:protobuf-bom from 3.25.3 to

(pinot) branch dependabot/maven/com.google.protobuf-protobuf-bom-4.27.3 created (now 4ce7d37e51)

2024-08-01 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.google.protobuf-protobuf-bom-4.27.3 in repository https://gitbox.apache.org/repos/asf/pinot.git at 4ce7d37e51 Bump com.google.protobuf:protobuf-bom from 3.25.3 to

Re: [PR] Bump com.google.protobuf:protobuf-bom from 3.25.3 to 4.27.2 [pinot]

2024-08-01 Thread via GitHub
dependabot[bot] closed pull request #13485: Bump com.google.protobuf:protobuf-bom from 3.25.3 to 4.27.2 URL: https://github.com/apache/pinot/pull/13485 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] Bump com.google.protobuf:protobuf-bom from 3.25.3 to 4.27.2 [pinot]

2024-08-01 Thread via GitHub
dependabot[bot] commented on PR #13485: URL: https://github.com/apache/pinot/pull/13485#issuecomment-2262800377 Superseded by #13729. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Bump com.google.protobuf:protobuf-bom from 3.25.3 to 4.27.3 [pinot]

2024-08-01 Thread via GitHub
dependabot[bot] opened a new pull request, #13729: URL: https://github.com/apache/pinot/pull/13729 Bumps [com.google.protobuf:protobuf-bom](https://github.com/protocolbuffers/protobuf) from 3.25.3 to 4.27.3. Commits See full diff in https://github.com/protocolbuffers/protobuf/

[PR] Bump flink.version from 1.19.1 to 1.20.0 [pinot]

2024-08-01 Thread via GitHub
dependabot[bot] opened a new pull request, #13728: URL: https://github.com/apache/pinot/pull/13728 Bumps `flink.version` from 1.19.1 to 1.20.0. Updates `org.apache.flink:flink-clients` from 1.19.1 to 1.20.0 Commits https://github.com/apache/flink/commit/b1fe7b4099497f02b4658d

(pinot) branch dependabot/maven/flink.version-1.20.0 created (now ee3c1625eb)

2024-08-01 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/flink.version-1.20.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at ee3c1625eb Bump flink.version from 1.19.1 to 1.20.0 No new revisions were added by

Re: [PR] Split QueryDispatcher.submit into different methods to improve readability [pinot]

2024-08-01 Thread via GitHub
gortiz closed pull request #13724: Split QueryDispatcher.submit into different methods to improve readability URL: https://github.com/apache/pinot/pull/13724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t