Re: [PR] Return relevant error message when a v2 / multi-stage query is run on the v1 query engine [pinot]

2024-07-07 Thread via GitHub
codecov-commenter commented on PR #13554: URL: https://github.com/apache/pinot/pull/13554#issuecomment-2213165830 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13554?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Return relevant error message when a v2 / multi-stage query is run on the v1 query engine [pinot]

2024-07-07 Thread via GitHub
yashmayya opened a new pull request, #13554: URL: https://github.com/apache/pinot/pull/13554 - Currently, if a user tries to run a v2 query using the broker query API, the error returned is not very clear and new users won't really know what to do next. For instance, executing a query with

Re: [PR] Database query quota [pinot]

2024-07-07 Thread via GitHub
shounakmk219 commented on PR #13544: URL: https://github.com/apache/pinot/pull/13544#issuecomment-2213018935 @siddharthteotia > Does the DB level quota get even distributed across all tables in that DB ? The db level quota is separate from table level quota. Each table has it's separa

Re: [PR] return the current rebalance result if already done [pinot]

2024-07-07 Thread via GitHub
jadami10 commented on code in PR #13488: URL: https://github.com/apache/pinot/pull/13488#discussion_r1667762881 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java: ## @@ -677,14 +678,30 @@ public RebalanceResult rebalance(

Re: [PR] return the current rebalance result if already done [pinot]

2024-07-07 Thread via GitHub
jadami10 commented on PR #13488: URL: https://github.com/apache/pinot/pull/13488#issuecomment-2212572856 > In `waitForJobIdToPersist()`, we can consider passing in the future and stop waiting if the future is done. This way we can avoid unnecessary wait because job id will never show up

Re: [PR] return the current rebalance result if already done [pinot]

2024-07-07 Thread via GitHub
jadami10 commented on code in PR #13488: URL: https://github.com/apache/pinot/pull/13488#discussion_r1667762819 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java: ## @@ -677,14 +678,30 @@ public RebalanceResult rebalance(

Re: [PR] migrate from Apache HttpClient 4 to Apache HttpClient 5 [pinot]

2024-07-07 Thread via GitHub
sullis commented on PR #13222: URL: https://github.com/apache/pinot/pull/13222#issuecomment-2212529886 > Thanks for taking time to do this upgrade! Do we still need to keep httpclient 4 related dependencies? For now, I think we need to keep httpclient 4 in the project's root pom.xml

Re: [PR] Create pinot-docs repo to docs directory as a submodule [pinot]

2024-07-07 Thread via GitHub
codecov-commenter commented on PR #13553: URL: https://github.com/apache/pinot/pull/13553#issuecomment-2212511140 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13553?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] migrate from Apache HttpClient 4 to Apache HttpClient 5 [pinot]

2024-07-07 Thread via GitHub
sullis commented on code in PR #13222: URL: https://github.com/apache/pinot/pull/13222#discussion_r1667726958 ## pinot-plugins/pinot-environment/pinot-azure/src/main/java/org/apache/pinot/plugin/provider/AzureHttpRequestRetryStrategy.java: ## @@ -0,0 +1,30 @@ +/** + * Licensed t

Re: [PR] migrate from Apache HttpClient 4 to Apache HttpClient 5 [pinot]

2024-07-07 Thread via GitHub
sullis commented on code in PR #13222: URL: https://github.com/apache/pinot/pull/13222#discussion_r1667726933 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotRunningQueryResource.java: ## @@ -112,50 +116,46 @@ public String cancelQuery( @A

Re: [PR] migrate from Apache HttpClient 4 to Apache HttpClient 5 [pinot]

2024-07-07 Thread via GitHub
sullis commented on code in PR #13222: URL: https://github.com/apache/pinot/pull/13222#discussion_r1667726855 ## pinot-common/src/main/java/org/apache/pinot/common/minion/MinionClient.java: ## @@ -72,8 +72,8 @@ public Map scheduleMinionTasks(@Nullable String taskType, @Nulla

[PR] Adding pinot-docs(https://github.com/pinot-contrib/pinot-docs) repo to docs/ directory as a submodule [pinot]

2024-07-07 Thread via GitHub
xiangfu0 opened a new pull request, #13553: URL: https://github.com/apache/pinot/pull/13553 Adding pinot-docs(https://github.com/pinot-contrib/pinot-docs) repo to docs/ directory as a submodule -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] migrate from Apache HttpClient 4 to Apache HttpClient 5 [pinot]

2024-07-07 Thread via GitHub
sullis commented on code in PR #13222: URL: https://github.com/apache/pinot/pull/13222#discussion_r1667711824 ## pinot-common/src/main/java/org/apache/pinot/common/minion/MinionClient.java: ## @@ -72,8 +72,8 @@ public Map scheduleMinionTasks(@Nullable String taskType, @Nulla