Re: [I] Unable to execute query with Multi-Stage Engine [pinot]

2024-06-11 Thread via GitHub
vineethvp commented on issue #12961: URL: https://github.com/apache/pinot/issues/12961#issuecomment-2162027600 @Jackie-Jiang Sure, Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

(pinot) branch master updated (36ce140f18 -> 0689175c1d)

2024-06-11 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 36ce140f18 fix race condition in `ScalingThreadPoolExecutor` (#13360) add 0689175c1d Support array sum aggregatio

Re: [PR] Support array sum aggregation function [pinot]

2024-06-11 Thread via GitHub
xiangfu0 merged PR #13324: URL: https://github.com/apache/pinot/pull/13324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

Re: [I] Our Pinot cluster is not highly available [pinot]

2024-06-11 Thread via GitHub
piby180 commented on issue #12888: URL: https://github.com/apache/pinot/issues/12888#issuecomment-2161844064 @vineethvp @xiangfu0 Looks like I finally hit the jackpot on this issue after 2 months. I have added the following to pinot-server-headless and pinot-broker-headless s

Re: [I] Our Pinot cluster is not highly available [pinot]

2024-06-11 Thread via GitHub
piby180 commented on issue #12888: URL: https://github.com/apache/pinot/issues/12888#issuecomment-2161795276 We have `terminationGracePeriodSeconds: 300` . This means k8s will allow a grace period of 5 mins before the server can shut down gracefully. After 5 mins, k8s will then kill the ser

Re: [I] Unable to execute query with Multi-Stage Engine [pinot]

2024-06-11 Thread via GitHub
Jackie-Jiang commented on issue #12961: URL: https://github.com/apache/pinot/issues/12961#issuecomment-2161789571 I don't follow. Rebuild a project shouldn't cause any data lost. You might find more help in the slack troubleshooting channel -- This is an automated message from the Apache

(pinot) branch master updated: fix race condition in `ScalingThreadPoolExecutor` (#13360)

2024-06-11 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 36ce140f18 fix race condition in `ScalingThreadPo

Re: [PR] fix race condition in `ScalingThreadPoolExecutor` [pinot]

2024-06-11 Thread via GitHub
Jackie-Jiang merged PR #13360: URL: https://github.com/apache/pinot/pull/13360 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [I] Realtime servers reporting lag for partitions they don't own after rebalancing w/o including consuming segments [pinot]

2024-06-11 Thread via GitHub
Jackie-Jiang commented on issue #11448: URL: https://github.com/apache/pinot/issues/11448#issuecomment-2161786883 I see. I think this is the root cause. Ideally when segment got committed, it should be moved directly to the new servers. Let me check the history and see if we intentionally k

Re: [I] Our Pinot cluster is not highly available [pinot]

2024-06-11 Thread via GitHub
xiangfu0 commented on issue #12888: URL: https://github.com/apache/pinot/issues/12888#issuecomment-2161749649 Can you describe the Pinot server statefulset and check the liveness probe? I have a feeling that the pod went down faster than the server was marked down. -- This is

(pinot) branch master updated: Optimize snapshot flow to only snapshot segments which have updates (#13285)

2024-06-11 Thread xbli
This is an automated email from the ASF dual-hosted git repository. xbli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new d91ad73fec Optimize snapshot flow to only snapshot

Re: [PR] Optimize snapshot flow to only snapshot segments which have updates [pinot]

2024-06-11 Thread via GitHub
klsince merged PR #13285: URL: https://github.com/apache/pinot/pull/13285 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

Re: [I] Our Pinot cluster is not highly available [pinot]

2024-06-11 Thread via GitHub
piby180 commented on issue #12888: URL: https://github.com/apache/pinot/issues/12888#issuecomment-2161694712 Hi @vineethvp 1. Pinot upgrade to 1.1.0 didn't help us. 2. We are still facing the issue but we have reduced the downtime window by optimally using probes especially st

(pinot) branch master updated: Fix NPE in ArrayAgg functions (#13358)

2024-06-11 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 5c75b15234 Fix NPE in ArrayAgg functions (#13358

Re: [PR] Fix NPE in ArrayAgg extractFinalResult functions [pinot]

2024-06-11 Thread via GitHub
xiangfu0 merged PR #13358: URL: https://github.com/apache/pinot/pull/13358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

Re: [PR] add url assertion to SegmentCompletionProtocolTest [pinot]

2024-06-11 Thread via GitHub
sullis commented on PR #13373: URL: https://github.com/apache/pinot/pull/13373#issuecomment-2161652710 PTAL @Jackie-Jiang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] add url assertion to SegmentCompletionProtocolTest [pinot]

2024-06-11 Thread via GitHub
sullis commented on PR #13373: URL: https://github.com/apache/pinot/pull/13373#issuecomment-2161598857 Ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] UI Load time Improvement API Fixes #13278 [pinot]

2024-06-11 Thread via GitHub
deepthi912 commented on code in PR #13296: URL: https://github.com/apache/pinot/pull/13296#discussion_r1635372905 ## pinot-controller/src/main/resources/app/utils/PinotMethodUtils.ts: ## @@ -436,7 +434,7 @@ const getAllTableDetails = (tablesList) => { if (tablesList.length) {

Re: [I] Realtime servers reporting lag for partitions they don't own after rebalancing w/o including consuming segments [pinot]

2024-06-11 Thread via GitHub
priyen commented on issue #11448: URL: https://github.com/apache/pinot/issues/11448#issuecomment-2161583548 @Jackie-Jiang , after force commit the committed segment remains on the same server unless another rebalance is triggered. To reproduce this issue, you rebalance w/o consuming, and th

Re: [PR] Optimize snapshot flow to only snapshot segments which have updates [pinot]

2024-06-11 Thread via GitHub
tibrewalpratik17 commented on code in PR #13285: URL: https://github.com/apache/pinot/pull/13285#discussion_r1635407104 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java: ## @@ -874,19 +879,32 @@ protected void doT

Re: [PR] Optimize snapshot flow to only snapshot segments which have updates [pinot]

2024-06-11 Thread via GitHub
klsince commented on code in PR #13285: URL: https://github.com/apache/pinot/pull/13285#discussion_r1635397699 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java: ## @@ -874,19 +879,32 @@ protected void doTakeSnapsh

Re: [PR] Optimize snapshot flow to only snapshot segments which have updates [pinot]

2024-06-11 Thread via GitHub
klsince commented on code in PR #13285: URL: https://github.com/apache/pinot/pull/13285#discussion_r1635387402 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java: ## @@ -874,19 +879,32 @@ protected void doTakeSnapsh

Re: [PR] Optimize snapshot flow to only snapshot segments which have updates [pinot]

2024-06-11 Thread via GitHub
tibrewalpratik17 commented on code in PR #13285: URL: https://github.com/apache/pinot/pull/13285#discussion_r1635375547 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java: ## @@ -874,19 +879,32 @@ protected void doT

Re: [PR] UI Load time Improvement API Fixes #13278 [pinot]

2024-06-11 Thread via GitHub
deepthi912 commented on code in PR #13296: URL: https://github.com/apache/pinot/pull/13296#discussion_r1635374831 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java: ## @@ -230,25 +231,54 @@ public List>> getSegments(

Re: [PR] UI Load time Improvement API Fixes #13278 [pinot]

2024-06-11 Thread via GitHub
deepthi912 commented on code in PR #13296: URL: https://github.com/apache/pinot/pull/13296#discussion_r1635372905 ## pinot-controller/src/main/resources/app/utils/PinotMethodUtils.ts: ## @@ -436,7 +434,7 @@ const getAllTableDetails = (tablesList) => { if (tablesList.length) {

Re: [PR] Optimize snapshot flow to only snapshot segments which have updates [pinot]

2024-06-11 Thread via GitHub
klsince commented on code in PR #13285: URL: https://github.com/apache/pinot/pull/13285#discussion_r1635324871 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java: ## @@ -874,19 +879,32 @@ protected void doTakeSnapsh

Re: [PR] fix race condition in `ScalingThreadPoolExecutor` [pinot]

2024-06-11 Thread via GitHub
Jackie-Jiang commented on code in PR #13360: URL: https://github.com/apache/pinot/pull/13360#discussion_r1635274958 ## pinot-common/src/main/java/org/apache/pinot/common/utils/ScalingThreadPoolExecutor.java: ## @@ -100,29 +100,42 @@ public void rejectedExecution(Runnable r, Thr

(pinot) branch dependabot/maven/com.azure-azure-identity-1.12.2 deleted (was 90478358f7)

2024-06-11 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/com.azure-azure-identity-1.12.2 in repository https://gitbox.apache.org/repos/asf/pinot.git was 90478358f7 Bump com.azure:azure-identity from 1.12.1 to 1.12.2 The revision

(pinot) branch master updated: Bump com.azure:azure-identity from 1.12.1 to 1.12.2 (#13368)

2024-06-11 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new ae4e7de424 Bump com.azure:azure-identity from 1.1

Re: [PR] Bump com.azure:azure-identity from 1.12.1 to 1.12.2 [pinot]

2024-06-11 Thread via GitHub
Jackie-Jiang merged PR #13368: URL: https://github.com/apache/pinot/pull/13368 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.25.70 deleted (was f273eb0436)

2024-06-11 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.25.70 in repository https://gitbox.apache.org/repos/asf/pinot.git was f273eb0436 Bump software.amazon.awssdk:bom from 2.25.69 to 2.25.70 The r

(pinot) branch master updated: Bump software.amazon.awssdk:bom from 2.25.69 to 2.25.70 (#13369)

2024-06-11 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 64a2ba66c0 Bump software.amazon.awssdk:bom from 2

Re: [PR] Bump software.amazon.awssdk:bom from 2.25.69 to 2.25.70 [pinot]

2024-06-11 Thread via GitHub
Jackie-Jiang merged PR #13369: URL: https://github.com/apache/pinot/pull/13369 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Bump com.google.protobuf:protobuf-bom from 3.25.3 to 4.27.1 [pinot]

2024-06-11 Thread via GitHub
dependabot[bot] commented on PR #13365: URL: https://github.com/apache/pinot/pull/13365#issuecomment-2161297689 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

(pinot) branch dependabot/maven/com.google.protobuf-protobuf-bom-4.27.1 deleted (was 67fc9a53b9)

2024-06-11 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.google.protobuf-protobuf-bom-4.27.1 in repository https://gitbox.apache.org/repos/asf/pinot.git was 67fc9a53b9 Bump com.google.protobuf:protobuf-bom from 3.25.3 to

Re: [PR] Bump com.google.protobuf:protobuf-bom from 3.25.3 to 4.27.1 [pinot]

2024-06-11 Thread via GitHub
Jackie-Jiang commented on PR #13365: URL: https://github.com/apache/pinot/pull/13365#issuecomment-2161297643 Find this related issue: https://github.com/grpc/grpc-java/issues/11015 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] Bump com.google.protobuf:protobuf-bom from 3.25.3 to 4.27.1 [pinot]

2024-06-11 Thread via GitHub
Jackie-Jiang closed pull request #13365: Bump com.google.protobuf:protobuf-bom from 3.25.3 to 4.27.1 URL: https://github.com/apache/pinot/pull/13365 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] add url assertion to SegmentCompletionProtocolTest [pinot]

2024-06-11 Thread via GitHub
codecov-commenter commented on PR #13373: URL: https://github.com/apache/pinot/pull/13373#issuecomment-2161276156 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13373?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

(pinot) branch master updated: Exclude dimensions from star-tree index stored type check (#13355)

2024-06-11 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new ec1d187475 Exclude dimensions from star-tree inde

(pinot) branch master updated (8431fa4b18 -> d85f42204c)

2024-06-11 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 8431fa4b18 Bump io.projectreactor:reactor-core from 3.6.6 to 3.6.7 (#13366) add d85f42204c Bump org.apache.common

Re: [PR] Exclude dimensions from star-tree index stored type check [pinot]

2024-06-11 Thread via GitHub
Jackie-Jiang merged PR #13355: URL: https://github.com/apache/pinot/pull/13355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch dependabot/maven/commons-net-commons-net-3.11.1 deleted (was 8af2813ad7)

2024-06-11 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/commons-net-commons-net-3.11.1 in repository https://gitbox.apache.org/repos/asf/pinot.git was 8af2813ad7 Bump commons-net:commons-net from 3.11.0 to 3.11.1 The revisions t

(pinot) branch master updated: Bump commons-net:commons-net from 3.11.0 to 3.11.1 (#13363)

2024-06-11 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 3752ee1d6f Bump commons-net:commons-net from 3.11

Re: [PR] Bump commons-net:commons-net from 3.11.0 to 3.11.1 [pinot]

2024-06-11 Thread via GitHub
Jackie-Jiang merged PR #13363: URL: https://github.com/apache/pinot/pull/13363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch dependabot/maven/org.apache.commons-commons-configuration2-2.11.0 deleted (was b0f4af342e)

2024-06-11 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/org.apache.commons-commons-configuration2-2.11.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was b0f4af342e Bump org.apache.commons:commons-configuration2 f

Re: [PR] Bump org.apache.commons:commons-configuration2 from 2.10.1 to 2.11.0 [pinot]

2024-06-11 Thread via GitHub
Jackie-Jiang merged PR #13364: URL: https://github.com/apache/pinot/pull/13364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch dependabot/maven/io.projectreactor-reactor-core-3.6.7 deleted (was a202653936)

2024-06-11 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/io.projectreactor-reactor-core-3.6.7 in repository https://gitbox.apache.org/repos/asf/pinot.git was a202653936 Bump io.projectreactor:reactor-core from 3.6.6 to 3.6.7 The

(pinot) branch master updated (0ac6f19c74 -> 8431fa4b18)

2024-06-11 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 0ac6f19c74 Bump io.netty:netty-bom from 4.1.110.Final to 4.1.111.Final (#13367) add 8431fa4b18 Bump io.projectrea

Re: [PR] Bump io.projectreactor:reactor-core from 3.6.6 to 3.6.7 [pinot]

2024-06-11 Thread via GitHub
Jackie-Jiang merged PR #13366: URL: https://github.com/apache/pinot/pull/13366 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch dependabot/maven/io.netty-netty-bom-4.1.111.Final deleted (was a57de7fbc7)

2024-06-11 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/io.netty-netty-bom-4.1.111.Final in repository https://gitbox.apache.org/repos/asf/pinot.git was a57de7fbc7 Bump io.netty:netty-bom from 4.1.110.Final to 4.1.111.Final The

(pinot) branch master updated (5c097fcc38 -> 0ac6f19c74)

2024-06-11 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 5c097fcc38 Bump io.grpc:grpc-bom from 1.62.2 to 1.64.0 (#13370) add 0ac6f19c74 Bump io.netty:netty-bom from 4.1.11

Re: [PR] Bump io.netty:netty-bom from 4.1.110.Final to 4.1.111.Final [pinot]

2024-06-11 Thread via GitHub
Jackie-Jiang merged PR #13367: URL: https://github.com/apache/pinot/pull/13367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch dependabot/maven/com.google.protobuf-protobuf-bom-4.27.1 updated (90a6342076 -> 67fc9a53b9)

2024-06-11 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.google.protobuf-protobuf-bom-4.27.1 in repository https://gitbox.apache.org/repos/asf/pinot.git discard 90a6342076 Bump com.google.protobuf:protobuf-bom from 3.25.3 to

(pinot) branch master updated (5ca1d97bce -> 5c097fcc38)

2024-06-11 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 5ca1d97bce Fix [Type]ArrayList elements() method usage (#13354) add 5c097fcc38 Bump io.grpc:grpc-bom from 1.62.2 t

(pinot) branch dependabot/maven/io.grpc-grpc-bom-1.64.0 deleted (was c244bff333)

2024-06-11 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/io.grpc-grpc-bom-1.64.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was c244bff333 Bump io.grpc:grpc-bom from 1.62.2 to 1.64.0 The revisions that were on th

Re: [PR] Bump io.grpc:grpc-bom from 1.62.2 to 1.64.0 [pinot]

2024-06-11 Thread via GitHub
Jackie-Jiang merged PR #13370: URL: https://github.com/apache/pinot/pull/13370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] UI Load time Improvement API Fixes #13278 [pinot]

2024-06-11 Thread via GitHub
deepthi912 commented on code in PR #13296: URL: https://github.com/apache/pinot/pull/13296#discussion_r1635215850 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java: ## @@ -230,25 +231,54 @@ public List>> getSegments(

Re: [PR] Optimize snapshot flow to only snapshot segments which have updates [pinot]

2024-06-11 Thread via GitHub
tibrewalpratik17 commented on code in PR #13285: URL: https://github.com/apache/pinot/pull/13285#discussion_r1635213152 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -703,9 +703,20 @@ public void run() { /

[PR] add url assertion to SegmentCompletionProtocolTest [pinot]

2024-06-11 Thread via GitHub
sullis opened a new pull request, #13373: URL: https://github.com/apache/pinot/pull/13373 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [PR] Optimize snapshot flow to only snapshot segments which have updates [pinot]

2024-06-11 Thread via GitHub
klsince commented on code in PR #13285: URL: https://github.com/apache/pinot/pull/13285#discussion_r1635184124 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -703,9 +703,20 @@ public void run() { // persi

[PR] Add retry policy to wait for job id to persist during rebalancing [pinot]

2024-06-11 Thread via GitHub
tahaboty-stripe opened a new pull request, #13372: URL: https://github.com/apache/pinot/pull/13372 When rebalancing tables with a large number of segments, it takes a while for the jobId to persist in Zookeeper and polling for the jobId results in a ResourceNotFoundException, even though it

(pinot) branch master updated: Fix [Type]ArrayList elements() method usage (#13354)

2024-06-11 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 5ca1d97bce Fix [Type]ArrayList elements() method

Re: [PR] Fix all typed ArrayList elements() method usage [pinot]

2024-06-11 Thread via GitHub
xiangfu0 merged PR #13354: URL: https://github.com/apache/pinot/pull/13354 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

Re: [PR] Bump io.netty:netty-bom from 4.1.110.Final to 4.1.111.Final [pinot]

2024-06-11 Thread via GitHub
sullis commented on PR #13367: URL: https://github.com/apache/pinot/pull/13367#issuecomment-2160938269 Netty 4.1.111 release notes: https://netty.io/news/2024/06/11/4-1-111-Final.html LGTM -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [I] Our Pinot cluster is not highly available [pinot]

2024-06-11 Thread via GitHub
vineethvp commented on issue #12888: URL: https://github.com/apache/pinot/issues/12888#issuecomment-2160876945 @piby180 We are also having similar configurations which have deployed in prod. It would be great if you can post your observations here. Couple of questions, 1. Does Pinot upgr

Re: [I] Unable to execute query with Multi-Stage Engine [pinot]

2024-06-11 Thread via GitHub
vineethvp commented on issue #12961: URL: https://github.com/apache/pinot/issues/12961#issuecomment-2160824132 @Jackie-Jiang Can we rebuild without losing the data and other configurations? Could you please provide some reference on upgrading the cluster? cluster is currently running on k8

Re: [PR] Move BrokerSelector and implementations to pinot-common [pinot]

2024-06-11 Thread via GitHub
yashmayya commented on PR #13361: URL: https://github.com/apache/pinot/pull/13361#issuecomment-2160737936 @vrajat it looks like some unit tests in `DynamicBrokerSelectorTest` and `ExternalViewReaderTest` are failing due to this change. -- This is an automated message from the Apache Git

[PR] Use a two server setup for multi-stage query engine backward compatibility regression test suite [pinot]

2024-06-11 Thread via GitHub
yashmayya opened a new pull request, #13371: URL: https://github.com/apache/pinot/pull/13371 - https://github.com/apache/pinot/pull/13193 added a backward compatibility regression test suite for the multi-stage query engine, leveraging the framework added in https://github.com/apache/pinot/

Re: [PR] [Minor] Handle 403 response to send the message as HTTP response [pinot]

2024-06-11 Thread via GitHub
eaugene commented on PR #13292: URL: https://github.com/apache/pinot/pull/13292#issuecomment-2160536936 @Jackie-Jiang That's a bit more effort I suppose as that requires refactoring the existing exception mappers into a common package ( possibly `pinot-spi` ) and making them as providers to

Re: [PR] Support empty segments for realtime tables [pinot]

2024-06-11 Thread via GitHub
codecov-commenter commented on PR #13362: URL: https://github.com/apache/pinot/pull/13362#issuecomment-2160518080 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13362?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

(pinot) branch dependabot/maven/io.grpc-grpc-bom-1.64.0 created (now c244bff333)

2024-06-11 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/io.grpc-grpc-bom-1.64.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at c244bff333 Bump io.grpc:grpc-bom from 1.62.2 to 1.64.0 No new revisions were add

[PR] Bump io.netty:netty-bom from 4.1.110.Final to 4.1.111.Final [pinot]

2024-06-11 Thread via GitHub
dependabot[bot] opened a new pull request, #13367: URL: https://github.com/apache/pinot/pull/13367 Bumps [io.netty:netty-bom](https://github.com/netty/netty) from 4.1.110.Final to 4.1.111.Final. Commits https://github.com/netty/netty/commit/90c5fd78c12ffe4698795e44fc6d865d3622c

[PR] Bump io.grpc:grpc-bom from 1.62.2 to 1.64.0 [pinot]

2024-06-11 Thread via GitHub
dependabot[bot] opened a new pull request, #13370: URL: https://github.com/apache/pinot/pull/13370 Bumps [io.grpc:grpc-bom](https://github.com/grpc/grpc-java) from 1.62.2 to 1.64.0. Release notes Sourced from https://github.com/grpc/grpc-java/releases";>io.grpc:grpc-bom's releases

[PR] Bump com.azure:azure-identity from 1.12.1 to 1.12.2 [pinot]

2024-06-11 Thread via GitHub
dependabot[bot] opened a new pull request, #13368: URL: https://github.com/apache/pinot/pull/13368 Bumps [com.azure:azure-identity](https://github.com/Azure/azure-sdk-for-java) from 1.12.1 to 1.12.2. Release notes Sourced from https://github.com/Azure/azure-sdk-for-java/releases";

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.25.70 created (now f273eb0436)

2024-06-11 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.25.70 in repository https://gitbox.apache.org/repos/asf/pinot.git at f273eb0436 Bump software.amazon.awssdk:bom from 2.25.69 to 2.25.70 N

[PR] Bump software.amazon.awssdk:bom from 2.25.69 to 2.25.70 [pinot]

2024-06-11 Thread via GitHub
dependabot[bot] opened a new pull request, #13369: URL: https://github.com/apache/pinot/pull/13369 Bumps software.amazon.awssdk:bom from 2.25.69 to 2.25.70. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=softwa

(pinot) branch dependabot/maven/com.azure-azure-identity-1.12.2 created (now 90478358f7)

2024-06-11 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.azure-azure-identity-1.12.2 in repository https://gitbox.apache.org/repos/asf/pinot.git at 90478358f7 Bump com.azure:azure-identity from 1.12.1 to 1.12.2 No new r

(pinot) branch dependabot/maven/io.netty-netty-bom-4.1.111.Final created (now a57de7fbc7)

2024-06-11 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/io.netty-netty-bom-4.1.111.Final in repository https://gitbox.apache.org/repos/asf/pinot.git at a57de7fbc7 Bump io.netty:netty-bom from 4.1.110.Final to 4.1.111.Final

(pinot) branch dependabot/maven/io.projectreactor-reactor-core-3.6.7 created (now a202653936)

2024-06-11 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/io.projectreactor-reactor-core-3.6.7 in repository https://gitbox.apache.org/repos/asf/pinot.git at a202653936 Bump io.projectreactor:reactor-core from 3.6.6 to 3.6.7

[PR] Bump io.projectreactor:reactor-core from 3.6.6 to 3.6.7 [pinot]

2024-06-11 Thread via GitHub
dependabot[bot] opened a new pull request, #13366: URL: https://github.com/apache/pinot/pull/13366 Bumps [io.projectreactor:reactor-core](https://github.com/reactor/reactor-core) from 3.6.6 to 3.6.7. Release notes Sourced from https://github.com/reactor/reactor-core/releases";>io.

(pinot) branch dependabot/maven/com.google.protobuf-protobuf-bom-4.27.1 created (now 90a6342076)

2024-06-11 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.google.protobuf-protobuf-bom-4.27.1 in repository https://gitbox.apache.org/repos/asf/pinot.git at 90a6342076 Bump com.google.protobuf:protobuf-bom from 3.25.3 to

[PR] Bump com.google.protobuf:protobuf-bom from 3.25.3 to 4.27.1 [pinot]

2024-06-11 Thread via GitHub
dependabot[bot] opened a new pull request, #13365: URL: https://github.com/apache/pinot/pull/13365 Bumps [com.google.protobuf:protobuf-bom](https://github.com/protocolbuffers/protobuf) from 3.25.3 to 4.27.1. Commits See full diff in https://github.com/protocolbuffers/protobuf/

[PR] Bump org.apache.commons:commons-configuration2 from 2.10.1 to 2.11.0 [pinot]

2024-06-11 Thread via GitHub
dependabot[bot] opened a new pull request, #13364: URL: https://github.com/apache/pinot/pull/13364 Bumps org.apache.commons:commons-configuration2 from 2.10.1 to 2.11.0. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependenc

(pinot) branch dependabot/maven/org.apache.commons-commons-configuration2-2.11.0 created (now b0f4af342e)

2024-06-11 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.apache.commons-commons-configuration2-2.11.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at b0f4af342e Bump org.apache.commons:commons-configuratio

[PR] Bump commons-net:commons-net from 3.11.0 to 3.11.1 [pinot]

2024-06-11 Thread via GitHub
dependabot[bot] opened a new pull request, #13363: URL: https://github.com/apache/pinot/pull/13363 Bumps commons-net:commons-net from 3.11.0 to 3.11.1. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=commons-net

(pinot) branch dependabot/maven/commons-net-commons-net-3.11.1 created (now 8af2813ad7)

2024-06-11 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/commons-net-commons-net-3.11.1 in repository https://gitbox.apache.org/repos/asf/pinot.git at 8af2813ad7 Bump commons-net:commons-net from 3.11.0 to 3.11.1 No new rev

[PR] Support empty segments for realtime tables [pinot]

2024-06-11 Thread via GitHub
tibrewalpratik17 opened a new pull request, #13362: URL: https://github.com/apache/pinot/pull/13362 Addresses #12703 This patch allows persistence of empty segments in case of no messages in realtime ingestion. Right now, it can happen that a segment is stuck in CONSUMING state for m

Re: [PR] Move BrokerSelector and implementations to pinot-common [pinot]

2024-06-11 Thread via GitHub
codecov-commenter commented on PR #13361: URL: https://github.com/apache/pinot/pull/13361#issuecomment-2160426035 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Move BrokerSelector and implementations to pinot-common [pinot]

2024-06-11 Thread via GitHub
vrajat opened a new pull request, #13361: URL: https://github.com/apache/pinot/pull/13361 BrokerSelector is useful in other components when an appropriate broker has to be selected. For example, the controller has to choose a broker that can process all tables in a V2 query. Move

Re: [PR] UI Load time Improvement API Fixes #13278 [pinot]

2024-06-11 Thread via GitHub
jayeshchoudhary commented on code in PR #13296: URL: https://github.com/apache/pinot/pull/13296#discussion_r1634466327 ## pinot-controller/src/main/resources/app/utils/PinotMethodUtils.ts: ## @@ -436,7 +434,7 @@ const getAllTableDetails = (tablesList) => { if (tablesList.leng

Re: [PR] UI Load time Improvement API Fixes #13278 [pinot]

2024-06-11 Thread via GitHub
jayeshchoudhary commented on code in PR #13296: URL: https://github.com/apache/pinot/pull/13296#discussion_r1634455943 ## pinot-controller/src/main/resources/app/requests/index.ts: ## @@ -89,8 +93,8 @@ export const putSchema = (name: string, params: string, reload?: boolean): P

Re: [PR] UI Load time Improvement API Fixes #13278 [pinot]

2024-06-11 Thread via GitHub
jayeshchoudhary commented on code in PR #13296: URL: https://github.com/apache/pinot/pull/13296#discussion_r1634455943 ## pinot-controller/src/main/resources/app/requests/index.ts: ## @@ -89,8 +93,8 @@ export const putSchema = (name: string, params: string, reload?: boolean): P

Re: [PR] Optimize snapshot flow to only snapshot segments which have updates [pinot]

2024-06-11 Thread via GitHub
tibrewalpratik17 commented on code in PR #13285: URL: https://github.com/apache/pinot/pull/13285#discussion_r1634413636 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -703,9 +703,20 @@ public void run() { /

Re: [PR] Fix all typed ArrayList elements() method usage [pinot]

2024-06-11 Thread via GitHub
xiangfu0 commented on code in PR #13354: URL: https://github.com/apache/pinot/pull/13354#discussion_r1634393371 ## pinot-common/src/main/java/org/apache/pinot/common/utils/ArrayListUtils.java: ## @@ -0,0 +1,124 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under o