Re: [PR] Improve Retention Manager Segment Lineage Clean Up [pinot]

2024-06-08 Thread via GitHub
Jackie-Jiang commented on code in PR #13232: URL: https://github.com/apache/pinot/pull/13232#discussion_r1632163691 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/RetentionManager.java: ## @@ -55,7 +55,7 @@ */ public class RetentionManager

(pinot) branch master updated: Fix array literal handling (#13345)

2024-06-08 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 8e5e8d915e Fix array literal handling (#13345) 8e

Re: [PR] Fix array literal handling [pinot]

2024-06-08 Thread via GitHub
Jackie-Jiang merged PR #13345: URL: https://github.com/apache/pinot/pull/13345 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated: Improve Retention Manager Segment Lineage Clean Up (#13232)

2024-06-08 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 5da68d7ff0 Improve Retention Manager Segment Line

Re: [PR] Improve Retention Manager Segment Lineage Clean Up [pinot]

2024-06-08 Thread via GitHub
Jackie-Jiang merged PR #13232: URL: https://github.com/apache/pinot/pull/13232 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [I] Improve Retention Manager side segment lineage clean up [pinot]

2024-06-08 Thread via GitHub
Jackie-Jiang closed issue #13171: Improve Retention Manager side segment lineage clean up URL: https://github.com/apache/pinot/issues/13171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Fix array literal handling [pinot]

2024-06-08 Thread via GitHub
codecov-commenter commented on PR #13345: URL: https://github.com/apache/pinot/pull/13345#issuecomment-2156149369 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13345?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Fix array literal handling [pinot]

2024-06-08 Thread via GitHub
Jackie-Jiang opened a new pull request, #13345: URL: https://github.com/apache/pinot/pull/13345 - Store array (primitive array if possible) instead of `List` in `LiteralContext` because it is the internal representation of array - Fix the missing int bits conversion for `FLOAT_ARRAY` -

Re: [PR] Optimize snapshot flow to only snapshot segments which have updates [pinot]

2024-06-08 Thread via GitHub
tibrewalpratik17 commented on code in PR #13285: URL: https://github.com/apache/pinot/pull/13285#discussion_r1631691980 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java: ## @@ -832,8 +836,10 @@ public void takeSna

Re: [PR] [Backfill] allow externally partitioned segment uploads for upsert tables [pinot]

2024-06-08 Thread via GitHub
klsince commented on code in PR #13107: URL: https://github.com/apache/pinot/pull/13107#discussion_r1631741645 ## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/creator/name/UploadedRealtimeSegmentNameGenerator.java: ## @@ -0,0 +1,93 @@ +/** + * Licensed to the Apa

(pinot) branch master updated: [Multi-stage] Fix literal handling (#13344)

2024-06-08 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 1229add21e [Multi-stage] Fix literal handling (#1

Re: [PR] [Multi-stage] Fix literal handling [pinot]

2024-06-08 Thread via GitHub
Jackie-Jiang merged PR #13344: URL: https://github.com/apache/pinot/pull/13344 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Reposition query submission spot for adaptive server selection [pinot]

2024-06-08 Thread via GitHub
vvivekiyer merged PR #13327: URL: https://github.com/apache/pinot/pull/13327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.a

(pinot) branch master updated: Reposition query submission spot for adaptive server selection (#13327)

2024-06-08 Thread vvivekiyer
This is an automated email from the ASF dual-hosted git repository. vvivekiyer pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 61aa6ce468 Reposition query submission spot f

Re: [PR] Support array sum aggregation function [pinot]

2024-06-08 Thread via GitHub
Jackie-Jiang commented on code in PR #13324: URL: https://github.com/apache/pinot/pull/13324#discussion_r1631974398 ## pinot-core/src/main/java/org/apache/pinot/core/operator/docvalsets/RowBasedBlockValSet.java: ## @@ -400,27 +400,212 @@ public int[][] getDictionaryIdsMV() {

(pinot) branch master updated: allow to set segment when use SegmentProcessorFramework (#13341)

2024-06-08 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 70412e624e allow to set segment when use Segment

Re: [PR] allow to set segment when use SegmentProcessorFramework [pinot]

2024-06-08 Thread via GitHub
xiangfu0 merged PR #13341: URL: https://github.com/apache/pinot/pull/13341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

Re: [PR] Support more arguments for LEAD/LAG window functions [pinot]

2024-06-08 Thread via GitHub
xiangfu0 merged PR #13340: URL: https://github.com/apache/pinot/pull/13340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

(pinot) branch master updated: Fix LEAD/LAG window function implementation (#13340)

2024-06-08 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 0dcad92828 Fix LEAD/LAG window function implemen