Re: [PR] Serialize V2 Plan using Protobufs instead of reflection. [pinot]

2024-05-24 Thread via GitHub
codecov-commenter commented on PR #13221: URL: https://github.com/apache/pinot/pull/13221#issuecomment-2130752223 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13221?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

(pinot) branch master updated: ensure inverse And/OrFilterOperator implementations match the query (#13199)

2024-05-24 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new e84f3f5667 ensure inverse And/OrFilterOperator im

Re: [PR] ensure inverse And/OrFilterOperator implementations match the query [pinot]

2024-05-24 Thread via GitHub
Jackie-Jiang merged PR #13199: URL: https://github.com/apache/pinot/pull/13199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Allow all raw index config in star-tree index [pinot]

2024-05-24 Thread via GitHub
codecov-commenter commented on PR #13225: URL: https://github.com/apache/pinot/pull/13225#issuecomment-2130660002 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13225?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Fixed infer logical type name from avro union schema [pinot]

2024-05-24 Thread via GitHub
codecov-commenter commented on PR #13224: URL: https://github.com/apache/pinot/pull/13224#issuecomment-2130643986 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13224?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Allow all raw index config in star-tree index [pinot]

2024-05-24 Thread via GitHub
Jackie-Jiang opened a new pull request, #13225: URL: https://github.com/apache/pinot/pull/13225 Add the following configs into `StarTreeAggregationConfig` as counterpart of `ForwardIndexConfig`: - deriveNumDocsPerChunk - indexVersion - targetMaxChunkSize - targetDocsPerChunk

[PR] Fixed infer logical type name from avro union schema [pinot]

2024-05-24 Thread via GitHub
rajagopr opened a new pull request, #13224: URL: https://github.com/apache/pinot/pull/13224 **TODO**: Add description -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

(pinot) 01/01: Mark resize as NumGroupsLimitReached in broker reduce phase

2024-05-24 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch mark-resize-as-NumGroupsLimitReached in repository https://gitbox.apache.org/repos/asf/pinot.git commit 2c749dfc5945c9b27b3acdc3e6b50026c61a06a0 Author: jlli_LinkedIn AuthorDate: Fri May 24 17:35:5

(pinot) branch mark-resize-as-NumGroupsLimitReached created (now 2c749dfc59)

2024-05-24 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch mark-resize-as-NumGroupsLimitReached in repository https://gitbox.apache.org/repos/asf/pinot.git at 2c749dfc59 Mark resize as NumGroupsLimitReached in broker reduce phase This branch include

Re: [PR] handle overflow for `MutableOffHeapByteArrayStore` buffer starting size [pinot]

2024-05-24 Thread via GitHub
itschrispeck commented on code in PR #13215: URL: https://github.com/apache/pinot/pull/13215#discussion_r1614150902 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/writer/impl/MutableOffHeapByteArrayStore.java: ## @@ -170,15 +170,20 @@ public void close()

Re: [PR] handle overflow for `MutableOffHeapByteArrayStore` buffer starting size [pinot]

2024-05-24 Thread via GitHub
itschrispeck commented on PR #13215: URL: https://github.com/apache/pinot/pull/13215#issuecomment-2130517286 > Having 2GB as start size doesn't look correct. Can you check the high level logic and see if this is expected? Seems like we are trying to use one single buffer to hold everything?

Re: [PR] Add support for phrase search with wildcard and prefix matching for Lucene indexed tables [pinot]

2024-05-24 Thread via GitHub
chenboat commented on PR #12680: URL: https://github.com/apache/pinot/pull/12680#issuecomment-2130509561 Release note section added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Use RexList of carray pre agg arguments for intermediate stage [pinot]

2024-05-24 Thread via GitHub
Jackie-Jiang commented on code in PR #13217: URL: https://github.com/apache/pinot/pull/13217#discussion_r1614056876 ## pinot-common/src/main/java/org/apache/pinot/common/request/context/LiteralContext.java: ## @@ -162,7 +162,17 @@ public Object getValue() { public boolean get

Re: [PR] Returning tables names failing authorization in Exception of Multi State Engine Queries [pinot]

2024-05-24 Thread via GitHub
Jackie-Jiang commented on code in PR #13195: URL: https://github.com/apache/pinot/pull/13195#discussion_r1614054911 ## pinot-broker/src/main/java/org/apache/pinot/broker/api/AccessControl.java: ## @@ -42,21 +46,58 @@ default boolean hasAccess(RequesterIdentity requesterIdentity

Re: [PR] Add config to skip record ingestion on string column length exceeding configured max schema length [pinot]

2024-05-24 Thread via GitHub
Jackie-Jiang commented on code in PR #13103: URL: https://github.com/apache/pinot/pull/13103#discussion_r1614040826 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/SanitizationTransformer.java: ## @@ -36,47 +37,108 @@ * * NOTE: should p

(pinot) branch master updated: update access control check error handling to catch throwable and log errors (#13209)

2024-05-24 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new fed2d5f1b6 update access control check error hand

Re: [PR] update access control check error handling to catch throwable and log errors [pinot]

2024-05-24 Thread via GitHub
Jackie-Jiang merged PR #13209: URL: https://github.com/apache/pinot/pull/13209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] ensure inverse And/OrFilterOperator implementations match the query [pinot]

2024-05-24 Thread via GitHub
Jackie-Jiang commented on code in PR #13199: URL: https://github.com/apache/pinot/pull/13199#discussion_r1614025009 ## pinot-core/src/main/java/org/apache/pinot/core/operator/filter/AndFilterOperator.java: ## @@ -59,13 +62,27 @@ protected BlockDocIdSet getTrues() { protected

Re: [I] Querying 2 tables across different broker tenants gives an ambiguous error message [pinot]

2024-05-24 Thread via GitHub
jadami10 commented on issue #11990: URL: https://github.com/apache/pinot/issues/11990#issuecomment-2130316805 @walterddr i just hit this again, and refound this issue. apologies for not replying. this is indeed from the controller -- This is an automated message from the Apache Git Servic

Re: [PR] migrate to Apache HttpClient 5 [pinot]

2024-05-24 Thread via GitHub
codecov-commenter commented on PR #13222: URL: https://github.com/apache/pinot/pull/13222#issuecomment-2130315688 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13222?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] migrate to Apache HttpClient 5 [pinot]

2024-05-24 Thread via GitHub
sullis opened a new pull request, #13222: URL: https://github.com/apache/pinot/pull/13222 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

(pinot) branch master updated (c5859a1a6c -> 9380168ae7)

2024-05-24 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from c5859a1a6c Bump commons-cli:commons-cli from 1.7.0 to 1.8.0 (#13220) add 9380168ae7 Bump org.apache.commons:common

(pinot) branch dependabot/maven/org.apache.commons-commons-compress-1.26.2 deleted (was 61fd783fe2)

2024-05-24 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/org.apache.commons-commons-compress-1.26.2 in repository https://gitbox.apache.org/repos/asf/pinot.git was 61fd783fe2 Bump org.apache.commons:commons-compress from 1.26.1 t

Re: [PR] Bump org.apache.commons:commons-compress from 1.26.1 to 1.26.2 [pinot]

2024-05-24 Thread via GitHub
Jackie-Jiang merged PR #13218: URL: https://github.com/apache/pinot/pull/13218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch dependabot/maven/commons-cli-commons-cli-1.8.0 deleted (was e95bd1242e)

2024-05-24 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/commons-cli-commons-cli-1.8.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was e95bd1242e Bump commons-cli:commons-cli from 1.7.0 to 1.8.0 The revisions that

(pinot) branch master updated: Bump commons-cli:commons-cli from 1.7.0 to 1.8.0 (#13220)

2024-05-24 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new c5859a1a6c Bump commons-cli:commons-cli from 1.7.

Re: [PR] Bump commons-cli:commons-cli from 1.7.0 to 1.8.0 [pinot]

2024-05-24 Thread via GitHub
Jackie-Jiang merged PR #13220: URL: https://github.com/apache/pinot/pull/13220 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[PR] Serialize V2 Plan using Protobufs instead of reflection. [pinot]

2024-05-24 Thread via GitHub
vrajat opened a new pull request, #13221: URL: https://github.com/apache/pinot/pull/13221 Plans are serialized using reflection and are identified by class names. Serialization using reflection is brittle to changes across versions e.g. class names may change. Change V2 plan serializatio

(pinot) branch dependabot/maven/commons-cli-commons-cli-1.8.0 created (now e95bd1242e)

2024-05-24 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/commons-cli-commons-cli-1.8.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at e95bd1242e Bump commons-cli:commons-cli from 1.7.0 to 1.8.0 No new revisi

[PR] Bump commons-cli:commons-cli from 1.7.0 to 1.8.0 [pinot]

2024-05-24 Thread via GitHub
dependabot[bot] opened a new pull request, #13220: URL: https://github.com/apache/pinot/pull/13220 Bumps commons-cli:commons-cli from 1.7.0 to 1.8.0. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=commons-cli:c

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.25.58 deleted (was a92cb4616b)

2024-05-24 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.25.58 in repository https://gitbox.apache.org/repos/asf/pinot.git was a92cb4616b Bump software.amazon.awssdk:bom from 2.25.57 to 2.25.58 T

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.25.59 created (now 339738f1f8)

2024-05-24 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.25.59 in repository https://gitbox.apache.org/repos/asf/pinot.git at 339738f1f8 Bump software.amazon.awssdk:bom from 2.25.57 to 2.25.59 N

Re: [PR] Bump software.amazon.awssdk:bom from 2.25.57 to 2.25.58 [pinot]

2024-05-24 Thread via GitHub
dependabot[bot] commented on PR #13211: URL: https://github.com/apache/pinot/pull/13211#issuecomment-2129300476 Superseded by #13219. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Bump software.amazon.awssdk:bom from 2.25.57 to 2.25.58 [pinot]

2024-05-24 Thread via GitHub
dependabot[bot] closed pull request #13211: Bump software.amazon.awssdk:bom from 2.25.57 to 2.25.58 URL: https://github.com/apache/pinot/pull/13211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

(pinot) branch dependabot/maven/org.apache.commons-commons-compress-1.26.2 created (now 61fd783fe2)

2024-05-24 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.apache.commons-commons-compress-1.26.2 in repository https://gitbox.apache.org/repos/asf/pinot.git at 61fd783fe2 Bump org.apache.commons:commons-compress from 1.26

[PR] Bump software.amazon.awssdk:bom from 2.25.57 to 2.25.59 [pinot]

2024-05-24 Thread via GitHub
dependabot[bot] opened a new pull request, #13219: URL: https://github.com/apache/pinot/pull/13219 Bumps software.amazon.awssdk:bom from 2.25.57 to 2.25.59. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=softwa

[PR] Bump org.apache.commons:commons-compress from 1.26.1 to 1.26.2 [pinot]

2024-05-24 Thread via GitHub
dependabot[bot] opened a new pull request, #13218: URL: https://github.com/apache/pinot/pull/13218 Bumps org.apache.commons:commons-compress from 1.26.1 to 1.26.2. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name

Re: [PR] Returning tables names failing authorization in Exception of Multi State Engine Queries [pinot]

2024-05-24 Thread via GitHub
eaugene commented on code in PR #13195: URL: https://github.com/apache/pinot/pull/13195#discussion_r1612966022 ## pinot-broker/src/main/java/org/apache/pinot/broker/api/AccessControl.java: ## @@ -42,21 +46,58 @@ default boolean hasAccess(RequesterIdentity requesterIdentity) {