Re: [PR] Add back pinot spi shading [pinot]

2024-04-20 Thread via GitHub
xiangfu0 commented on PR #12969: URL: https://github.com/apache/pinot/pull/12969#issuecomment-2067901626 Can you just add this package in the pinot-spi pom.xml file properties section. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Upgrade lucene to 9.10.0 and compatibility changes to code. [pinot]

2024-04-20 Thread via GitHub
abhioncbr commented on PR #12866: URL: https://github.com/apache/pinot/pull/12866#issuecomment-2067871551 I am seeing a similar discussion that happened last time while upgrading the Lucene library, [PR](https://github.com/apache/pinot/pull/11857). Compatability tests are failing for

Re: [PR] Avoid useless byte array allocation for VarChunkV4Reader StringMV [pinot]

2024-04-20 Thread via GitHub
codecov-commenter commented on PR #12978: URL: https://github.com/apache/pinot/pull/12978#issuecomment-2067827826 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12978?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Add threadLocal reusable byte array for VarByteChunkReaderV4 [pinot]

2024-04-20 Thread via GitHub
codecov-commenter commented on PR #12977: URL: https://github.com/apache/pinot/pull/12977#issuecomment-2067812064 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12977?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Add threadLocal reusable byte array for VarByteChunkReaderV4 [pinot]

2024-04-20 Thread via GitHub
wirybeaver opened a new pull request, #12977: URL: https://github.com/apache/pinot/pull/12977 Intuition: Reduce repeated byte array allocation on jvm heap when QPS is high. Is it thread safe? Yes, since the ReaderContext is created per SegmentPlanNode per query. A SegmentPlanNode wou

Re: [PR] Issue #12367 testCaseTransformFunctionWithIntResults test fix [pinot]

2024-04-20 Thread via GitHub
aditya0811 commented on PR #12922: URL: https://github.com/apache/pinot/pull/12922#issuecomment-2067746759 > Thanks for the fix! Can you also add a special test which will fail if the cast doesn't exist? Created a separate projectionBlock object to hold such float value, so as to not

Re: [PR] Issue #12367 testCaseTransformFunctionWithIntResults test fix [pinot]

2024-04-20 Thread via GitHub
aditya0811 commented on code in PR #12922: URL: https://github.com/apache/pinot/pull/12922#discussion_r1573357984 ## pinot-core/src/test/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunctionTest.java: ## @@ -106,7 +106,8 @@ public void testCaseTransformFun

Re: [PR] Cleanup the consumer interfaces and legacy code [pinot]

2024-04-20 Thread via GitHub
jadami10 commented on code in PR #12697: URL: https://github.com/apache/pinot/pull/12697#discussion_r1573344924 ## pinot-spi/src/main/java/org/apache/pinot/spi/stream/RowMetadata.java: ## @@ -64,24 +62,34 @@ default long getFirstStreamRecordIngestionTimeMs() { } /** -

Re: [I] Add support for Logical Tables [pinot]

2024-04-20 Thread via GitHub
hpvd commented on issue #10712: URL: https://github.com/apache/pinot/issues/10712#issuecomment-2067610622 regarding the scalability problems of zookeeper, we may want to look into Oxia as Apache Pulsar already does iOxia is advertised as: "a genuinely horizontally scalable metadata fra