aadilkhalifa commented on code in PR #12537:
URL: https://github.com/apache/pinot/pull/12537#discussion_r1519153810
##
pinot-common/src/main/java/org/apache/pinot/common/request/PinotQuery.java:
##
@@ -41,6 +41,8 @@ public class PinotQuery implements
org.apache.thrift.TBase
aadilkhalifa commented on code in PR #12537:
URL: https://github.com/apache/pinot/pull/12537#discussion_r1519153285
##
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##
@@ -150,10 +153,12 @@ public abstract class BaseBrokerReques
saurabhd336 commented on PR #12532:
URL: https://github.com/apache/pinot/pull/12532#issuecomment-1987597028
+1 to @wirybeaver's comment.
`jsonExtractIndexArray` is primarily suited for cases where the json value
itself in an array, and user wants to extract certain array elements per
codecov-commenter commented on PR #12619:
URL: https://github.com/apache/pinot/pull/12619#issuecomment-1987492037
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12619?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
sullis opened a new pull request, #12619:
URL: https://github.com/apache/pinot/pull/12619
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
xiangfu0 merged PR #12615:
URL: https://github.com/apache/pinot/pull/12615
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apa
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 1ae85e19f6 Fix pinot-parquet NoClassFound issue
codecov-commenter commented on PR #12618:
URL: https://github.com/apache/pinot/pull/12618#issuecomment-1987353757
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12618?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
codecov-commenter commented on PR #12616:
URL: https://github.com/apache/pinot/pull/12616#issuecomment-1987352354
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12616?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
codecov-commenter commented on PR #12617:
URL: https://github.com/apache/pinot/pull/12617#issuecomment-1987350923
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12617?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
sullis opened a new pull request, #12618:
URL: https://github.com/apache/pinot/pull/12618
https://github.com/apache/logging-log4j2/releases/tag/rel%2F2.23.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
sullis opened a new pull request, #12617:
URL: https://github.com/apache/pinot/pull/12617
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
sullis opened a new pull request, #12616:
URL: https://github.com/apache/pinot/pull/12616
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
codecov-commenter commented on PR #12615:
URL: https://github.com/apache/pinot/pull/12615#issuecomment-1987264268
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12615?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
karthi07 commented on PR #12610:
URL: https://github.com/apache/pinot/pull/12610#issuecomment-1987260369
@abhioncbr This is a minor frontend bug. I can create a PR if required.

--
This is
xiangfu0 opened a new pull request, #12615:
URL: https://github.com/apache/pinot/pull/12615
ParquetUtils has the
```
java.lang.NoClassDefFoundError:
org/apache/hadoop/mapreduce/lib/input/FileInputFormat
at java.base/java.lang.ClassLoader.defineClass1(Native Method) ~[?:?]
codecov-commenter commented on PR #12614:
URL: https://github.com/apache/pinot/pull/12614#issuecomment-1987250712
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12614?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
codecov-commenter commented on PR #12613:
URL: https://github.com/apache/pinot/pull/12613#issuecomment-1987248100
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12613?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
sullis opened a new pull request, #12614:
URL: https://github.com/apache/pinot/pull/12614
use the equalsverifier library to validate our 'equals' method
https://jqno.nl/equalsverifier/
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
ege-st commented on code in PR #12613:
URL: https://github.com/apache/pinot/pull/12613#discussion_r1518852505
##
pinot-query-runtime/src/test/java/org/apache/pinot/query/QueryTestSet.java:
##
@@ -106,6 +106,9 @@ public Object[][] provideTestSql() {
+ " SUM(CASE WHEN
ege-st commented on PR #12613:
URL: https://github.com/apache/pinot/pull/12613#issuecomment-1987231805
Could not find the right place to put a V1 engine unit test for this change,
so please let me know where it should go.
--
This is an automated message from the Apache Git Service.
To res
ege-st opened a new pull request, #12613:
URL: https://github.com/apache/pinot/pull/12613
(Bugfix)
In Calcite, this removes the check that prevents aggregation functions from
being used within a Case/When expression in the V1 engine.
Testing:
1. Added a unit test for V2 engi
22 matches
Mail list logo